<i18n dev> RFR: 8276220: Reduce excessive allocations in DateTimeFormatter [v8]
Naoto Sato
naoto at openjdk.java.net
Wed Nov 3 19:51:20 UTC 2021
On Wed, 3 Nov 2021 19:44:35 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> Prompted by a request from Volkan Yazıcı I took a look at why the java.time formatters are less efficient for some common patterns than custom formatters in apache-commons and log4j. This patch reduces the gap, without having looked at the third party implementations.
>>
>> When printing times:
>> - Avoid turning integral values into `String`s before appending them to the buffer
>> - Specialize `appendFraction` for `NANO_OF_SECOND` to avoid use of `BigDecimal`
>>
>> This means a speed-up and reduction in allocations when formatting almost any date or time pattern, and especially so when including sub-second parts (`S-SSSSSSSSS`).
>>
>> Much of the remaining overhead can be traced to the need to create a `DateTimePrintContext` and adjusting `Instant`s into a `ZonedDateTime` internally. We could likely also win performance by specializing some common patterns.
>>
>> Testing: tier1-3
>
> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>
> Add MICRO_OF_SECOND tests to retain proper coverage of FractionPrinterParser
Oh, just noticed the copyright year->2021 in modified files. Should have noticed before.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6188
More information about the i18n-dev
mailing list