<i18n dev> RFR: 8276794: Change nested classes in java.desktop to static nested classes [v2]

[Andrey Turbanov]

On Wed, 17 Nov 2021 14:32:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   [PATCH] Change nested classes in java.desktop to static nested classes
>>   fix review comments
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java line 3949:
> 
>> 3947:     @SuppressWarnings("serial") // Superclass is not serializable across versions
>> 3948:     private static class ScrollableTabButton extends BasicArrowButton implements UIResource,
>> 3949:                                                                             SwingConstants {
> 
> Maybe, wrap the line before implements?

done

> src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java line 2300:
> 
>> 2298: 
>> 2299: @SuppressWarnings("serial") // JDK-implementation class
>> 2300:  static class PrintToFileErrorDialog extends Dialog implements ActionListener{
> 
> There's an extra space before `static` modifier which breaks the common indentation.
> I'd also add a space before the opening brace, it's there in the following code of the class.

fixed

> src/java.desktop/windows/classes/sun/awt/windows/WScrollPanePeer.java line 165:
> 
>> 163:      */
>> 164:     @SuppressWarnings("serial") // JDK-implementation class
>> 165:      static class ScrollEvent extends PeerEvent {
> 
> There's an extra space before `static` modifier. Is it intentional?

fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/5943