<i18n dev> RFR: 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently [v2]

Naoto Sato naoto at openjdk.java.net
Mon Nov 29 21:59:35 UTC 2021

On Mon, 29 Nov 2021 21:09:47 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>>   Changed to not skipping the test in DateFormatTest.java
> test/jdk/java/text/Format/DateFormat/DateFormatTest.java line 349:
>> 347:         var defZone = ZoneId.systemDefault();
>> 348:         if (defZone.getRules().getTransition(date1.toInstant().atZone(defZone).toLocalDateTime()) != null) {
>> 349:             logln("At the offset transition. Round trip test skipped.");
> Should the message be more inlined with the test name vs indicate Round trip test is skipped?

I changed the test not to skip even at the overlap, by explicitly giving the zone pattern. Unfortunately, this cannot be applied to the other location in `NonGregorianFormatTest`, because the argument is a bare `DateFormat`.


PR: https://git.openjdk.java.net/jdk/pull/6598

More information about the i18n-dev mailing list