<i18n dev> RFR: 8274544: Langtools command's usage were garbled on Japanese Windows

Naoto Sato naoto at openjdk.java.net
Thu Oct 14 23:46:47 UTC 2021

On Mon, 4 Oct 2021 10:24:01 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Helllo @naotoj .
>> I used `System.console()` and `Console.charset()`.
>> The following executables had same issue, I fixed them.
>>> jar.exe, javac.exe, javadoc.exe, javap.exe, jdeps.exe, jlink.exe, jmod.exe, jpackage.exe
>> I could not find out the following executables had same issue or not
>>> jabswitch.exe, jcmd.exe, jfr.exe, jhsdb.exe, jimage.exe, jinfo.exe, jmap.exe, jps.exe, jrunscript.exe, jstack.exe, jstat.exe, jstatd.exe, kinit.exe, klist.exe, ktab.exe
>> The following executables worked fine.
>>> jarsigner.exe, java.exe, javaw.exe, jdb.exe, jdeprscan.exe, jshell.exe, keytool.exe, rmiregistry.exe, serialver.exe
>> The following executables were GUI apps
>>> jaccessinspector.exe, jaccesswalker.exe, jconsole.exe
>> These fixes don't have testcases.
>> Do you have any idea about testcase for this issue ?
> @takiguc - if JShell is still an issue, is there a chance you could try this:
> https://github.com/lahodaj/jdk/commit/cfa6b3eebbc22c5a48d31cfd692ff98690653686
> Not sure if it will help, but it might (this won't change the default charset, but could send the output in a sensible encoding for the console.
> Thanks!

I believe both @lahodaj and my proposed changes are needed, which I provided here: https://github.com/openjdk/jdk/commit/82a9033953655042480c90d388fcbc8053fc5ff5
Can you check this works?


PR: https://git.openjdk.java.net/jdk/pull/5771

More information about the i18n-dev mailing list