<i18n dev> RFR: 8271603: Unnecessary Vector usage in java.desktop [v6]

Andrey Turbanov github.com+741251+turbanoff at openjdk.java.net
Wed Sep 1 19:46:51 UTC 2021


> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized.
> I checked only places where `Vector` was used as local variable.

Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:

 - Merge remote-tracking branch 'origin/master' into avoid-unnecessary-vector-usage-in-java.desktop
   
   # Conflicts:
   #	src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java
 - 8271603: Unnecessary Vector usage in java.desktop
   use toArray with zero sized array in places where Vector.copyInto was used
 - 8271603: Unnecessary Vector usage in java.desktop
   migrate even more usages
 - 8271603: Unnecessary Vector usage in java.desktop
   migrate more usages. Not sure how I missed them
 - 8271603: Unnecessary Vector usage in java.desktop
   revert back to use cycle to copy into array
 - 8271603: Unnecessary Vector usage in java.desktop
   revert back to Enumeration
   bring back default values
 - [PATCH] Unnecessary Vector usage in java.desktop
   use zero-length array
 - [PATCH] Unnecessary Vector usage in java.desktop

-------------

Changes: https://git.openjdk.java.net/jdk/pull/4680/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4680&range=05
  Stats: 270 lines in 34 files changed: 19 ins; 30 del; 221 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4680.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4680/head:pull/4680

PR: https://git.openjdk.java.net/jdk/pull/4680


More information about the i18n-dev mailing list