<i18n dev> RFR: 8273616: Fix trivial doc typos in the java.base module

John R Rose jrose at openjdk.java.net
Fri Sep 10 21:58:48 UTC 2021


On Fri, 10 Sep 2021 21:16:19 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> 8273616: Fix trivial doc typos in the java.base module

Approved, except for two changes commented above: the original "it need only force" is correct usage, and "it needs only force" is not good usage, but "it only needs to force" would be clearer and also correct.

src/java.base/share/classes/java/nio/channels/AsynchronousFileChannel.java line 399:

> 397:      *          If {@code true} then this method is required to force changes
> 398:      *          to both the file's content and metadata to be written to
> 399:      *          storage; otherwise, it needs only force content changes to be

This is a correct though rare use of subjunctive mood:  One need not change it.
However, if be desired that we change the mood to indicative, I suggest s/it need only force/it only needs to force/.

src/java.base/share/classes/java/nio/channels/FileChannel.java line 567:

> 565:      *          If {@code true} then this method is required to force changes
> 566:      *          to both the file's content and metadata to be written to
> 567:      *          storage; otherwise, it needs only force content changes to be

(same as previous comment:  the suggested fix makes the English *less* correct)

-------------

Marked as reviewed by jrose (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5475


More information about the i18n-dev mailing list