From djelinski at openjdk.java.net  Wed Apr  6 12:14:11 2022
From: djelinski at openjdk.java.net (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Wed, 6 Apr 2022 12:14:11 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo
Message-ID: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>

This patch adds missing `r` in `string`s

-------------

Commit messages:
 - Fix sting typo

Changes: https://git.openjdk.java.net/jdk/pull/8125/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8125&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284444
  Stats: 25 lines in 8 files changed: 0 ins; 0 del; 25 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8125.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8125/head:pull/8125

PR: https://git.openjdk.java.net/jdk/pull/8125

From kcr at openjdk.java.net  Wed Apr  6 12:26:40 2022
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Wed, 6 Apr 2022 12:26:40 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo
In-Reply-To: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
Message-ID: <ATUf-x5e0Zgta3UWTO3VSkrxzr172v0Z-tPAfcP2KNY=.5cb73b01-bbcd-4ab0-a28b-53aad2fb12c1@github.com>

On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

> This patch adds missing `r` in `string`s

This PR cuts across many areas, so will need multiple reviewers. Regarding the LCMS file, we typically don't make these kind of changes in third-party code, since it will cause our code to diverge from the upstream code, which can lead to merge conflicts down the road. @prrace will need to approve this or else you will need to revert that file.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8125

From aivanov at openjdk.java.net  Wed Apr  6 13:42:41 2022
From: aivanov at openjdk.java.net (Alexey Ivanov)
Date: Wed, 6 Apr 2022 13:42:41 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo
In-Reply-To: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
Message-ID: <Ho9UNSLp0gPu5BLKn83SNpGxcoN_MzElX1QabMbNr2o=.e30cd1d0-3cef-438e-87b0-c112956715f6@github.com>

On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

> This patch adds missing `r` in `string`s

src/java.desktop/share/native/liblcms/cmstypes.c line 3668:

> 3666: // Auxiliary, read an string specified as count + string
> 3667: static
> 3668: cmsBool  ReadCountAndString(struct _cms_typehandler_struct* self, cmsIOHANDLER* io, cmsMLU* mlu, cmsUInt32Number* SizeOfTag, const char* Section)

As @kevinrushforth mentioned, we usually don't modify the source from external libraries. You should report and fix the problem upstream.

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties line 63:

> 61: message.creating-association-with-null-extension=Creating association with null extension.
> 62: message.wrong-tool-version=Detected [{0}] version {1} but version {2} is required.
> 63: message.version-string-too-many-components=Version string may have up to 3 components - major.minor.build .

I wonder whether the space before the period is required at the end of the sentence. Perhaps, it's to separate a property name from the end of the sentence.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8125

From djelinski at openjdk.java.net  Wed Apr  6 14:08:39 2022
From: djelinski at openjdk.java.net (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Wed, 6 Apr 2022 14:08:39 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo
In-Reply-To: <Ho9UNSLp0gPu5BLKn83SNpGxcoN_MzElX1QabMbNr2o=.e30cd1d0-3cef-438e-87b0-c112956715f6@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
 <Ho9UNSLp0gPu5BLKn83SNpGxcoN_MzElX1QabMbNr2o=.e30cd1d0-3cef-438e-87b0-c112956715f6@github.com>
Message-ID: <yFmkSoJ470Lz1n84rWjS-EplRmZeYoZmlLWhJ9dP-E8=.7515de3b-2959-4707-8bfa-6b69976ba51a@github.com>

On Wed, 6 Apr 2022 13:38:03 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> This patch adds missing `r` in `string`s
>
> src/java.desktop/share/native/liblcms/cmstypes.c line 3668:
> 
>> 3666: // Auxiliary, read an string specified as count + string
>> 3667: static
>> 3668: cmsBool  ReadCountAndString(struct _cms_typehandler_struct* self, cmsIOHANDLER* io, cmsMLU* mlu, cmsUInt32Number* SizeOfTag, const char* Section)
> 
> As @kevinrushforth mentioned, we usually don't modify the source from external libraries. You should report and fix the problem upstream.

Filed https://github.com/mm2/Little-CMS/pull/313 for this

-------------

PR: https://git.openjdk.java.net/jdk/pull/8125

From djelinski at openjdk.java.net  Wed Apr  6 14:12:17 2022
From: djelinski at openjdk.java.net (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Wed, 6 Apr 2022 14:12:17 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo [v2]
In-Reply-To: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
Message-ID: <J0QE92iWWFtqKNwRTUDsGrrsHbNFuPlrxx6sPlocVzk=.72a2acc8-02c6-4b0f-b15b-5faf35b904a5@github.com>

> This patch adds missing `r` in `string`s

Daniel Jeli?ski has updated the pull request incrementally with one additional commit since the last revision:

  Revert liblcms changes

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8125/files
  - new: https://git.openjdk.java.net/jdk/pull/8125/files/755c7084..68ce6ebd

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8125&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8125&range=00-01

  Stats: 12 lines in 1 file changed: 0 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8125.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8125/head:pull/8125

PR: https://git.openjdk.java.net/jdk/pull/8125

From djelinski at openjdk.java.net  Wed Apr  6 14:15:36 2022
From: djelinski at openjdk.java.net (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Wed, 6 Apr 2022 14:15:36 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo [v2]
In-Reply-To: <Ho9UNSLp0gPu5BLKn83SNpGxcoN_MzElX1QabMbNr2o=.e30cd1d0-3cef-438e-87b0-c112956715f6@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
 <Ho9UNSLp0gPu5BLKn83SNpGxcoN_MzElX1QabMbNr2o=.e30cd1d0-3cef-438e-87b0-c112956715f6@github.com>
Message-ID: <u0NwJ909A2q1TQ2iLb_AsdhkHxEhjloPlxzgywlSV-Y=.b80b77b7-37a8-491a-83b7-7cc85c683f83@github.com>

On Wed, 6 Apr 2022 13:36:05 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Daniel Jeli?ski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert liblcms changes
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties line 63:
> 
>> 61: message.creating-association-with-null-extension=Creating association with null extension.
>> 62: message.wrong-tool-version=Detected [{0}] version {1} but version {2} is required.
>> 63: message.version-string-too-many-components=Version string may have up to 3 components - major.minor.build .
> 
> I wonder whether the space before the period is required at the end of the sentence. Perhaps, it's to separate a property name from the end of the sentence.

right; without the space the period would appear to be part of the version pattern.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8125

From naoto at openjdk.java.net  Wed Apr  6 15:52:37 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Wed, 6 Apr 2022 15:52:37 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo [v2]
In-Reply-To: <J0QE92iWWFtqKNwRTUDsGrrsHbNFuPlrxx6sPlocVzk=.72a2acc8-02c6-4b0f-b15b-5faf35b904a5@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
 <J0QE92iWWFtqKNwRTUDsGrrsHbNFuPlrxx6sPlocVzk=.72a2acc8-02c6-4b0f-b15b-5faf35b904a5@github.com>
Message-ID: <rWGMDXuXoinhsJTtNT4cXHGxF0fFsxv7KotnVSN0C8g=.3ec7fb35-1b67-4131-8f03-bb89c94a9bfb@github.com>

On Wed, 6 Apr 2022 14:12:17 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch adds missing `r` in `string`s
>
> Daniel Jeli?ski has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert liblcms changes

src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63:

> 61:  * <a href="http://www.ietf.org/rfc/rfc3454.txt">RFC 3454</a>.
> 62:  * StringPrep prepares Unicode strings for use in network protocols.
> 63:  * Profiles of StringPrep are set of rules and data according to which the

These also come from the upstream ICU4J project and should be corrected there.
https://github.com/unicode-org/icu/blob/4833cc89b2fae2e8863b46bf1dc785964847e882/icu4j/main/classes/core/src/com/ibm/icu/text/StringPrep.java#L27

-------------

PR: https://git.openjdk.java.net/jdk/pull/8125

From djelinski at openjdk.java.net  Wed Apr  6 16:47:17 2022
From: djelinski at openjdk.java.net (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Wed, 6 Apr 2022 16:47:17 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo [v3]
In-Reply-To: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
Message-ID: <mfXduGQhYNQiQcPkmH3RPK-LCdooqDqxFhmrpCRkpOk=.85876ee8-4321-4b69-9aa0-43375541466c@github.com>

> This patch adds missing `r` in `string`s

Daniel Jeli?ski has updated the pull request incrementally with two additional commits since the last revision:

 - revert xalan changes
 - revert icu changes

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8125/files
  - new: https://git.openjdk.java.net/jdk/pull/8125/files/68ce6ebd..1ec0314e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8125&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8125&range=01-02

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8125.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8125/head:pull/8125

PR: https://git.openjdk.java.net/jdk/pull/8125

From djelinski at openjdk.java.net  Wed Apr  6 16:51:43 2022
From: djelinski at openjdk.java.net (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Wed, 6 Apr 2022 16:51:43 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo [v2]
In-Reply-To: <rWGMDXuXoinhsJTtNT4cXHGxF0fFsxv7KotnVSN0C8g=.3ec7fb35-1b67-4131-8f03-bb89c94a9bfb@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
 <J0QE92iWWFtqKNwRTUDsGrrsHbNFuPlrxx6sPlocVzk=.72a2acc8-02c6-4b0f-b15b-5faf35b904a5@github.com>
 <rWGMDXuXoinhsJTtNT4cXHGxF0fFsxv7KotnVSN0C8g=.3ec7fb35-1b67-4131-8f03-bb89c94a9bfb@github.com>
Message-ID: <To4hp-0Cdlgrk2nc06w2mJbYJiV1wZZmvEEA-upixTs=.a559e0eb-f487-442c-a82b-80c43f481a2b@github.com>

On Wed, 6 Apr 2022 15:49:06 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Daniel Jeli?ski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert liblcms changes
>
> src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63:
> 
>> 61:  * <a href="http://www.ietf.org/rfc/rfc3454.txt">RFC 3454</a>.
>> 62:  * StringPrep prepares Unicode strings for use in network protocols.
>> 63:  * Profiles of StringPrep are set of rules and data according to which the
> 
> These also come from the upstream ICU4J project and should be corrected there.
> https://github.com/unicode-org/icu/blob/4833cc89b2fae2e8863b46bf1dc785964847e882/icu4j/main/classes/core/src/com/ibm/icu/text/StringPrep.java#L27

Thanks, reverted. Also reverted Xalan changes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8125

From naoto at openjdk.java.net  Wed Apr  6 16:55:35 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Wed, 6 Apr 2022 16:55:35 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo [v2]
In-Reply-To: <To4hp-0Cdlgrk2nc06w2mJbYJiV1wZZmvEEA-upixTs=.a559e0eb-f487-442c-a82b-80c43f481a2b@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
 <J0QE92iWWFtqKNwRTUDsGrrsHbNFuPlrxx6sPlocVzk=.72a2acc8-02c6-4b0f-b15b-5faf35b904a5@github.com>
 <rWGMDXuXoinhsJTtNT4cXHGxF0fFsxv7KotnVSN0C8g=.3ec7fb35-1b67-4131-8f03-bb89c94a9bfb@github.com>
 <To4hp-0Cdlgrk2nc06w2mJbYJiV1wZZmvEEA-upixTs=.a559e0eb-f487-442c-a82b-80c43f481a2b@github.com>
Message-ID: <GNiL7wT_8egSbprPKOkslemEty8HyQP0xthAyCfzRcU=.03f97c53-9fb3-4fa3-9bb2-4ffaec95ad83@github.com>

On Wed, 6 Apr 2022 16:48:38 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63:
>> 
>>> 61:  * <a href="http://www.ietf.org/rfc/rfc3454.txt">RFC 3454</a>.
>>> 62:  * StringPrep prepares Unicode strings for use in network protocols.
>>> 63:  * Profiles of StringPrep are set of rules and data according to which the
>> 
>> These also come from the upstream ICU4J project and should be corrected there.
>> https://github.com/unicode-org/icu/blob/4833cc89b2fae2e8863b46bf1dc785964847e882/icu4j/main/classes/core/src/com/ibm/icu/text/StringPrep.java#L27
>
> Thanks, reverted. Also reverted Xalan changes.

Good. Thanks for reverting it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8125

From naoto at openjdk.java.net  Wed Apr  6 17:52:08 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Wed, 6 Apr 2022 17:52:08 GMT
Subject: <i18n dev> RFR: 8283698: Refactor Locale constructors used in
 src/test
Message-ID: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>

This is a follow-on task after deprecating the Locale constructors (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are simple replacements to Locale constructors with `Locale.of()` or Locale constants, such as `Locale.US`.

-------------

Commit messages:
 - 8283698: Refactor Locale constructors used in src/test

Changes: https://git.openjdk.java.net/jdk/pull/8130/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8130&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8283698
  Stats: 750 lines in 182 files changed: 3 ins; 3 del; 744 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8130.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8130/head:pull/8130

PR: https://git.openjdk.java.net/jdk/pull/8130

From kcr at openjdk.java.net  Wed Apr  6 17:56:40 2022
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Wed, 6 Apr 2022 17:56:40 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo [v3]
In-Reply-To: <mfXduGQhYNQiQcPkmH3RPK-LCdooqDqxFhmrpCRkpOk=.85876ee8-4321-4b69-9aa0-43375541466c@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
 <mfXduGQhYNQiQcPkmH3RPK-LCdooqDqxFhmrpCRkpOk=.85876ee8-4321-4b69-9aa0-43375541466c@github.com>
Message-ID: <XTfw5IxI7gZ_idvpU_JUUjBvNOgzCnCkSZ6vpIvzdu4=.3a718107-69db-4221-9284-e46196268599@github.com>

On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch adds missing `r` in `string`s
>
> Daniel Jeli?ski has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - revert xalan changes
>  - revert icu changes

The `jpackage` part of the fix looks good.  Btw, there are translated files for 3 other languages (German, Japanese, Simplified Chinese), so I double-checked the translation for each, and they already say "string" (I guess whoever translated it just assumed it was meant to be "string" when they took the English phrase).

-------------

Marked as reviewed by kcr (Author).

PR: https://git.openjdk.java.net/jdk/pull/8125

From kcr at openjdk.java.net  Wed Apr  6 17:56:40 2022
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Wed, 6 Apr 2022 17:56:40 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo [v3]
In-Reply-To: <u0NwJ909A2q1TQ2iLb_AsdhkHxEhjloPlxzgywlSV-Y=.b80b77b7-37a8-491a-83b7-7cc85c683f83@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
 <Ho9UNSLp0gPu5BLKn83SNpGxcoN_MzElX1QabMbNr2o=.e30cd1d0-3cef-438e-87b0-c112956715f6@github.com>
 <u0NwJ909A2q1TQ2iLb_AsdhkHxEhjloPlxzgywlSV-Y=.b80b77b7-37a8-491a-83b7-7cc85c683f83@github.com>
Message-ID: <fFvzPNxrHfSm81K92eb6oiGMeOIM3Avzc5tJiQlatd4=.fe9ce9a8-2591-42dd-ba40-657e36635f2d@github.com>

On Wed, 6 Apr 2022 14:12:49 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties line 63:
>> 
>>> 61: message.creating-association-with-null-extension=Creating association with null extension.
>>> 62: message.wrong-tool-version=Detected [{0}] version {1} but version {2} is required.
>>> 63: message.version-string-too-many-components=Version string may have up to 3 components - major.minor.build .
>> 
>> I wonder whether the space before the period is required at the end of the sentence. Perhaps, it's to separate a property name from the end of the sentence.
>
> right; without the space the period would appear to be part of the version pattern.

Yes, I believe this is why it was done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8125

From aivanov at openjdk.java.net  Wed Apr  6 18:10:40 2022
From: aivanov at openjdk.java.net (Alexey Ivanov)
Date: Wed, 6 Apr 2022 18:10:40 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo [v3]
In-Reply-To: <mfXduGQhYNQiQcPkmH3RPK-LCdooqDqxFhmrpCRkpOk=.85876ee8-4321-4b69-9aa0-43375541466c@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
 <mfXduGQhYNQiQcPkmH3RPK-LCdooqDqxFhmrpCRkpOk=.85876ee8-4321-4b69-9aa0-43375541466c@github.com>
Message-ID: <LRbz8zj9WLGW6iNa-3G2yJpwPlioeVypcdNtbOfD8ow=.48a92624-29ec-4f29-94c9-2688a3c53ce1@github.com>

On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch adds missing `r` in `string`s
>
> Daniel Jeli?ski has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - revert xalan changes
>  - revert icu changes

The changes look fine to me now.  
Yet there are no changes in the client area any more. So you'll have to get additional approvals.

-------------

Marked as reviewed by aivanov (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8125

From iris at openjdk.java.net  Wed Apr  6 19:36:40 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Wed, 6 Apr 2022 19:36:40 GMT
Subject: <i18n dev> RFR: 8283698: Refactor Locale constructors used in
 src/test
In-Reply-To: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
References: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
Message-ID: <r5RSuZEt-YT0EOWQmAH1kV7c1apKvBn-ss866xTyF5E=.903a7419-865c-472e-9e20-632d882293e7@github.com>

On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is a follow-on task after deprecating the Locale constructors (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are simple replacements to Locale constructors with `Locale.of()` or Locale constants, such as `Locale.US`.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8130

From mgronlun at openjdk.java.net  Wed Apr  6 20:49:48 2022
From: mgronlun at openjdk.java.net (Markus =?UTF-8?B?R3LDtm5sdW5k?=)
Date: Wed, 6 Apr 2022 20:49:48 GMT
Subject: <i18n dev> RFR: 8284444: Sting typo [v3]
In-Reply-To: <mfXduGQhYNQiQcPkmH3RPK-LCdooqDqxFhmrpCRkpOk=.85876ee8-4321-4b69-9aa0-43375541466c@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
 <mfXduGQhYNQiQcPkmH3RPK-LCdooqDqxFhmrpCRkpOk=.85876ee8-4321-4b69-9aa0-43375541466c@github.com>
Message-ID: <ladM4OI12K08dMW-meDSPHtyYvpTYyqPG5utW4SW2Cs=.0e568ec8-2b7a-4d26-af34-7baa0808c1f4@github.com>

On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch adds missing `r` in `string`s
>
> Daniel Jeli?ski has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - revert xalan changes
>  - revert icu changes

JFR changes look fine, thank you.

-------------

Marked as reviewed by mgronlun (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8125

From joehw at openjdk.java.net  Thu Apr  7 00:13:45 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 7 Apr 2022 00:13:45 GMT
Subject: <i18n dev> RFR: 8283698: Refactor Locale constructors used in
 src/test
In-Reply-To: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
References: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
Message-ID: <O1Wg_OPzPP2kpIzubVLsSjItgPu8tCWg-MuTq4xE_lI=.3b70f0c7-9ba4-4994-9c49-7b45dd8552bf@github.com>

On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is a follow-on task after deprecating the Locale constructors (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are simple replacements to Locale constructors with `Locale.of()` or Locale constants, such as `Locale.US`.

test/jdk/java/text/Format/DateFormat/DateFormatRoundTripTest.java line 81:

> 79: 
> 80:     /**
> 81:      * Parse a name like "fr_FR" into Locale.of("fr", "FR", "");

Locale.France?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8130

From joehw at openjdk.java.net  Thu Apr  7 00:20:31 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 7 Apr 2022 00:20:31 GMT
Subject: <i18n dev> RFR: 8283698: Refactor Locale constructors used in
 src/test
In-Reply-To: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
References: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
Message-ID: <oWowG5ZF6uQhqEOWoDSp17TbGHZqZjmcaxL_5_yGxuU=.b7e9daaf-b3eb-4620-a0a6-01635f37e8ec@github.com>

On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is a follow-on task after deprecating the Locale constructors (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are simple replacements to Locale constructors with `Locale.of()` or Locale constants, such as `Locale.US`.

test/jdk/java/text/Format/DateFormat/NonGregorianFormatTest.java line 131:

> 129: 
> 130:         // Tests with the Japanese imperial calendar
> 131:         Locale calendarLocale = Locale.of("ja", "JP", "JP");

Locale.JAPAN?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8130

From joehw at openjdk.java.net  Thu Apr  7 00:31:55 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 7 Apr 2022 00:31:55 GMT
Subject: <i18n dev> RFR: 8283698: Refactor Locale constructors used in
 src/test
In-Reply-To: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
References: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
Message-ID: <UYhQLIeSUDpGNeR1pFuD9ll9SIPZFAnzvRiX-rft8f8=.bdb3a956-ca7a-4523-87d6-71e9a12e5a76@github.com>

On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is a follow-on task after deprecating the Locale constructors (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are simple replacements to Locale constructors with `Locale.of()` or Locale constants, such as `Locale.US`.

test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 63:

> 61:             Locale.of("it", "IT", "EURO"),
> 62:             Locale.forLanguageTag("de-AT"),
> 63:             Locale.forLanguageTag("fr-CH"),

Use the new factory? Ok not to change as these are tests and there are too many of them. It's not deprecated anyways.

test/jdk/java/text/Format/common/Bug6215962.java line 58:

> 56:         check(mf1, mf2, false);
> 57: 
> 58:         mf1 = new MessageFormat("{0}", Locale.of("ja", "JP"));

Locale.JAPAN?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8130

From naoto at openjdk.java.net  Thu Apr  7 01:19:35 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Thu, 7 Apr 2022 01:19:35 GMT
Subject: <i18n dev> RFR: 8283698: Refactor Locale constructors used in
 src/test
In-Reply-To: <O1Wg_OPzPP2kpIzubVLsSjItgPu8tCWg-MuTq4xE_lI=.3b70f0c7-9ba4-4994-9c49-7b45dd8552bf@github.com>
References: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
 <O1Wg_OPzPP2kpIzubVLsSjItgPu8tCWg-MuTq4xE_lI=.3b70f0c7-9ba4-4994-9c49-7b45dd8552bf@github.com>
Message-ID: <aku2mIBBVnzFO3xr6BEuEc0Q1_Ad1X2sM3-vTOb0xbI=.4ea9ba22-e75d-4bcb-8942-96767c384f9f@github.com>

On Thu, 7 Apr 2022 00:09:58 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> This is a follow-on task after deprecating the Locale constructors (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are simple replacements to Locale constructors with `Locale.of()` or Locale constants, such as `Locale.US`.
>
> test/jdk/java/text/Format/DateFormat/DateFormatRoundTripTest.java line 81:
> 
>> 79: 
>> 80:     /**
>> 81:      * Parse a name like "fr_FR" into Locale.of("fr", "FR", "");
> 
> Locale.France?

The test code parses the input string (eg. "fr_FR") into 3 elements, `name`, `country`, and `variant`, then create a `Locale` using those 3 elements. Changing it to `Locale.FRANCE` does not seem right here.

> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 63:
> 
>> 61:             Locale.of("it", "IT", "EURO"),
>> 62:             Locale.forLanguageTag("de-AT"),
>> 63:             Locale.forLanguageTag("fr-CH"),
> 
> Use the new factory? Ok not to change as these are tests and there are too many of them. It's not deprecated anyways.

`Locale.forLanguageTag()` is a preferred way to create a `Locale`, as it validates the input language tag, while `Locale.of()` doesn't as well as Locale constructors.

> test/jdk/java/text/Format/common/Bug6215962.java line 58:
> 
>> 56:         check(mf1, mf2, false);
>> 57: 
>> 58:         mf1 = new MessageFormat("{0}", Locale.of("ja", "JP"));
> 
> Locale.JAPAN?

The test intends to compare the generated `MessageFormat` objects (`mf2` & `mf1`) from using a constant `Locale.JAPAN` and the factory method. So I believe leaving it as `Locale.of()` makes sense.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8130

From joehw at openjdk.java.net  Thu Apr  7 04:51:38 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 7 Apr 2022 04:51:38 GMT
Subject: <i18n dev> RFR: 8283698: Refactor Locale constructors used in
 src/test
In-Reply-To: <aku2mIBBVnzFO3xr6BEuEc0Q1_Ad1X2sM3-vTOb0xbI=.4ea9ba22-e75d-4bcb-8942-96767c384f9f@github.com>
References: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
 <O1Wg_OPzPP2kpIzubVLsSjItgPu8tCWg-MuTq4xE_lI=.3b70f0c7-9ba4-4994-9c49-7b45dd8552bf@github.com>
 <aku2mIBBVnzFO3xr6BEuEc0Q1_Ad1X2sM3-vTOb0xbI=.4ea9ba22-e75d-4bcb-8942-96767c384f9f@github.com>
Message-ID: <0Zxp9nACKCy12wn8Viwd5lYHz3KXojuy02cZLiz8Wiw=.f1a9f3b3-8cfb-4845-87e7-bef9b69ada8a@github.com>

On Thu, 7 Apr 2022 01:16:27 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> test/jdk/java/text/Format/DateFormat/DateFormatRoundTripTest.java line 81:
>> 
>>> 79: 
>>> 80:     /**
>>> 81:      * Parse a name like "fr_FR" into Locale.of("fr", "FR", "");
>> 
>> Locale.France?
>
> The test code parses the input string (eg. "fr_FR") into 3 elements, `name`, `country`, and `variant`, then create a `Locale` using those 3 elements. Changing it to `Locale.FRANCE` does not seem right here.

I see.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8130

From joehw at openjdk.java.net  Thu Apr  7 04:59:39 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 7 Apr 2022 04:59:39 GMT
Subject: <i18n dev> RFR: 8283698: Refactor Locale constructors used in
 src/test
In-Reply-To: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
References: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
Message-ID: <c7WnJL_FTC92jBi5LhA8s1EA-5LMgBW7ucldQb0GQVk=.aa5aa4d7-07a4-4f44-ab61-e89f54adb1ec@github.com>

On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is a follow-on task after deprecating the Locale constructors (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are simple replacements to Locale constructors with `Locale.of()` or Locale constants, such as `Locale.US`.

Marked as reviewed by joehw (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8130

From joehw at openjdk.java.net  Thu Apr  7 04:59:40 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 7 Apr 2022 04:59:40 GMT
Subject: <i18n dev> RFR: 8283698: Refactor Locale constructors used in
 src/test
In-Reply-To: <aku2mIBBVnzFO3xr6BEuEc0Q1_Ad1X2sM3-vTOb0xbI=.4ea9ba22-e75d-4bcb-8942-96767c384f9f@github.com>
References: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
 <O1Wg_OPzPP2kpIzubVLsSjItgPu8tCWg-MuTq4xE_lI=.3b70f0c7-9ba4-4994-9c49-7b45dd8552bf@github.com>
 <aku2mIBBVnzFO3xr6BEuEc0Q1_Ad1X2sM3-vTOb0xbI=.4ea9ba22-e75d-4bcb-8942-96767c384f9f@github.com>
Message-ID: <VhDD3losQJHv-SpTfyDeEG5Jb3lX9kYSQ9CoOMD2YIU=.47de2cb7-1289-4f2d-8648-c75320e44ac9@github.com>

On Thu, 7 Apr 2022 01:16:32 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 63:
>> 
>>> 61:             Locale.of("it", "IT", "EURO"),
>>> 62:             Locale.forLanguageTag("de-AT"),
>>> 63:             Locale.forLanguageTag("fr-CH"),
>> 
>> Use the new factory? Ok not to change as these are tests and there are too many of them. It's not deprecated anyways.
>
> `Locale.forLanguageTag()` is a preferred way to create a `Locale`, as it validates the input language tag, while `Locale.of()` doesn't as well as Locale constructors.

Ok, I didn't realize the existing method is preferred over the new method in creating a Locale. The javadoc does state that it does not make any syntactic checks. That's good to know.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8130

From djelinski at openjdk.java.net  Thu Apr  7 14:58:43 2022
From: djelinski at openjdk.java.net (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Thu, 7 Apr 2022 14:58:43 GMT
Subject: <i18n dev> Integrated: 8284444: Sting typo
In-Reply-To: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
References: <6dV8QfrkKltmL7CnwYYMDMhEMBHnEcYmrtdrZZITwl4=.6963f840-ea5f-4034-824a-99b776b53af5@github.com>
Message-ID: <DLTDZ2b9bR7P6zsb0sW9B66BYoCBNu2PLj9iQ7k9Igc=.ec1a801a-c6f8-44f4-9706-44954c74e0fa@github.com>

On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

> This patch adds missing `r` in `string`s

This pull request has now been integrated.

Changeset: 5bafcfdc
Author:    Daniel Jeli?ski <djelinski at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/5bafcfdc171b5a514ecf620703e77fa2f4a49c58
Stats:     10 lines in 5 files changed: 0 ins; 0 del; 10 mod

8284444: Sting typo

Reviewed-by: kcr, aivanov, mgronlun

-------------

PR: https://git.openjdk.java.net/jdk/pull/8125

From naoto at openjdk.java.net  Thu Apr  7 21:27:37 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Thu, 7 Apr 2022 21:27:37 GMT
Subject: <i18n dev> RFR: 8265315: Support for CLDR version 41
Message-ID: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>

This is to upgrade the CLDR data from version 39 to version 41 which was released yesterday. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments. Here is the link to CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

-------------

Commit messages:
 - Merge branch 'master' into cldr+
 - CLDR v41 final
 - CLDR v41 beta2
 - Merge branch 'master' into cldr+
 - CLDR v41 alpha4
 - Merge branch 'master' into cldr+
 - Update copyright year to 2022
 - CLDR release v40
 - Merge branch 'master' into cldr
 - CLDR tip
 - ... and 11 more: https://git.openjdk.java.net/jdk/compare/526e7349...ee6985a4

Changes: https://git.openjdk.java.net/jdk/pull/8150/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8150&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8265315
  Stats: 132401 lines in 859 files changed: 96406 ins; 4216 del; 31779 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8150.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8150/head:pull/8150

PR: https://git.openjdk.java.net/jdk/pull/8150

From joehw at openjdk.java.net  Thu Apr  7 22:35:43 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 7 Apr 2022 22:35:43 GMT
Subject: <i18n dev> RFR: 8265315: Support for CLDR version 41
In-Reply-To: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
References: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
Message-ID: <b2f9yAUB6GOh8wK40TpzOVSyYsprlLilegs7yWFl3fA=.b6730316-25a4-46fe-8103-e34f94b4e43b@github.com>

On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is to upgrade the CLDR data from version 39 to version 41 which was released yesterday. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments. Here is the link to CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

Marked as reviewed by joehw (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8150

From iris at openjdk.java.net  Thu Apr  7 23:06:54 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Thu, 7 Apr 2022 23:06:54 GMT
Subject: <i18n dev> RFR: 8265315: Support for CLDR version 41
In-Reply-To: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
References: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
Message-ID: <4oGrtdxkJtlc3S_r5i21b3Hiw68LU9_fAdYTCyhf7o4=.0c48424f-143f-45a1-bff6-8a6207c50940@github.com>

On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is to upgrade the CLDR data from version 39 to version 41 which was released yesterday. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments. Here is the link to CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8150

From ihse at openjdk.java.net  Fri Apr  8 08:52:59 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Fri, 8 Apr 2022 08:52:59 GMT
Subject: <i18n dev> RFR: 8265315: Support for CLDR version 41
In-Reply-To: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
References: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
Message-ID: <tc9JTeyFT98SDZ2QEHFW-CilU3W6p38sqP1WD233t9E=.f64160c5-83f1-40e9-9caa-f70b063884d4@github.com>

On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is to upgrade the CLDR data from version 39 to version 41 which was released yesterday. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments. Here is the link to CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

Have you checked if this update has any impact on the runtime of the CLDRConverter tool?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8150

From naoto at openjdk.java.net  Fri Apr  8 15:26:35 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Fri, 8 Apr 2022 15:26:35 GMT
Subject: <i18n dev> Integrated: 8283698: Refactor Locale constructors used
 in src/test
In-Reply-To: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
References: <wRBDQ738zQ0djbWm5ki1yOnUftNn4oKaOHxcptM-3FE=.7b0d10f0-b110-4f47-9e34-34937fb48503@github.com>
Message-ID: <r6its8TfgpC32jQ7YIdERQEA2ElBz-DOEd9zkKv5vGY=.38b6000b-7b2b-4180-8981-19fc570c322a@github.com>

On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is a follow-on task after deprecating the Locale constructors (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are simple replacements to Locale constructors with `Locale.of()` or Locale constants, such as `Locale.US`.

This pull request has now been integrated.

Changeset: d6b4693c
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/d6b4693c0527385f8999089b3f8b2120548efecb
Stats:     750 lines in 182 files changed: 3 ins; 3 del; 744 mod

8283698: Refactor Locale constructors used in src/test

Reviewed-by: iris, joehw

-------------

PR: https://git.openjdk.java.net/jdk/pull/8130

From naoto at openjdk.java.net  Fri Apr  8 18:21:45 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Fri, 8 Apr 2022 18:21:45 GMT
Subject: <i18n dev> RFR: 8265315: Support for CLDR version 41
In-Reply-To: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
References: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
Message-ID: <tvUCnJtW5eM49aasxZUe-TGLuEzKykVvEdE8tQ0NrBM=.3267ec10-50cd-4004-87f2-51ab2b4b987f@github.com>

On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is to upgrade the CLDR data from version 39 to version 41 which was released yesterday. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments. Here is the link to CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

I measured the execution time of `CLDRConverter`. Each run measures an average execution time for 5 invocations of `CLDRConverter.main()`, and I ran it 5 times for `java.base` and `jdk.localedata` modules. All average values are in seconds.

- Before the fix
  - java.base: 11.536 - 12.836
  - jdk.localedata: 19.764 - 22.584
- After the fix
  - java.base: 11.666 - 12.833
  - jdk.localedata: 19.183 - 20.838
 
Looking at the results, I don't see any notable tool execution time difference with this change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8150

From ihse at openjdk.java.net  Fri Apr  8 19:10:56 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Fri, 8 Apr 2022 19:10:56 GMT
Subject: <i18n dev> RFR: 8265315: Support for CLDR version 41
In-Reply-To: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
References: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
Message-ID: <xAUT9Nzg0QsOAJTRMBVDsGyFLHkqSeyb9MlxsdsqOMQ=.d886093d-edf4-4c59-a8a2-f4873630c47a@github.com>

On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is to upgrade the CLDR data from version 39 to version 41 which was released yesterday. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments. Here is the link to CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

Marked as reviewed by ihse (Reviewer).

Great, thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/8150

From naoto at openjdk.java.net  Fri Apr  8 20:17:52 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Fri, 8 Apr 2022 20:17:52 GMT
Subject: <i18n dev> RFR: 8265315: Support for CLDR version 41 [v2]
In-Reply-To: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
References: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
Message-ID: <B9Xg8dkiI6_9xZ4RFV-XPOdRh5vp0RCTKOX-DyioI-g=.33a091a7-5065-4265-ab9a-db08187fa236@github.com>

> This is to upgrade the CLDR data from version 39 to version 41 which was released yesterday. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments. Here is the link to CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits:

 - Merge branch 'master' into cldr+
 - Merge branch 'master' into cldr+
 - CLDR v41 final
 - CLDR v41 beta2
 - Merge branch 'master' into cldr+
 - CLDR v41 alpha4
 - Merge branch 'master' into cldr+
 - Update copyright year to 2022
 - CLDR release v40
 - Merge branch 'master' into cldr
 - ... and 12 more: https://git.openjdk.java.net/jdk/compare/a8c87526...9ef22a6d

-------------

Changes: https://git.openjdk.java.net/jdk/pull/8150/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8150&range=01
  Stats: 132400 lines in 859 files changed: 96406 ins; 4216 del; 31778 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8150.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8150/head:pull/8150

PR: https://git.openjdk.java.net/jdk/pull/8150

From iris at openjdk.java.net  Fri Apr  8 20:41:51 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Fri, 8 Apr 2022 20:41:51 GMT
Subject: <i18n dev> RFR: 8265315: Support for CLDR version 41 [v2]
In-Reply-To: <B9Xg8dkiI6_9xZ4RFV-XPOdRh5vp0RCTKOX-DyioI-g=.33a091a7-5065-4265-ab9a-db08187fa236@github.com>
References: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
 <B9Xg8dkiI6_9xZ4RFV-XPOdRh5vp0RCTKOX-DyioI-g=.33a091a7-5065-4265-ab9a-db08187fa236@github.com>
Message-ID: <AeVFAkQYXGDQRQmC8h1Gu02XKGTkCgxM9zlD0T1hvyM=.b21ffddd-21cd-4f0a-86d6-367bfc2ff3d6@github.com>

On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> This is to upgrade the CLDR data from version 39 to version 41 which was released yesterday. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments. Here is the link to CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41
>
> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits:
> 
>  - Merge branch 'master' into cldr+
>  - Merge branch 'master' into cldr+
>  - CLDR v41 final
>  - CLDR v41 beta2
>  - Merge branch 'master' into cldr+
>  - CLDR v41 alpha4
>  - Merge branch 'master' into cldr+
>  - Update copyright year to 2022
>  - CLDR release v40
>  - Merge branch 'master' into cldr
>  - ... and 12 more: https://git.openjdk.java.net/jdk/compare/a8c87526...9ef22a6d

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8150

From joehw at openjdk.java.net  Fri Apr  8 23:26:54 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Fri, 8 Apr 2022 23:26:54 GMT
Subject: <i18n dev> RFR: 8265315: Support for CLDR version 41 [v2]
In-Reply-To: <B9Xg8dkiI6_9xZ4RFV-XPOdRh5vp0RCTKOX-DyioI-g=.33a091a7-5065-4265-ab9a-db08187fa236@github.com>
References: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
 <B9Xg8dkiI6_9xZ4RFV-XPOdRh5vp0RCTKOX-DyioI-g=.33a091a7-5065-4265-ab9a-db08187fa236@github.com>
Message-ID: <L6S6lbiTDZTIY_dgLcSpjUBA6oODqnG5uHHO_U8FFGw=.233ded0c-dd00-4943-85ed-8ecd68ef837b@github.com>

On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> This is to upgrade the CLDR data from version 39 to version 41 which was released yesterday. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments. Here is the link to CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41
>
> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits:
> 
>  - Merge branch 'master' into cldr+
>  - Merge branch 'master' into cldr+
>  - CLDR v41 final
>  - CLDR v41 beta2
>  - Merge branch 'master' into cldr+
>  - CLDR v41 alpha4
>  - Merge branch 'master' into cldr+
>  - Update copyright year to 2022
>  - CLDR release v40
>  - Merge branch 'master' into cldr
>  - ... and 12 more: https://git.openjdk.java.net/jdk/compare/a8c87526...9ef22a6d

Marked as reviewed by joehw (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8150

From naoto at openjdk.java.net  Mon Apr 11 16:03:05 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Mon, 11 Apr 2022 16:03:05 GMT
Subject: <i18n dev> Integrated: 8265315: Support for CLDR version 41
In-Reply-To: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
References: <DdB7YQOFJp1B0h88tRTN5OWj-Qyz1ZCwFISfTzdaovE=.f3698328-3053-4d6f-a5ed-30cf2e06c531@github.com>
Message-ID: <Ybqst1jl7a8jNbbEev6lBmYPf3eYrdluoDcyv5ix35c=.12742c7f-398e-4d1c-bd48-a867835fb355@github.com>

On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is to upgrade the CLDR data from version 39 to version 41 which was released yesterday. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments. Here is the link to CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

This pull request has now been integrated.

Changeset: 523899e3
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/523899e36c543343283ab0b1f5cfcba805e7b918
Stats:     132400 lines in 859 files changed: 96406 ins; 4216 del; 31778 mod

8265315: Support for CLDR version 41

Reviewed-by: joehw, iris, ihse

-------------

PR: https://git.openjdk.java.net/jdk/pull/8150

From naoto at openjdk.java.net  Tue Apr 12 20:33:53 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Tue, 12 Apr 2022 20:33:53 GMT
Subject: <i18n dev> RFR: 8279185: Support for IsoFields in
 JapaneseDate/MinguoDate/ThaiBuddhistDate [v5]
In-Reply-To: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
References: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
Message-ID: <IWbsLRDMibMqH2F3EvwoPfJfD5xyRZhDc-Cj0fIgITE=.8fe5b6cb-6e9d-4296-9f73-18f7641c794f@github.com>

> Supporting `IsoFields` temporal fields in chronologies that are similar to ISO chronology. Corresponding CSR has also been drafted.

Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:

 - abstract class -> top level interface
 - interface -> abstract class
 - Merge branch 'master' into JDK-8279185
 - Removed the method
 - Merge branch 'master' into JDK-8279185
 - Changed to use a type to determine ISO based or not
 - Renamed the new method
 - Merge branch 'master' into JDK-8279185
 - Addresses review comments
 - copyright year fix
 - ... and 1 more: https://git.openjdk.java.net/jdk/compare/488250f0...7f596789

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7683/files
  - new: https://git.openjdk.java.net/jdk/pull/7683/files/530ed40e..7f596789

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=03-04

  Stats: 302965 lines in 3965 files changed: 219208 ins; 39068 del; 44689 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7683.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7683/head:pull/7683

PR: https://git.openjdk.java.net/jdk/pull/7683

From joehw at openjdk.java.net  Tue Apr 12 21:29:59 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Tue, 12 Apr 2022 21:29:59 GMT
Subject: <i18n dev> RFR: 8279185: Support for IsoFields in
 JapaneseDate/MinguoDate/ThaiBuddhistDate [v5]
In-Reply-To: <IWbsLRDMibMqH2F3EvwoPfJfD5xyRZhDc-Cj0fIgITE=.8fe5b6cb-6e9d-4296-9f73-18f7641c794f@github.com>
References: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
 <IWbsLRDMibMqH2F3EvwoPfJfD5xyRZhDc-Cj0fIgITE=.8fe5b6cb-6e9d-4296-9f73-18f7641c794f@github.com>
Message-ID: <tvNaY_5RP3DQyGR2X0iUUdxgweNhXdrFQzXen1m80bs=.b0fade97-7974-4a52-b589-cdbf4330597c@github.com>

On Tue, 12 Apr 2022 20:33:53 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Supporting `IsoFields` temporal fields in chronologies that are similar to ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - abstract class -> top level interface
>  - interface -> abstract class
>  - Merge branch 'master' into JDK-8279185
>  - Removed the method
>  - Merge branch 'master' into JDK-8279185
>  - Changed to use a type to determine ISO based or not
>  - Renamed the new method
>  - Merge branch 'master' into JDK-8279185
>  - Addresses review comments
>  - copyright year fix
>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/c751c9bd...7f596789

Marked as reviewed by joehw (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7683

From joehw at openjdk.java.net  Tue Apr 12 21:37:10 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Tue, 12 Apr 2022 21:37:10 GMT
Subject: <i18n dev> RFR: 8279185: Support for IsoFields in
 JapaneseDate/MinguoDate/ThaiBuddhistDate [v5]
In-Reply-To: <IWbsLRDMibMqH2F3EvwoPfJfD5xyRZhDc-Cj0fIgITE=.8fe5b6cb-6e9d-4296-9f73-18f7641c794f@github.com>
References: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
 <IWbsLRDMibMqH2F3EvwoPfJfD5xyRZhDc-Cj0fIgITE=.8fe5b6cb-6e9d-4296-9f73-18f7641c794f@github.com>
Message-ID: <sBbXNmnq3XXDeW0QiJLpGyW6XOwc6VWEoAr2TthhHv0=.b6cb5318-7241-4734-9cb6-f8229f390dad@github.com>

On Tue, 12 Apr 2022 20:33:53 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Supporting `IsoFields` temporal fields in chronologies that are similar to ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - abstract class -> top level interface
>  - interface -> abstract class
>  - Merge branch 'master' into JDK-8279185
>  - Removed the method
>  - Merge branch 'master' into JDK-8279185
>  - Changed to use a type to determine ISO based or not
>  - Renamed the new method
>  - Merge branch 'master' into JDK-8279185
>  - Addresses review comments
>  - copyright year fix
>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/30616d77...7f596789

Looks good to me. For the name, another option might be IsoCompatible instead of IsoBased as historically those other calendars were established before the ISO standard, although technically, in the Java language, it could be said the xChronology is ISO based.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7683

From smarks at openjdk.java.net  Wed Apr 13 19:31:18 2022
From: smarks at openjdk.java.net (Stuart Marks)
Date: Wed, 13 Apr 2022 19:31:18 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v16]
In-Reply-To: <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
Message-ID: <tyREZE5_pIE3fSFQ00_rWQqm3PuMcbtv5HpmUnHebkk=.9779c0a0-a489-4dd0-a5db-dbf3cfd5ef74@github.com>

On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert changes in:
>   src/java.desktop
>   src/java.management
>   src/jdk.internal.vm.ci
>   src/jdk.jfr
>   src/jdk.management.jfr
>   src/jdk.management
>   src/utils/IdealGraphVisualizer

Reviewers for i18n, net, nio, and security, please review call site changes in your areas. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From naoto at openjdk.java.net  Wed Apr 13 20:10:11 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Wed, 13 Apr 2022 20:10:11 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v16]
In-Reply-To: <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
Message-ID: <qpvhWVidYy6h6EC2eMfJeqkwifiWrFOVFPZljfEjimg=.f39246a8-4e98-4969-a0ef-7a8943bebec2@github.com>

On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert changes in:
>   src/java.desktop
>   src/java.management
>   src/jdk.internal.vm.ci
>   src/jdk.jfr
>   src/jdk.management.jfr
>   src/jdk.management
>   src/utils/IdealGraphVisualizer

Looks good for changes in i18n related call sites, assuming that the copyright years will be updated.

Should we need some additions/modifications to the hashmap optimal capacity utility `test/lib/jdk/test/lib/util/OptimalCapacity.java`?

-------------

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7928

From aturbanov at openjdk.java.net  Wed Apr 13 20:45:35 2022
From: aturbanov at openjdk.java.net (Andrey Turbanov)
Date: Wed, 13 Apr 2022 20:45:35 GMT
Subject: <i18n dev> RFR: 8284853: Fix varios 'expected' typo
Message-ID: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>

Found various typos of expected: `exepected`, `exept`, `epectedly`, `expeced`, `Unexpeted`, etc.

-------------

Commit messages:
 - [PATCH] Fix 'expected' typo
 - [PATCH] Fix 'expected' typo
 - [PATCH] Fix 'expected' typo

Changes: https://git.openjdk.java.net/jdk/pull/8231/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8231&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284853
  Stats: 65 lines in 28 files changed: 0 ins; 0 del; 65 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8231.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8231/head:pull/8231

PR: https://git.openjdk.java.net/jdk/pull/8231

From joehw at openjdk.java.net  Wed Apr 13 21:05:23 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Wed, 13 Apr 2022 21:05:23 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v16]
In-Reply-To: <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
Message-ID: <21Zq0-bQTy5fAlxd-WnsAp-JQ6DwJ5HO4ceFTN3zCRQ=.98cd3042-cbe2-4c6a-9647-7762fcb20d89@github.com>

On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert changes in:
>   src/java.desktop
>   src/java.management
>   src/jdk.internal.vm.ci
>   src/jdk.jfr
>   src/jdk.management.jfr
>   src/jdk.management
>   src/utils/IdealGraphVisualizer

Looks good for the changes in java.xml, like Naoto, assuming copyright years and the LastModified tag are updated. I generally prefer for the source level to stay at 8 as the upstream source is maintained at an older JDK level, but these changes seem to be small enough to tolerate.

-------------

Marked as reviewed by joehw (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7928

From lancea at openjdk.java.net  Wed Apr 13 21:26:15 2022
From: lancea at openjdk.java.net (Lance Andersen)
Date: Wed, 13 Apr 2022 21:26:15 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v16]
In-Reply-To: <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
Message-ID: <zaLc73nUF0KwecqGKR700uZrqqbeNHkL5CaILJO7g7Q=.48bf66a8-5baf-49c2-8ec4-8caaf8145ac3@github.com>

On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert changes in:
>   src/java.desktop
>   src/java.management
>   src/jdk.internal.vm.ci
>   src/jdk.jfr
>   src/jdk.management.jfr
>   src/jdk.management
>   src/utils/IdealGraphVisualizer

The ZipFS and Jar changes seem OK

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7928

From naoto at openjdk.java.net  Wed Apr 13 22:08:00 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Wed, 13 Apr 2022 22:08:00 GMT
Subject: <i18n dev> RFR: 8279185: Support for IsoFields in
 JapaneseDate/MinguoDate/ThaiBuddhistDate [v6]
In-Reply-To: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
References: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
Message-ID: <Maz8TWgJBAWu0YaefxGxryaSziC-9WRh7xC5HRn7ODk=.c4c04fc0-ccd0-493d-8cc4-a49f0bf0a51a@github.com>

> Supporting `IsoFields` temporal fields in chronologies that are similar to ISO chronology. Corresponding CSR has also been drafted.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Modified class desc of `IsoFields`

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7683/files
  - new: https://git.openjdk.java.net/jdk/pull/7683/files/7f596789..474dc85a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=04-05

  Stats: 6 lines in 2 files changed: 5 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7683.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7683/head:pull/7683

PR: https://git.openjdk.java.net/jdk/pull/7683

From duke at openjdk.java.net  Wed Apr 13 22:10:09 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Wed, 13 Apr 2022 22:10:09 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v17]
In-Reply-To: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
Message-ID: <3_faiutX4epQEXucP2z6IcaH5QLh4py7mqmuvYeUZTs=.9604e1eb-dd98-44fe-955b-d08966a78ba1@github.com>

> 8186958: Need method to create pre-sized HashMap

XenoAmess has updated the pull request incrementally with one additional commit since the last revision:

  Copyright latest year to 2022

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7928/files
  - new: https://git.openjdk.java.net/jdk/pull/7928/files/2f5617bb..4476c761

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=16
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=15-16

  Stats: 24 lines in 24 files changed: 0 ins; 0 del; 24 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7928.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7928/head:pull/7928

PR: https://git.openjdk.java.net/jdk/pull/7928

From bpb at openjdk.java.net  Wed Apr 13 22:15:15 2022
From: bpb at openjdk.java.net (Brian Burkhalter)
Date: Wed, 13 Apr 2022 22:15:15 GMT
Subject: <i18n dev> RFR: 8284853: Fix varios 'expected' typo
In-Reply-To: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
References: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
Message-ID: <bqVpACr36Y57HyfkdPhkky31heyeGtVmHiuq7sImIdU=.bafb68b4-23f1-483e-a1ae-3852d9852c7f@github.com>

On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> Found various typos of expected: `exepected`, `exept`, `epectedly`, `expeced`, `Unexpeted`, etc.

Expect the Unexpeted.

-------------

Marked as reviewed by bpb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8231

From duke at openjdk.java.net  Wed Apr 13 22:20:14 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Wed, 13 Apr 2022 22:20:14 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
Message-ID: <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>

> 8186958: Need method to create pre-sized HashMap

XenoAmess has updated the pull request incrementally with one additional commit since the last revision:

  update LastModified

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7928/files
  - new: https://git.openjdk.java.net/jdk/pull/7928/files/4476c761..d110ecfd

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=17
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=16-17

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7928.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7928/head:pull/7928

PR: https://git.openjdk.java.net/jdk/pull/7928

From duke at openjdk.java.net  Wed Apr 13 22:20:15 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Wed, 13 Apr 2022 22:20:15 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v16]
In-Reply-To: <qpvhWVidYy6h6EC2eMfJeqkwifiWrFOVFPZljfEjimg=.f39246a8-4e98-4969-a0ef-7a8943bebec2@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
 <qpvhWVidYy6h6EC2eMfJeqkwifiWrFOVFPZljfEjimg=.f39246a8-4e98-4969-a0ef-7a8943bebec2@github.com>
Message-ID: <aeAmEgTYdl1ETRnV2HJMmWJzm3Po_la_JMlHSRxjV6w=.c416dccb-e233-4bca-b3d3-98af298ec2fd@github.com>

On Wed, 13 Apr 2022 20:06:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert changes in:
>>   src/java.desktop
>>   src/java.management
>>   src/jdk.internal.vm.ci
>>   src/jdk.jfr
>>   src/jdk.management.jfr
>>   src/jdk.management
>>   src/utils/IdealGraphVisualizer
>
> Looks good for changes in i18n related call sites, assuming that the copyright years will be updated.
> 
> Should we need some additions/modifications to the hashmap optimal capacity utility `test/lib/jdk/test/lib/util/OptimalCapacity.java`?

@naotoj @JoeWang-Java copyright updated to 2022. LastModified updated to 2022.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From smarks at openjdk.java.net  Wed Apr 13 22:44:19 2022
From: smarks at openjdk.java.net (Stuart Marks)
Date: Wed, 13 Apr 2022 22:44:19 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
Message-ID: <0wlaWl-UQhwWw0Oe1JNW3JrpYKHahcEfrdbWjXOZ7Ic=.ab6c195a-f142-4aa2-824e-d4afe63a2e4c@github.com>

On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update LastModified

src/java.base/share/classes/java/lang/Character.java line 8574:

> 8572:         private static final HashMap<String, Character.UnicodeScript> aliases;
> 8573:         static {
> 8574:             aliases = HashMap.newHashMap(162);

@naotoj Seems like this magic number is likely to go out of date. Should there be a test for it like the one you updated for NUM_ENTITIES? [JDK-8283465](https://bugs.openjdk.java.net/browse/JDK-8283465).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From cjplummer at openjdk.java.net  Wed Apr 13 22:45:18 2022
From: cjplummer at openjdk.java.net (Chris Plummer)
Date: Wed, 13 Apr 2022 22:45:18 GMT
Subject: <i18n dev> RFR: 8284853: Fix varios 'expected' typo
In-Reply-To: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
References: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
Message-ID: <QJCzMs3gkj9ursFFOEjh83AzGXE69C_m2I8N0rj-RKc=.a5484f8c-880b-4f18-b0c1-3db360b5b66d@github.com>

On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> Found various typos of expected: `exepected`, `exept`, `epectedly`, `expeced`, `Unexpeted`, etc.

test/jdk/java/lang/StackWalker/StackStreamTest.java line 218:

> 216:     private static <T> void equalsOrThrow(String label, List<T> list, List<T> expected) {
> 217:         System.out.println("List:     " + list);
> 218:         System.out.println("Expected: " + list);

I think there is a per-existing bug here. Shouldn't the second println print `expected` instead of `list`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8231

From naoto at openjdk.java.net  Wed Apr 13 22:56:31 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Wed, 13 Apr 2022 22:56:31 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <0wlaWl-UQhwWw0Oe1JNW3JrpYKHahcEfrdbWjXOZ7Ic=.ab6c195a-f142-4aa2-824e-d4afe63a2e4c@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
 <0wlaWl-UQhwWw0Oe1JNW3JrpYKHahcEfrdbWjXOZ7Ic=.ab6c195a-f142-4aa2-824e-d4afe63a2e4c@github.com>
Message-ID: <uNsLbPcKwzq-jlie7JtG8BbwMtMYJ-hTH1h4SD9aybo=.8acf4bf4-4cb7-4b8d-9261-4e29e6ba3ed2@github.com>

On Wed, 13 Apr 2022 22:40:38 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update LastModified
>
> src/java.base/share/classes/java/lang/Character.java line 8574:
> 
>> 8572:         private static final HashMap<String, Character.UnicodeScript> aliases;
>> 8573:         static {
>> 8574:             aliases = HashMap.newHashMap(162);
> 
> @naotoj Seems like this magic number is likely to go out of date. Should there be a test for it like the one you updated for NUM_ENTITIES? [JDK-8283465](https://bugs.openjdk.java.net/browse/JDK-8283465).

Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From smarks at openjdk.java.net  Wed Apr 13 23:01:16 2022
From: smarks at openjdk.java.net (Stuart Marks)
Date: Wed, 13 Apr 2022 23:01:16 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
Message-ID: <LB4oSepLE4LT6GAsXsA-_xNXy2jposq81LCvYPfuqAU=.6995b657-48e3-4da1-b2b9-ad3edf91d3eb@github.com>

On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update LastModified

src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java line 171:

> 169:         _current = 0;
> 170:         _size  = size;
> 171:         _references = HashMap.newHashMap(_size);

Not `_size+2` ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From smarks at openjdk.java.net  Wed Apr 13 23:06:16 2022
From: smarks at openjdk.java.net (Stuart Marks)
Date: Wed, 13 Apr 2022 23:06:16 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
Message-ID: <llN0hu4w8KoDvGAH7i0cILjDW8fM8cRbpWT5pS0GMzA=.7831e7a1-e074-4bad-b5d9-c153d535bef2@github.com>

On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update LastModified

src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java line 1819:

> 1817:     Map<String, OneAttr> items;
> 1818:     LargeContainer(int size) {
> 1819:         items = HashMap.newHashMap(size*2+1);

I'm wondering if we should change this to just `newHashMap(size)` since it looks like this container is intended to hold up to `size` items. @JoeWang-Java ? I suspect the `size*2+1` was a failed attempt at allocating a HashMap of the correct capacity for `size` mappings.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From smarks at openjdk.java.net  Wed Apr 13 23:29:19 2022
From: smarks at openjdk.java.net (Stuart Marks)
Date: Wed, 13 Apr 2022 23:29:19 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
Message-ID: <xKjqLHNKD27oflyQv-JEVlumtfbMxbXoAETc84R4PcU=.1f7cb340-1bc8-476d-852b-05bfbd0b3444@github.com>

On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update LastModified

src/java.base/unix/classes/java/lang/ProcessEnvironment.java line 102:

> 100:     /* Only for use by Runtime.exec(...String[]envp...) */
> 101:     static Map<String,String> emptyEnvironment(int capacity) {
> 102:         return new StringEnvironment(HashMap.newHashMap(capacity));

This change is correct, since this is called with the length of an array that's used to populate the environment. It really should be named `size` instead of `capacity`. However the windows version of this code simply calls `super(capacity)` as it's a subclass of `HashMap`, which is wrong. Well, probably not worth changing this now. We may need to revisit this later to do some cleaning up. (And also the strange computation in the static initializer at line 71.)

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From smarks at openjdk.java.net  Wed Apr 13 23:51:16 2022
From: smarks at openjdk.java.net (Stuart Marks)
Date: Wed, 13 Apr 2022 23:51:16 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v16]
In-Reply-To: <qpvhWVidYy6h6EC2eMfJeqkwifiWrFOVFPZljfEjimg=.f39246a8-4e98-4969-a0ef-7a8943bebec2@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
 <qpvhWVidYy6h6EC2eMfJeqkwifiWrFOVFPZljfEjimg=.f39246a8-4e98-4969-a0ef-7a8943bebec2@github.com>
Message-ID: <vEz7aCqZt0iNT81M6eQknpR097fgnYuwt83OkZ9Sv0U=.70cc6cdb-b842-437a-97fb-87f82c0b3ec6@github.com>

On Wed, 13 Apr 2022 20:06:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert changes in:
>>   src/java.desktop
>>   src/java.management
>>   src/jdk.internal.vm.ci
>>   src/jdk.jfr
>>   src/jdk.management.jfr
>>   src/jdk.management
>>   src/utils/IdealGraphVisualizer
>
> Looks good for changes in i18n related call sites, assuming that the copyright years will be updated.
> 
> Should we need some additions/modifications to the hashmap optimal capacity utility `test/lib/jdk/test/lib/util/OptimalCapacity.java`?

@naotoj wrote:

> Should we need some additions/modifications to the hashmap optimal capacity utility `test/lib/jdk/test/lib/util/OptimalCapacity.java`?

The only thing that uses this utility now is `test/jdk/java/lang/Enum/ConstantDirectoryOptimalCapacity.java`, which is on the problem list. The cleanup is covered by [JDK-8282120](https://bugs.openjdk.java.net/browse/JDK-8282120). After this PR gets integrated, the Enum ConstantDirectory will be initialized with `HashMap.newHashMap(universe.length)` so the OptimalCapacity test won't really be testing anything. I'll take another look at it and the library utility, but I suspect the cleanup may simply be removing them entirely.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From naoto at openjdk.java.net  Thu Apr 14 00:32:19 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Thu, 14 Apr 2022 00:32:19 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v16]
In-Reply-To: <vEz7aCqZt0iNT81M6eQknpR097fgnYuwt83OkZ9Sv0U=.70cc6cdb-b842-437a-97fb-87f82c0b3ec6@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
 <qpvhWVidYy6h6EC2eMfJeqkwifiWrFOVFPZljfEjimg=.f39246a8-4e98-4969-a0ef-7a8943bebec2@github.com>
 <vEz7aCqZt0iNT81M6eQknpR097fgnYuwt83OkZ9Sv0U=.70cc6cdb-b842-437a-97fb-87f82c0b3ec6@github.com>
Message-ID: <_7xS1jx8qIo088_W_yOC8VCiUgRyl4eWXrNSWSa6OPY=.e8d5bdd1-91bb-4eb7-8043-20197415e5d8@github.com>

On Wed, 13 Apr 2022 23:48:06 GMT, Stuart Marks <smarks at openjdk.org> wrote:

> but I suspect the cleanup may simply be removing them entirely.

+1 for removing it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From duke at openjdk.java.net  Thu Apr 14 01:18:10 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Thu, 14 Apr 2022 01:18:10 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <LB4oSepLE4LT6GAsXsA-_xNXy2jposq81LCvYPfuqAU=.6995b657-48e3-4da1-b2b9-ad3edf91d3eb@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
 <LB4oSepLE4LT6GAsXsA-_xNXy2jposq81LCvYPfuqAU=.6995b657-48e3-4da1-b2b9-ad3edf91d3eb@github.com>
Message-ID: <UIxbDGH3RZVwDMUQ9SRhvenKjBbdb1XpyUfb0hmGMUM=.a82a0603-32a6-40a2-b9e9-2ce23b3e1a70@github.com>

On Wed, 13 Apr 2022 22:57:33 GMT, Stuart Marks <smarks at openjdk.org> wrote:

> Not `_size+2` ?

I don't have a idea here why he original use the + 2.
Is there any guy more familiar with this code tell me why?
Thanks!

> I suspect the `size*2+1` was a failed attempt at allocating a HashMap of the correct capacity for `size` mappings.

I looked the codes and don't think so..
If I'm wrong, I'm glad to fix.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From joehw at openjdk.java.net  Thu Apr 14 03:31:15 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 14 Apr 2022 03:31:15 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <UIxbDGH3RZVwDMUQ9SRhvenKjBbdb1XpyUfb0hmGMUM=.a82a0603-32a6-40a2-b9e9-2ce23b3e1a70@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
 <LB4oSepLE4LT6GAsXsA-_xNXy2jposq81LCvYPfuqAU=.6995b657-48e3-4da1-b2b9-ad3edf91d3eb@github.com>
 <UIxbDGH3RZVwDMUQ9SRhvenKjBbdb1XpyUfb0hmGMUM=.a82a0603-32a6-40a2-b9e9-2ce23b3e1a70@github.com>
Message-ID: <BNmV2tQmiQBFjvZ_vxRdfPyqy79igTcftERt5Lsy1QM=.c053d883-e793-4183-b525-b645a96294e1@github.com>

On Thu, 14 Apr 2022 01:15:05 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java line 171:
>> 
>>> 169:         _current = 0;
>>> 170:         _size  = size;
>>> 171:         _references = HashMap.newHashMap(_size);
>> 
>> Not `_size+2` ?
>
>> Not `_size+2` ?
> 
> I don't have a idea here why he original use the + 2.
> Is there any guy more familiar with this code tell me why?
> Thanks!

size, not size + 2, same situation as size*2+1 below.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From joehw at openjdk.java.net  Thu Apr 14 03:42:16 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 14 Apr 2022 03:42:16 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <UIxbDGH3RZVwDMUQ9SRhvenKjBbdb1XpyUfb0hmGMUM=.a82a0603-32a6-40a2-b9e9-2ce23b3e1a70@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
 <LB4oSepLE4LT6GAsXsA-_xNXy2jposq81LCvYPfuqAU=.6995b657-48e3-4da1-b2b9-ad3edf91d3eb@github.com>
 <UIxbDGH3RZVwDMUQ9SRhvenKjBbdb1XpyUfb0hmGMUM=.a82a0603-32a6-40a2-b9e9-2ce23b3e1a70@github.com>
Message-ID: <TeeKCwr29XOequYIh4iw9_YGqyOWx1r0YwqTP64VgZ8=.f1094640-6f9c-4c2c-9120-f0c6c0031f79@github.com>

On Thu, 14 Apr 2022 01:13:18 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java line 1819:
>> 
>>> 1817:     Map<String, OneAttr> items;
>>> 1818:     LargeContainer(int size) {
>>> 1819:         items = HashMap.newHashMap(size*2+1);
>> 
>> I'm wondering if we should change this to just `newHashMap(size)` since it looks like this container is intended to hold up to `size` items. @JoeWang-Java ? I suspect the `size*2+1` was a failed attempt at allocating a HashMap of the correct capacity for `size` mappings.
>
>> I suspect the `size*2+1` was a failed attempt at allocating a HashMap of the correct capacity for `size` mappings.
> 
> I looked the codes and don't think so..
> If I'm wrong, I'm glad to fix.

Stuart's right, I looked at the code, it's as you said a failed attempt, "size" would be good. So HashMap.newHashMap(size) would actually be a small improvement.

It's an interesting impl the way it used HashMap, but it's 20 year code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From dfuchs at openjdk.java.net  Thu Apr 14 08:45:19 2022
From: dfuchs at openjdk.java.net (Daniel Fuchs)
Date: Thu, 14 Apr 2022 08:45:19 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v16]
In-Reply-To: <tyREZE5_pIE3fSFQ00_rWQqm3PuMcbtv5HpmUnHebkk=.9779c0a0-a489-4dd0-a5db-dbf3cfd5ef74@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <alykClXOoxLuAX40wiHjq9twn9rXyA67_epbYmb3s08=.0dd97e53-bd41-4513-b615-97796830eb4a@github.com>
 <tyREZE5_pIE3fSFQ00_rWQqm3PuMcbtv5HpmUnHebkk=.9779c0a0-a489-4dd0-a5db-dbf3cfd5ef74@github.com>
Message-ID: <je65Tw3mTsl11lY5ckAzBxC6cOOZ71S1EK8EGCgWqTg=.4bf8d576-0773-4067-a773-84a70fb9a578@github.com>

On Wed, 13 Apr 2022 19:28:08 GMT, Stuart Marks <smarks at openjdk.org> wrote:

> Reviewers for i18n, net, nio, and security, please review call site changes in your areas. Thanks.

Changes to `java.net.http` look good to me. I haven't spotted anything obviously wrong in the rest, but should defer to reviewers of these areas.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From aturbanov at openjdk.java.net  Thu Apr 14 09:28:17 2022
From: aturbanov at openjdk.java.net (Andrey Turbanov)
Date: Thu, 14 Apr 2022 09:28:17 GMT
Subject: <i18n dev> RFR: 8284853: Fix various 'expected' typo [v2]
In-Reply-To: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
References: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
Message-ID: <bisAVGnhNiqxb9oNb7lsqrjIO84qDRUeqyfw7p7jSME=.e2b1b6c3-fc70-4b5b-8cb2-d1987de9a7dd@github.com>

> Found various typos of expected: `exepected`, `exept`, `epectedly`, `expeced`, `Unexpeted`, etc.

Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:

  8284853: Fix various 'expected' typo
  improve test log

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8231/files
  - new: https://git.openjdk.java.net/jdk/pull/8231/files/fe6d9890..9fc75e89

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8231&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8231&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8231.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8231/head:pull/8231

PR: https://git.openjdk.java.net/jdk/pull/8231

From yyang at openjdk.java.net  Thu Apr 14 10:42:11 2022
From: yyang at openjdk.java.net (Yi Yang)
Date: Thu, 14 Apr 2022 10:42:11 GMT
Subject: <i18n dev> RFR: 8284853: Fix various 'expected' typo [v2]
In-Reply-To: <bisAVGnhNiqxb9oNb7lsqrjIO84qDRUeqyfw7p7jSME=.e2b1b6c3-fc70-4b5b-8cb2-d1987de9a7dd@github.com>
References: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
 <bisAVGnhNiqxb9oNb7lsqrjIO84qDRUeqyfw7p7jSME=.e2b1b6c3-fc70-4b5b-8cb2-d1987de9a7dd@github.com>
Message-ID: <rNQ6IxlRdqzXlRKEfw2Hnyn7pI5_h3ydBV_grUrKfe0=.82d95656-bdd3-4607-a12d-5964ac33f53a@github.com>

On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Found various typos of expected: `exepected`, `exept`, `epectedly`, `expeced`, `Unexpeted`, etc.
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8284853: Fix various 'expected' typo
>   improve test log

I found [yet another typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948), I wonder if you can merge this into your patch so that I do not need to submit a new PR for it? Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8231

From ihse at openjdk.java.net  Thu Apr 14 13:13:15 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Thu, 14 Apr 2022 13:13:15 GMT
Subject: <i18n dev> RFR: 8284853: Fix various 'expected' typo [v2]
In-Reply-To: <bisAVGnhNiqxb9oNb7lsqrjIO84qDRUeqyfw7p7jSME=.e2b1b6c3-fc70-4b5b-8cb2-d1987de9a7dd@github.com>
References: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
 <bisAVGnhNiqxb9oNb7lsqrjIO84qDRUeqyfw7p7jSME=.e2b1b6c3-fc70-4b5b-8cb2-d1987de9a7dd@github.com>
Message-ID: <X-2el87FZNWkIJqRe20t_Bl9wIiXf3fwfEt1TELtIZk=.a3adafdc-952b-4f8b-a0be-fa4415426f06@github.com>

On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Found various typos of expected: `exepected`, `exept`, `epectedly`, `expeced`, `Unexpeted`, etc.
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8284853: Fix various 'expected' typo
>   improve test log

Build changes look good.

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8231

From chegar at openjdk.java.net  Thu Apr 14 15:55:35 2022
From: chegar at openjdk.java.net (Chris Hegarty)
Date: Thu, 14 Apr 2022 15:55:35 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
Message-ID: <4BdteSngv9Euudaha21kOdmSYZicJ6L7jWT-emmUqTk=.4a13e3b2-b75f-4c42-b5bd-f839b5cf898d@github.com>

On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update LastModified

LGTM.

-------------

Marked as reviewed by chegar (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7928

From ihse at openjdk.java.net  Thu Apr 14 16:12:27 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Thu, 14 Apr 2022 16:12:27 GMT
Subject: <i18n dev> RFR: 8284891: Fix typos in build system files
Message-ID: <48sHX_PTeLN0flIYI_TiwTd3gsE3QGm3xw_iaoA6mTU=.2efe1eea-0398-43ca-ad71-3ce4671c0ffe@github.com>

I ran `codespell` on the `make` directory, and accepted those changes where it indeed discovered real typos.

(Due to false positives this can unfortunately not be run automatically) 

Most of the fixes are in comments. A few are in messages aimed at the user.

-------------

Commit messages:
 - 8284891: Fix typos in build system files

Changes: https://git.openjdk.java.net/jdk/pull/8246/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8246&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284891
  Stats: 72 lines in 46 files changed: 0 ins; 0 del; 72 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8246.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8246/head:pull/8246

PR: https://git.openjdk.java.net/jdk/pull/8246

From erikj at openjdk.java.net  Thu Apr 14 16:29:40 2022
From: erikj at openjdk.java.net (Erik Joelsson)
Date: Thu, 14 Apr 2022 16:29:40 GMT
Subject: <i18n dev> RFR: 8284891: Fix typos in build system files
In-Reply-To: <48sHX_PTeLN0flIYI_TiwTd3gsE3QGm3xw_iaoA6mTU=.2efe1eea-0398-43ca-ad71-3ce4671c0ffe@github.com>
References: <48sHX_PTeLN0flIYI_TiwTd3gsE3QGm3xw_iaoA6mTU=.2efe1eea-0398-43ca-ad71-3ce4671c0ffe@github.com>
Message-ID: <eOghGOYfVNtq52tpdDhCbiKEXTUC49ROtX8_2BfvTV8=.e21f3899-eab3-4c74-8328-e2e5ca85102f@github.com>

On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `make` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> Most of the fixes are in comments. A few are in messages aimed at the user.

Marked as reviewed by erikj (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8246

From duke at openjdk.java.net  Thu Apr 14 16:58:40 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Thu, 14 Apr 2022 16:58:40 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v19]
In-Reply-To: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
Message-ID: <P631sogg9J48Hw0iIQpn49QSTlKzE72T2FcLRVP0AmM=.d66c9f4f-8a11-401f-b6ea-6de553cb86a3@github.com>

> 8186958: Need method to create pre-sized HashMap

XenoAmess has updated the pull request incrementally with one additional commit since the last revision:

  fix usage in XSAttributeChecker

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7928/files
  - new: https://git.openjdk.java.net/jdk/pull/7928/files/d110ecfd..5603f193

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=18
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=17-18

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7928.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7928/head:pull/7928

PR: https://git.openjdk.java.net/jdk/pull/7928

From duke at openjdk.java.net  Thu Apr 14 16:58:42 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Thu, 14 Apr 2022 16:58:42 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <TeeKCwr29XOequYIh4iw9_YGqyOWx1r0YwqTP64VgZ8=.f1094640-6f9c-4c2c-9120-f0c6c0031f79@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
 <LB4oSepLE4LT6GAsXsA-_xNXy2jposq81LCvYPfuqAU=.6995b657-48e3-4da1-b2b9-ad3edf91d3eb@github.com>
 <UIxbDGH3RZVwDMUQ9SRhvenKjBbdb1XpyUfb0hmGMUM=.a82a0603-32a6-40a2-b9e9-2ce23b3e1a70@github.com>
 <TeeKCwr29XOequYIh4iw9_YGqyOWx1r0YwqTP64VgZ8=.f1094640-6f9c-4c2c-9120-f0c6c0031f79@github.com>
Message-ID: <TiKzQTj-W4CZ5N9lNjgq-J53-4ZNoMuobFXWxvs2X78=.e926a732-4332-4f90-bfe2-e1fd27ed545c@github.com>

On Thu, 14 Apr 2022 03:38:52 GMT, Joe Wang <joehw at openjdk.org> wrote:

>>> I suspect the `size*2+1` was a failed attempt at allocating a HashMap of the correct capacity for `size` mappings.
>> 
>> I looked the codes and don't think so..
>> If I'm wrong, I'm glad to fix.
>
> Stuart's right, I looked at the code, it's as you said a failed attempt, "size" would be good. So HashMap.newHashMap(size) would actually be a small improvement.
> 
> It's an interesting impl the way it used HashMap, but it's 20 year code.

@JoeWang-Java @stuart-marks got it. done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From duke at openjdk.java.net  Thu Apr 14 17:05:39 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Thu, 14 Apr 2022 17:05:39 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v20]
In-Reply-To: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
Message-ID: <tZp1Atbba9bPIrj2dkj0JHzXRr9eBIS6ooY0xgQEaCI=.d89f7b10-637c-4147-af70-fad81da2e08d@github.com>

> 8186958: Need method to create pre-sized HashMap

XenoAmess has updated the pull request incrementally with one additional commit since the last revision:

  revert changes on ProcessEnvironment

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7928/files
  - new: https://git.openjdk.java.net/jdk/pull/7928/files/5603f193..5b437dab

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=19
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=18-19

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7928.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7928/head:pull/7928

PR: https://git.openjdk.java.net/jdk/pull/7928

From duke at openjdk.java.net  Thu Apr 14 17:05:42 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Thu, 14 Apr 2022 17:05:42 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <xKjqLHNKD27oflyQv-JEVlumtfbMxbXoAETc84R4PcU=.1f7cb340-1bc8-476d-852b-05bfbd0b3444@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
 <xKjqLHNKD27oflyQv-JEVlumtfbMxbXoAETc84R4PcU=.1f7cb340-1bc8-476d-852b-05bfbd0b3444@github.com>
Message-ID: <74mi18QF7mCaY5H_LJgOl47cqfoEB3WEmOVtfsv6v2A=.901a9ead-673e-4948-89a8-3f1dbfacbf8a@github.com>

On Wed, 13 Apr 2022 23:25:47 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update LastModified
>
> src/java.base/unix/classes/java/lang/ProcessEnvironment.java line 102:
> 
>> 100:     /* Only for use by Runtime.exec(...String[]envp...) */
>> 101:     static Map<String,String> emptyEnvironment(int capacity) {
>> 102:         return new StringEnvironment(HashMap.newHashMap(capacity));
> 
> This change is correct, since this is called with the length of an array that's used to populate the environment. It really should be named `size` instead of `capacity`. However the windows version of this code simply calls `super(capacity)` as it's a subclass of `HashMap`, which is wrong. Well, probably not worth changing this now. We may need to revisit this later to do some cleaning up. (And also the strange computation in the static initializer at line 71.)

@stuart-marks OK, changes on this class reverted.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From duke at openjdk.java.net  Thu Apr 14 17:10:36 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Thu, 14 Apr 2022 17:10:36 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <uNsLbPcKwzq-jlie7JtG8BbwMtMYJ-hTH1h4SD9aybo=.8acf4bf4-4cb7-4b8d-9261-4e29e6ba3ed2@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
 <0wlaWl-UQhwWw0Oe1JNW3JrpYKHahcEfrdbWjXOZ7Ic=.ab6c195a-f142-4aa2-824e-d4afe63a2e4c@github.com>
 <uNsLbPcKwzq-jlie7JtG8BbwMtMYJ-hTH1h4SD9aybo=.8acf4bf4-4cb7-4b8d-9261-4e29e6ba3ed2@github.com>
Message-ID: <9Mjy2CA-ZYTC5v7KdhMuULeghdOSotPnUZnMIjxEplA=.cbf4cd73-5c1e-42d4-82a3-2e791e2af0f0@github.com>

On Wed, 13 Apr 2022 22:53:15 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856

@stuart-marks @naotoj I can help solve JDK-8284856 after this pr. But usually we only solve 1 issue in 1 pr, so I think it's better to wait after this.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From joehw at openjdk.java.net  Thu Apr 14 17:26:48 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 14 Apr 2022 17:26:48 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v20]
In-Reply-To: <tZp1Atbba9bPIrj2dkj0JHzXRr9eBIS6ooY0xgQEaCI=.d89f7b10-637c-4147-af70-fad81da2e08d@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <tZp1Atbba9bPIrj2dkj0JHzXRr9eBIS6ooY0xgQEaCI=.d89f7b10-637c-4147-af70-fad81da2e08d@github.com>
Message-ID: <7GEnLP4Zqzr8PjggCXITqnTE6eMMMeKmBFJONfjdm_0=.8867cd6b-6197-430f-8b81-02416083240b@github.com>

On Thu, 14 Apr 2022 17:05:39 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert changes on ProcessEnvironment

src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java line 3:

> 1: /*
> 2:  * Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
> 3:  */

The LastModified tag was missing in this class. Pls use this opportunity to add it in the same format as the other classes (CoreDocumentImpl, XSAttributeChecker), that is after line 52. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From aturbanov at openjdk.java.net  Thu Apr 14 18:09:34 2022
From: aturbanov at openjdk.java.net (Andrey Turbanov)
Date: Thu, 14 Apr 2022 18:09:34 GMT
Subject: <i18n dev> RFR: 8284853: Fix various 'expected' typo [v2]
In-Reply-To: <rNQ6IxlRdqzXlRKEfw2Hnyn7pI5_h3ydBV_grUrKfe0=.82d95656-bdd3-4607-a12d-5964ac33f53a@github.com>
References: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
 <bisAVGnhNiqxb9oNb7lsqrjIO84qDRUeqyfw7p7jSME=.e2b1b6c3-fc70-4b5b-8cb2-d1987de9a7dd@github.com>
 <rNQ6IxlRdqzXlRKEfw2Hnyn7pI5_h3ydBV_grUrKfe0=.82d95656-bdd3-4607-a12d-5964ac33f53a@github.com>
Message-ID: <b2zhGMW2RG0f8ZRDrnI8nSfW-JeuZx8-DNvJaGRXu4g=.dcfbe0fb-6f7c-4f46-8fbe-458a42f7ca21@github.com>

On Thu, 14 Apr 2022 10:38:33 GMT, Yi Yang <yyang at openjdk.org> wrote:

>I found [yet another typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948), I wonder if you can merge this into your patch so that I do not need to submit a new PR for it? Thanks.

I think it deserves a separate ticket. BTW there are a lot of other typos in JDK, especially in comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8231

From aturbanov at openjdk.java.net  Thu Apr 14 18:09:37 2022
From: aturbanov at openjdk.java.net (Andrey Turbanov)
Date: Thu, 14 Apr 2022 18:09:37 GMT
Subject: <i18n dev> Integrated: 8284853: Fix various 'expected' typo
In-Reply-To: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
References: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
Message-ID: <EazeFRrVhzLud87RZyQuAAcvVVGBXgS_8bvUToeijvA=.6d3c58fc-5c53-4e82-8166-8ce446c200c6@github.com>

On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> Found various typos of expected: `exepected`, `exept`, `epectedly`, `expeced`, `Unexpeted`, etc.

This pull request has now been integrated.

Changeset: 48c75498
Author:    Andrey Turbanov <aturbanov at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/48c75498060f076287d3d44c49934db9ac70887b
Stats:     65 lines in 28 files changed: 0 ins; 0 del; 65 mod

8284853: Fix various 'expected' typo

Reviewed-by: bpb, ihse

-------------

PR: https://git.openjdk.java.net/jdk/pull/8231

From duke at openjdk.java.net  Thu Apr 14 18:10:28 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Thu, 14 Apr 2022 18:10:28 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v21]
In-Reply-To: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
Message-ID: <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>

> 8186958: Need method to create pre-sized HashMap

XenoAmess has updated the pull request incrementally with one additional commit since the last revision:

  add `@LastModified: Apr 2022` to DocumentCache

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7928/files
  - new: https://git.openjdk.java.net/jdk/pull/7928/files/5b437dab..71b7dba3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=20
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=19-20

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7928.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7928/head:pull/7928

PR: https://git.openjdk.java.net/jdk/pull/7928

From duke at openjdk.java.net  Thu Apr 14 18:10:29 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Thu, 14 Apr 2022 18:10:29 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v20]
In-Reply-To: <7GEnLP4Zqzr8PjggCXITqnTE6eMMMeKmBFJONfjdm_0=.8867cd6b-6197-430f-8b81-02416083240b@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <tZp1Atbba9bPIrj2dkj0JHzXRr9eBIS6ooY0xgQEaCI=.d89f7b10-637c-4147-af70-fad81da2e08d@github.com>
 <7GEnLP4Zqzr8PjggCXITqnTE6eMMMeKmBFJONfjdm_0=.8867cd6b-6197-430f-8b81-02416083240b@github.com>
Message-ID: <tSlLBxAsXHwrFHMk90N9XOgDE1CKTMywSUnzq-Ob60o=.08c584cc-cc32-4a57-995e-8b6eeeac5463@github.com>

On Thu, 14 Apr 2022 17:23:42 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert changes on ProcessEnvironment
>
> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
>> 3:  */
> 
> The LastModified tag was missing in this class. Pls use this opportunity to add it in the same format as the other classes (CoreDocumentImpl, XSAttributeChecker), that is after line 52. Thanks.

@JoeWang-Java done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From joehw at openjdk.java.net  Thu Apr 14 18:25:32 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 14 Apr 2022 18:25:32 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v21]
In-Reply-To: <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
Message-ID: <QJcLACbJeGjhzbnkc__febfL9ySxRjUphCeI7-qCPUw=.317b4810-f00c-4552-86dc-d5d78b1e66f9@github.com>

On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add `@LastModified: Apr 2022` to DocumentCache

Marked as reviewed by joehw (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From joehw at openjdk.java.net  Thu Apr 14 18:25:32 2022
From: joehw at openjdk.java.net (Joe Wang)
Date: Thu, 14 Apr 2022 18:25:32 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v20]
In-Reply-To: <tSlLBxAsXHwrFHMk90N9XOgDE1CKTMywSUnzq-Ob60o=.08c584cc-cc32-4a57-995e-8b6eeeac5463@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <tZp1Atbba9bPIrj2dkj0JHzXRr9eBIS6ooY0xgQEaCI=.d89f7b10-637c-4147-af70-fad81da2e08d@github.com>
 <7GEnLP4Zqzr8PjggCXITqnTE6eMMMeKmBFJONfjdm_0=.8867cd6b-6197-430f-8b81-02416083240b@github.com>
 <tSlLBxAsXHwrFHMk90N9XOgDE1CKTMywSUnzq-Ob60o=.08c584cc-cc32-4a57-995e-8b6eeeac5463@github.com>
Message-ID: <1RTVIryM7sFw60Su-rO3CRvJh7c3O-F9cpIqVAg5etw=.31126d2c-6643-4e4a-865a-0579cd35616b@github.com>

On Thu, 14 Apr 2022 18:05:48 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java line 3:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
>>> 3:  */
>> 
>> The LastModified tag was missing in this class. Pls use this opportunity to add it in the same format as the other classes (CoreDocumentImpl, XSAttributeChecker), that is after line 52. Thanks.
>
> @JoeWang-Java done.

Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From naoto at openjdk.java.net  Thu Apr 14 18:35:34 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Thu, 14 Apr 2022 18:35:34 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <9Mjy2CA-ZYTC5v7KdhMuULeghdOSotPnUZnMIjxEplA=.cbf4cd73-5c1e-42d4-82a3-2e791e2af0f0@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
 <0wlaWl-UQhwWw0Oe1JNW3JrpYKHahcEfrdbWjXOZ7Ic=.ab6c195a-f142-4aa2-824e-d4afe63a2e4c@github.com>
 <uNsLbPcKwzq-jlie7JtG8BbwMtMYJ-hTH1h4SD9aybo=.8acf4bf4-4cb7-4b8d-9261-4e29e6ba3ed2@github.com>
 <9Mjy2CA-ZYTC5v7KdhMuULeghdOSotPnUZnMIjxEplA=.cbf4cd73-5c1e-42d4-82a3-2e791e2af0f0@github.com>
Message-ID: <xr_Oxv8hC520hKGE0ZZGlje1WFwE2ganf__RB_l_x_Y=.db498695-3f47-49a0-8fe4-001fe9fb7b67@github.com>

On Thu, 14 Apr 2022 17:06:53 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
>
>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
> 
> @stuart-marks @naotoj I can help solve JDK-8284856 after this pr. But usually we only solve 1 issue in 1 pr, so I think it's better to wait after this.

Thanks. Will fix it myself, as I want to eliminate that immediate value in the code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From ihse at openjdk.java.net  Thu Apr 14 19:37:06 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Thu, 14 Apr 2022 19:37:06 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base
Message-ID: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>

I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.

(Due to false positives this can unfortunately not be run automatically) 

The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.

Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

-------------

Commit messages:
 - Pass #2
 - 8284893: Fix typos in java.base

Changes: https://git.openjdk.java.net/jdk/pull/8250/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8250&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284893
  Stats: 268 lines in 180 files changed: 0 ins; 0 del; 268 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8250.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8250/head:pull/8250

PR: https://git.openjdk.java.net/jdk/pull/8250

From ihse at openjdk.java.net  Thu Apr 14 19:37:33 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Thu, 14 Apr 2022 19:37:33 GMT
Subject: <i18n dev> Integrated: 8284891: Fix typos in build system files
In-Reply-To: <48sHX_PTeLN0flIYI_TiwTd3gsE3QGm3xw_iaoA6mTU=.2efe1eea-0398-43ca-ad71-3ce4671c0ffe@github.com>
References: <48sHX_PTeLN0flIYI_TiwTd3gsE3QGm3xw_iaoA6mTU=.2efe1eea-0398-43ca-ad71-3ce4671c0ffe@github.com>
Message-ID: <2mF5V7umZUZe-exsy8TAj69oQs5CZ1A41lGknDaoNVc=.bf65fd9f-8851-4626-8bd1-6f23fef1e945@github.com>

On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `make` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> Most of the fixes are in comments. A few are in messages aimed at the user.

This pull request has now been integrated.

Changeset: 160eb2bd
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/160eb2bd392fea29dd690ee9781174d14dc0b659
Stats:     72 lines in 46 files changed: 0 ins; 0 del; 72 mod

8284891: Fix typos in build system files

Reviewed-by: erikj

-------------

PR: https://git.openjdk.java.net/jdk/pull/8246

From naoto at openjdk.java.net  Thu Apr 14 19:51:29 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Thu, 14 Apr 2022 19:51:29 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base
In-Reply-To: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
Message-ID: <KzD9I_Ll4BSRvfaNeTJE9oFu5c-d-lK14u4cZoycM7M=.b213785f-0bca-42e7-bfd7-756b8a628799@github.com>

On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

src/java.base/share/classes/jdk/internal/icu/impl/NormalizerImpl.java line 2002:

> 2000:                 }
> 2001: 
> 2002:                 // this is where we are right now with all these indices:

Although these are actual typos, they come from upstream ICU code. Changing them locally would make merging complicated, so please exclude ICU related changes from the PR. I guess fixes in other 3rd party libraries are in the same boat.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

From mullan at openjdk.java.net  Thu Apr 14 19:58:49 2022
From: mullan at openjdk.java.net (Sean Mullan)
Date: Thu, 14 Apr 2022 19:58:49 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v21]
In-Reply-To: <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
Message-ID: <W_uSQSqLoHuPOuubV4NPKvP6ywhbhBRHQHtjIf-T4Ho=.b361deb5-6d4b-4192-804e-9d11bbbd17d2@github.com>

On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add `@LastModified: Apr 2022` to DocumentCache

Right, we generally try to avoid making too many changes to the implementation code in the java.xml.crypto module in order to stay consistent with Apache Santuario. They also would not accept this change because it is a new API and they need to run on older releases. I haven't had time yet to understand this Enhancement, but are the changes necessary for this part?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From wetmore at openjdk.java.net  Thu Apr 14 19:58:48 2022
From: wetmore at openjdk.java.net (Bradford Wetmore)
Date: Thu, 14 Apr 2022 19:58:48 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v21]
In-Reply-To: <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
Message-ID: <PGqk-qoYHcGMQXeez1FBLcWjDr-YdksvA0ZrUOIbgCs=.d5dcd37c-2412-44ba-9cbc-68eed4b0f5bd@github.com>

On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add `@LastModified: Apr 2022` to DocumentCache

I learned something new about HashMap today...

I looked at java.security.cert and sun.security.* and that part LGTM.

That said, you need to check with @seanjmullan for the java.xml.crypto code.  We try to keep the code in sync with the Apache code.  As this is a new API, we probably can't push this kind of change to Apache as they need to support older releases.

src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java line 110:

> 108:                 int length = attributes.getLength();
> 109:                 Map<String, String> namespaceMap =
> 110:                         HashMap.newHashMap(length);

Please check these changes with @seanjmullan before integrating.

-------------

Marked as reviewed by wetmore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7928

From iris at openjdk.java.net  Thu Apr 14 20:04:29 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Thu, 14 Apr 2022 20:04:29 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base
In-Reply-To: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
Message-ID: <NFvf7_p4txi12-K2-912ClqS4tYNahmEeymbTVj_r8Y=.160b9349-4a43-40eb-a21d-ce957322d779@github.com>

On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

Looks good.

I usually like GitHub's colorful diffs, but this is one of those rare cases where looking at the single webrev-generated diff file is so much easier.  About the only thing that could improve it would be to reduce the context (i.e. "diff -C").

-------------

Marked as reviewed by iris (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8250

From duke at openjdk.java.net  Thu Apr 14 20:15:33 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Thu, 14 Apr 2022 20:15:33 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v21]
In-Reply-To: <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
Message-ID: <qly5zkZEVyG6oOE3o_bbZUfJDmQJ-kGRDnIJCsbINBs=.685798e4-cd91-496c-aa1c-a9b68f75cd21@github.com>

On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add `@LastModified: Apr 2022` to DocumentCache

> Are the changes necessary for this part?

@seanjmullan no, they are just performance refinement.

If you really that wanna 100% sync ,

I can use the old 1.8 api to migrate that part, and make a mirror pr to that part of https://github.com/apache/santuario-xml-security-java

Is this solution acceptable then?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From mullan at openjdk.java.net  Thu Apr 14 20:20:33 2022
From: mullan at openjdk.java.net (Sean Mullan)
Date: Thu, 14 Apr 2022 20:20:33 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v21]
In-Reply-To: <qly5zkZEVyG6oOE3o_bbZUfJDmQJ-kGRDnIJCsbINBs=.685798e4-cd91-496c-aa1c-a9b68f75cd21@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
 <qly5zkZEVyG6oOE3o_bbZUfJDmQJ-kGRDnIJCsbINBs=.685798e4-cd91-496c-aa1c-a9b68f75cd21@github.com>
Message-ID: <aNyUSJzlvcSuVVEJD89DyIy5SBa1gL7esaf3ZpuVpmQ=.98e6b339-c853-4a88-84e3-6c245a979a0f@github.com>

On Thu, 14 Apr 2022 20:11:37 GMT, XenoAmess <duke at openjdk.java.net> wrote:

> > Are the changes necessary for this part?
> 
> @seanjmullan no, they are just performance refinement.
> 
> If you really that wanna 100% sync ,
> 
> I can use the old 1.8 api to migrate that part, and make a mirror pr to that part of https://github.com/apache/santuario-xml-security-java
> 
> Is this solution acceptable then?

Yes, that would be preferred. Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From wetmore at openjdk.java.net  Thu Apr 14 20:23:30 2022
From: wetmore at openjdk.java.net (Bradford Wetmore)
Date: Thu, 14 Apr 2022 20:23:30 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base
In-Reply-To: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
Message-ID: <4jUVElIYYvhwM9scNvI_4D6tfp5rcnuvSl5Pz969IqI=.29be0aa3-4db2-479c-8c44-71c299409f4b@github.com>

On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

I checked over:

java.base/macosx/classes/apple/security
java.base/share/classes/com/sun/crypto
java.base/share/classes/com/sun/security
java.base/share/classes/java/security
java.base/share/classes/javax/crypto
java.base/share/classes/javax/net
java.base/share/classes/sun/security

The copyright dates need updating.

src/java.base/share/classes/sun/security/provider/certpath/AdjacencyList.java line 128:

> 126:         // Each time this method is called, we're examining a new list
> 127:         // from the global list. So, we have to start by getting the list
> 128:         // that contains the set of Vertices we're considering.

The class being affected is a Vertex, so either change to vertices, or leave as is...

-------------

Marked as reviewed by wetmore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8250

From smarks at openjdk.java.net  Thu Apr 14 20:43:44 2022
From: smarks at openjdk.java.net (Stuart Marks)
Date: Thu, 14 Apr 2022 20:43:44 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v21]
In-Reply-To: <PGqk-qoYHcGMQXeez1FBLcWjDr-YdksvA0ZrUOIbgCs=.d5dcd37c-2412-44ba-9cbc-68eed4b0f5bd@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
 <PGqk-qoYHcGMQXeez1FBLcWjDr-YdksvA0ZrUOIbgCs=.d5dcd37c-2412-44ba-9cbc-68eed4b0f5bd@github.com>
Message-ID: <UfhZnP73mlxYy6OFNfFOPiNnqa8EWg_I5lxPC3FJWsg=.bf1c6eff-e08d-4f3f-af05-8106821c66a2@github.com>

On Thu, 14 Apr 2022 19:53:45 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add `@LastModified: Apr 2022` to DocumentCache
>
> I learned something new about HashMap today...
> 
> I looked at java.security.cert and sun.security.* and that part LGTM.
> 
> That said, you need to check with @seanjmullan for the java.xml.crypto code.  We try to keep the code in sync with the Apache code.  As this is a new API, we probably can't push this kind of change to Apache as they need to support older releases.

Thanks @bradfordwetmore and @seanjmullan for looking at this, and @XenoAmess for following up quickly.

To summarize, it sounds like the only issues are with the changes to two files in the `java.xml.crypto` area, as those need to be maintained in sync with Apache Santuario. Right?

In both cases it looks like the HashMap is likely being under-allocated, so the fix would be to inline to capacity computation, something like `new HashMap<>((int) Math.ceil(length / 0.75))` I guess.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From naoto at openjdk.java.net  Thu Apr 14 21:04:31 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Thu, 14 Apr 2022 21:04:31 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v18]
In-Reply-To: <xr_Oxv8hC520hKGE0ZZGlje1WFwE2ganf__RB_l_x_Y=.db498695-3f47-49a0-8fe4-001fe9fb7b67@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <83dD1w2lWpo0serYy4URwBzDYkbsXSZtHMbafkSHe9Q=.1a45d190-2374-4e67-a0b7-3a0384479c3b@github.com>
 <0wlaWl-UQhwWw0Oe1JNW3JrpYKHahcEfrdbWjXOZ7Ic=.ab6c195a-f142-4aa2-824e-d4afe63a2e4c@github.com>
 <uNsLbPcKwzq-jlie7JtG8BbwMtMYJ-hTH1h4SD9aybo=.8acf4bf4-4cb7-4b8d-9261-4e29e6ba3ed2@github.com>
 <9Mjy2CA-ZYTC5v7KdhMuULeghdOSotPnUZnMIjxEplA=.cbf4cd73-5c1e-42d4-82a3-2e791e2af0f0@github.com>
 <xr_Oxv8hC520hKGE0ZZGlje1WFwE2ganf__RB_l_x_Y=.db498695-3f47-49a0-8fe4-001fe9fb7b67@github.com>
Message-ID: <URmfzCNj1_Yt7Y9XCaHJgmGJWo-vAXCUV91LH1OCzh0=.effaaf8d-89d2-4e6e-b17d-bcdc4b8f8db3@github.com>

On Thu, 14 Apr 2022 18:32:03 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
>> 
>> @stuart-marks @naotoj I can help solve JDK-8284856 after this pr. But usually we only solve 1 issue in 1 pr, so I think it's better to wait after this.
>
> Thanks. Will fix it myself, as I want to eliminate that immediate value in the code.

PR opened, based on this PR.
https://github.com/openjdk/jdk/pull/8253

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From naoto at openjdk.java.net  Thu Apr 14 21:22:50 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Thu, 14 Apr 2022 21:22:50 GMT
Subject: <i18n dev> RFR: 8284856: Add a test case for checking UnicodeScript
 entity numbers
Message-ID: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>

Added the test case, and eliminated the immediate hashmap value, replaced with the ordinal number of `Character.UnicodeScript.UNKNOWN`.

-------------

Depends on: https://git.openjdk.java.net/jdk/pull/7928

Commit messages:
 - 8284856: Add a test case for checking UnicodeScript entity numbers

Changes: https://git.openjdk.java.net/jdk/pull/8253/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8253&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284856
  Stats: 13 lines in 2 files changed: 8 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8253.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8253/head:pull/8253

PR: https://git.openjdk.java.net/jdk/pull/8253

From duke at openjdk.java.net  Thu Apr 14 21:27:16 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Thu, 14 Apr 2022 21:27:16 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v22]
In-Reply-To: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
Message-ID: <8BqTTnIZwmWPePWhmjea15skxDmEexP5ugH8H2PawtI=.79a6387d-4a4d-4867-94c0-6554e7b9b8ad@github.com>

> 8186958: Need method to create pre-sized HashMap

XenoAmess has updated the pull request incrementally with one additional commit since the last revision:

  java.xml.crypto's usage downgrade grammar to 1.8

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7928/files
  - new: https://git.openjdk.java.net/jdk/pull/7928/files/71b7dba3..95e22f25

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=21
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7928&range=20-21

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7928.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7928/head:pull/7928

PR: https://git.openjdk.java.net/jdk/pull/7928

From duke at openjdk.java.net  Thu Apr 14 21:27:18 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Thu, 14 Apr 2022 21:27:18 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v21]
In-Reply-To: <PGqk-qoYHcGMQXeez1FBLcWjDr-YdksvA0ZrUOIbgCs=.d5dcd37c-2412-44ba-9cbc-68eed4b0f5bd@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
 <PGqk-qoYHcGMQXeez1FBLcWjDr-YdksvA0ZrUOIbgCs=.d5dcd37c-2412-44ba-9cbc-68eed4b0f5bd@github.com>
Message-ID: <BUMNpoXrr1X5tXt2b-zSXqFerDZpzb8YwCyuFr92EY4=.085066d6-8201-4fda-b41a-3f9105a5656b@github.com>

On Thu, 14 Apr 2022 19:56:22 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add `@LastModified: Apr 2022` to DocumentCache
>
> src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java line 110:
> 
>> 108:                 int length = attributes.getLength();
>> 109:                 Map<String, String> namespaceMap =
>> 110:                         HashMap.newHashMap(length);
> 
> Please check these changes with @seanjmullan before integrating.

@seanjmullan 
mirror pr in https://github.com/apache/santuario-xml-security-java/pull/64
jira at https://issues.apache.org/jira/projects/SANTUARIO/issues/SANTUARIO-586?filter=reportedbyme

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From iris at openjdk.java.net  Thu Apr 14 21:42:51 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Thu, 14 Apr 2022 21:42:51 GMT
Subject: <i18n dev> RFR: 8284856: Add a test case for checking
 UnicodeScript entity numbers
In-Reply-To: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>
References: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>
Message-ID: <cTBqB4hGuP86DooFcGcyPquT9AiexA_zEc4-BaZ1Yh4=.0a01f128-b21b-45fe-b49d-1a02696f2b6a@github.com>

On Thu, 14 Apr 2022 20:52:44 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Added the test case, and eliminated the immediate hashmap value, replaced with the ordinal number of `Character.UnicodeScript.UNKNOWN`.

Nice catch in the review for 8186958.

-------------

Marked as reviewed by iris (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8253

From naoto at openjdk.java.net  Thu Apr 14 22:27:20 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Thu, 14 Apr 2022 22:27:20 GMT
Subject: <i18n dev> RFR: 8284856: Add a test case for checking
 UnicodeScript entity numbers [v2]
In-Reply-To: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>
References: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>
Message-ID: <d3rhKjCLyykV70wCEiLKufMRwAffeb5JXan6WUFlsk4=.173afeaa-1627-44bf-8bf9-eaa4f0f5dcbb@github.com>

> Added the test case, and eliminated the immediate hashmap value, replaced with the ordinal number of `Character.UnicodeScript.UNKNOWN`.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Fixed a typo

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8253/files
  - new: https://git.openjdk.java.net/jdk/pull/8253/files/31da445c..fc30fc9f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8253&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8253&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8253.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8253/head:pull/8253

PR: https://git.openjdk.java.net/jdk/pull/8253

From iris at openjdk.java.net  Thu Apr 14 23:14:41 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Thu, 14 Apr 2022 23:14:41 GMT
Subject: <i18n dev> RFR: 8284856: Add a test case for checking
 UnicodeScript entity numbers [v2]
In-Reply-To: <d3rhKjCLyykV70wCEiLKufMRwAffeb5JXan6WUFlsk4=.173afeaa-1627-44bf-8bf9-eaa4f0f5dcbb@github.com>
References: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>
 <d3rhKjCLyykV70wCEiLKufMRwAffeb5JXan6WUFlsk4=.173afeaa-1627-44bf-8bf9-eaa4f0f5dcbb@github.com>
Message-ID: <keoo_NqRl8TjKcVIcbxnC4biRHoO0KZXWQ_tMAht5mI=.487d2b0c-5fa9-4111-b80a-7c54d79e8c76@github.com>

On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Added the test case, and eliminated the immediate hashmap value, replaced with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed a typo

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8253

From smarks at openjdk.java.net  Thu Apr 14 23:31:47 2022
From: smarks at openjdk.java.net (Stuart Marks)
Date: Thu, 14 Apr 2022 23:31:47 GMT
Subject: <i18n dev> RFR: 8284856: Add a test case for checking
 UnicodeScript entity numbers [v2]
In-Reply-To: <d3rhKjCLyykV70wCEiLKufMRwAffeb5JXan6WUFlsk4=.173afeaa-1627-44bf-8bf9-eaa4f0f5dcbb@github.com>
References: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>
 <d3rhKjCLyykV70wCEiLKufMRwAffeb5JXan6WUFlsk4=.173afeaa-1627-44bf-8bf9-eaa4f0f5dcbb@github.com>
Message-ID: <3bKWF7Dn6L4APgsP_u_7cYljTGq20C_HFTgVaykWXKY=.8bcf41e0-f29f-4005-9bda-9698c920c403@github.com>

On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Added the test case, and eliminated the immediate hashmap value, replaced with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed a typo

LGTM

-------------

Marked as reviewed by smarks (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8253

From aturbanov at openjdk.java.net  Fri Apr 15 08:14:39 2022
From: aturbanov at openjdk.java.net (Andrey Turbanov)
Date: Fri, 15 Apr 2022 08:14:39 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base
In-Reply-To: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
Message-ID: <Fl18aNG5VRm9cKAGACvisoCc6A_t-Vgy03p-ldK9_2A=.3cd9f6fc-4e51-4916-836b-6bcf4088bda1@github.com>

On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

Shouldn't copyright year be updated too?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

From prappo at openjdk.java.net  Fri Apr 15 11:46:44 2022
From: prappo at openjdk.java.net (Pavel Rappo)
Date: Fri, 15 Apr 2022 11:46:44 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base
In-Reply-To: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
Message-ID: <8o1t-S3XFlxllM9gYtF5EHcMmby8_6RQxCxi86ndGfY=.b9d04f24-288e-4095-bdcb-41ea5efda852@github.com>

On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

src/java.base/share/legal/icu.md line 310:

> 308:  #  list of conditions and the following disclaimer. Redistributions in binary
> 309:  #  form must reproduce the above copyright notice, this list of conditions and
> 310:  #  the following disclaimer in the documentation and/or the materials

I think it's a mistype of "other", not "the"; look at the similar text below.

src/java.base/share/native/libzip/zlib/ChangeLog line 99:

> 97: - Simplify contrib/vstudio/vc10 with 'd' suffix
> 98: - Add TOP support to win32/Makefile.msc
> 99: - Support i686 and amd64 assembler builds in CMakeLists.txt

Similarly to Naoto's comment on ICU: shouldn't we leave this as is? If anybody cares enough about this typo, they could file a bug against zlib directly.

src/java.base/share/native/libzip/zlib/README line 67:

> 65:   when compiled with cc.
> 66: 
> 67: - On Digital Unix 4.0D (formerly OSF/1) on AlphaServer, the cc option -std1 is

Same as above.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

From prappo at openjdk.java.net  Fri Apr 15 11:50:39 2022
From: prappo at openjdk.java.net (Pavel Rappo)
Date: Fri, 15 Apr 2022 11:50:39 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base
In-Reply-To: <8o1t-S3XFlxllM9gYtF5EHcMmby8_6RQxCxi86ndGfY=.b9d04f24-288e-4095-bdcb-41ea5efda852@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
 <8o1t-S3XFlxllM9gYtF5EHcMmby8_6RQxCxi86ndGfY=.b9d04f24-288e-4095-bdcb-41ea5efda852@github.com>
Message-ID: <qUHWJF3Dg8BdfFfvpseQQyeet39jHLOidPEfGmOD-Kg=.9a5211d7-adc3-4229-bfe4-d42e9fc4ac99@github.com>

On Fri, 15 Apr 2022 11:25:09 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
>> 
>> (Due to false positives this can unfortunately not be run automatically) 
>> 
>> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
>> 
>> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..
>
> src/java.base/share/legal/icu.md line 310:
> 
>> 308:  #  list of conditions and the following disclaimer. Redistributions in binary
>> 309:  #  form must reproduce the above copyright notice, this list of conditions and
>> 310:  #  the following disclaimer in the documentation and/or the materials
> 
> I think it's a mistype of "other", not "the"; look at the similar text below.

Should be addressed on the ICU side.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

From alanb at openjdk.java.net  Fri Apr 15 13:09:39 2022
From: alanb at openjdk.java.net (Alan Bateman)
Date: Fri, 15 Apr 2022 13:09:39 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base
In-Reply-To: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
Message-ID: <Xs8LwVblb5dZlApSM44w0k4HSyrobuaS5Zl-RNJwyvw=.923a6fc4-edbc-4ecf-9726-cecd4e1edfaf@github.com>

On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

I skimmed through the changes to src/java.base and they look okay except for the changes to 3rd party code that I think should be dropped from this patch.

src/java.base/share/native/libzip/zlib/inftrees.h line 65:

> 63:    1444, which is the sum of 852 for literal/length codes and 592 for distance
> 64:    codes.  These values were found by exhaustive searches using the program
> 65:    examples/enough.c found in the zlib distribution.  The arguments to that

This is 3rd party code so should be dropped from the patch as we want as few changes to this code has possible.

src/java.base/windows/native/libnio/ch/wepoll.c line 894:

> 892:      * error code when the once-callback returns FALSE. We return -1 here to
> 893:      * indicate that global initialization failed; the failing init function is
> 894:      * responsible for setting `errno` and calling `SetLastError()`. */

This is also 3rd party code so should be dropped from this patch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

From mullan at openjdk.java.net  Fri Apr 15 18:12:51 2022
From: mullan at openjdk.java.net (Sean Mullan)
Date: Fri, 15 Apr 2022 18:12:51 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base
In-Reply-To: <4jUVElIYYvhwM9scNvI_4D6tfp5rcnuvSl5Pz969IqI=.29be0aa3-4db2-479c-8c44-71c299409f4b@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
 <4jUVElIYYvhwM9scNvI_4D6tfp5rcnuvSl5Pz969IqI=.29be0aa3-4db2-479c-8c44-71c299409f4b@github.com>
Message-ID: <Hnxzc6MuUa2NQnC_5GhyuBC74GrmBvUj7cygTZ4KDSA=.7dcb4e13-e5e9-4341-a799-8e5adc4d1cfe@github.com>

On Thu, 14 Apr 2022 20:16:21 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
>> 
>> (Due to false positives this can unfortunately not be run automatically) 
>> 
>> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
>> 
>> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..
>
> src/java.base/share/classes/sun/security/provider/certpath/AdjacencyList.java line 128:
> 
>> 126:         // Each time this method is called, we're examining a new list
>> 127:         // from the global list. So, we have to start by getting the list
>> 128:         // that contains the set of Vertices we're considering.
> 
> The class being affected is a Vertex, so either change to vertices, or leave as is...

Agree, suggest changing it to "vertices".

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

From naoto at openjdk.java.net  Fri Apr 15 18:47:53 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Fri, 15 Apr 2022 18:47:53 GMT
Subject: <i18n dev> RFR: 8279185: Support for IsoFields in
 JapaneseDate/MinguoDate/ThaiBuddhistDate [v7]
In-Reply-To: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
References: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
Message-ID: <DAln8lPtjwxh9fev8Uos8tRfH9r9DY3-wZGs_WtRDMk=.a280b9d7-0536-44ff-9baa-c3f0a6badbb4@github.com>

> Supporting `IsoFields` temporal fields in chronologies that are similar to ISO chronology. Corresponding CSR has also been drafted.

Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:

 - Revert to use the default method
 - Merge branch 'master' into JDK-8279185
 - Removed unnecessary package names
 - Modified class desc of `IsoFields`
 - abstract class -> top level interface
 - interface -> abstract class
 - Merge branch 'master' into JDK-8279185
 - Removed the method
 - Merge branch 'master' into JDK-8279185
 - Changed to use a type to determine ISO based or not
 - ... and 5 more: https://git.openjdk.java.net/jdk/compare/0cddf702...82339ec6

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7683/files
  - new: https://git.openjdk.java.net/jdk/pull/7683/files/474dc85a..82339ec6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=05-06

  Stats: 13771 lines in 299 files changed: 10278 ins; 2309 del; 1184 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7683.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7683/head:pull/7683

PR: https://git.openjdk.java.net/jdk/pull/7683

From prappo at openjdk.java.net  Fri Apr 15 19:42:09 2022
From: prappo at openjdk.java.net (Pavel Rappo)
Date: Fri, 15 Apr 2022 19:42:09 GMT
Subject: <i18n dev> RFR: 8284922: Fix some doc-comment issues on methods
 with package access in JDK API
Message-ID: <KYuQmkyHDRdn-vlsci2tIlvVuoaVpJuxofzrbFUnZMs=.dffa2eb1-3fbc-4c89-a596-fe7b67707d4b@github.com>

People rarely include JDK elements with package access in a javadoc run. That is why bugs in those elements' doc comments tend to remain unnoticed.

There are many more bugs in the doc comments of the JDK elements with the package access than are addressed by this PR; I only included the simplest ones.

-------------

Commit messages:
 - Update copyright years
 - Initial commit

Changes: https://git.openjdk.java.net/jdk/pull/8267/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8267&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284922
  Stats: 6 lines in 3 files changed: 1 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8267.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8267/head:pull/8267

PR: https://git.openjdk.java.net/jdk/pull/8267

From darcy at openjdk.java.net  Fri Apr 15 19:47:34 2022
From: darcy at openjdk.java.net (Joe Darcy)
Date: Fri, 15 Apr 2022 19:47:34 GMT
Subject: <i18n dev> RFR: 8284922: Fix some doc-comment issues on methods
 with package access in JDK API
In-Reply-To: <KYuQmkyHDRdn-vlsci2tIlvVuoaVpJuxofzrbFUnZMs=.dffa2eb1-3fbc-4c89-a596-fe7b67707d4b@github.com>
References: <KYuQmkyHDRdn-vlsci2tIlvVuoaVpJuxofzrbFUnZMs=.dffa2eb1-3fbc-4c89-a596-fe7b67707d4b@github.com>
Message-ID: <BRy0rm6KZs3QsMaTksGoTOjqJAtTbjc5XKZD8yPv9fs=.401ac88b-bce6-43ad-95e0-7ab1db72736f@github.com>

On Fri, 15 Apr 2022 19:34:33 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> People rarely include JDK elements with package access in a javadoc run. That is why bugs in those elements' doc comments tend to remain unnoticed.
> 
> There are many more bugs in the doc comments of the JDK elements with the package access than are addressed by this PR; I only included the simplest ones.

Looks fine.

-------------

Marked as reviewed by darcy (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8267

From iris at openjdk.java.net  Fri Apr 15 19:57:50 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Fri, 15 Apr 2022 19:57:50 GMT
Subject: <i18n dev> RFR: 8284922: Fix some doc-comment issues on methods
 with package access in JDK API
In-Reply-To: <KYuQmkyHDRdn-vlsci2tIlvVuoaVpJuxofzrbFUnZMs=.dffa2eb1-3fbc-4c89-a596-fe7b67707d4b@github.com>
References: <KYuQmkyHDRdn-vlsci2tIlvVuoaVpJuxofzrbFUnZMs=.dffa2eb1-3fbc-4c89-a596-fe7b67707d4b@github.com>
Message-ID: <lKhHpzSjedjhYmHBIiwgWVS0HiKAY0huczIMJa32b1A=.d8b729f4-38ef-4db8-8b59-4e308a5875aa@github.com>

On Fri, 15 Apr 2022 19:34:33 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> People rarely include JDK elements with package access in a javadoc run. That is why bugs in those elements' doc comments tend to remain unnoticed.
> 
> There are many more bugs in the doc comments of the JDK elements with the package access than are addressed by this PR; I only included the simplest ones.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8267

From bpb at openjdk.java.net  Fri Apr 15 20:13:40 2022
From: bpb at openjdk.java.net (Brian Burkhalter)
Date: Fri, 15 Apr 2022 20:13:40 GMT
Subject: <i18n dev> RFR: 8284922: Fix some doc-comment issues on methods
 with package access in JDK API
In-Reply-To: <KYuQmkyHDRdn-vlsci2tIlvVuoaVpJuxofzrbFUnZMs=.dffa2eb1-3fbc-4c89-a596-fe7b67707d4b@github.com>
References: <KYuQmkyHDRdn-vlsci2tIlvVuoaVpJuxofzrbFUnZMs=.dffa2eb1-3fbc-4c89-a596-fe7b67707d4b@github.com>
Message-ID: <uP2JLV4BTMMJqJ0R2utOcUMpsDsHlWIRYNASM97ZStY=.f428e1b4-73be-4eba-92bb-cbd2ea9f17e8@github.com>

On Fri, 15 Apr 2022 19:34:33 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> People rarely include JDK elements with package access in a javadoc run. That is why bugs in those elements' doc comments tend to remain unnoticed.
> 
> There are many more bugs in the doc comments of the JDK elements with the package access than are addressed by this PR; I only included the simplest ones.

Marked as reviewed by bpb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8267

From duke at openjdk.java.net  Sat Apr 16 10:26:42 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Sat, 16 Apr 2022 10:26:42 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v22]
In-Reply-To: <8BqTTnIZwmWPePWhmjea15skxDmEexP5ugH8H2PawtI=.79a6387d-4a4d-4867-94c0-6554e7b9b8ad@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <8BqTTnIZwmWPePWhmjea15skxDmEexP5ugH8H2PawtI=.79a6387d-4a4d-4867-94c0-6554e7b9b8ad@github.com>
Message-ID: <Su-FDxO6tnvIGblNU6zite1n8kmMFNq7-Ixkmq4ZBG0=.42ddebc1-ac7d-46a2-8979-35f5936f864c@github.com>

On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   java.xml.crypto's usage downgrade grammar to 1.8

So is there any other things we should do before calling bot to integrate?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From smarks at openjdk.java.net  Mon Apr 18 16:09:45 2022
From: smarks at openjdk.java.net (Stuart Marks)
Date: Mon, 18 Apr 2022 16:09:45 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v21]
In-Reply-To: <aNyUSJzlvcSuVVEJD89DyIy5SBa1gL7esaf3ZpuVpmQ=.98e6b339-c853-4a88-84e3-6c245a979a0f@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
 <qly5zkZEVyG6oOE3o_bbZUfJDmQJ-kGRDnIJCsbINBs=.685798e4-cd91-496c-aa1c-a9b68f75cd21@github.com>
 <aNyUSJzlvcSuVVEJD89DyIy5SBa1gL7esaf3ZpuVpmQ=.98e6b339-c853-4a88-84e3-6c245a979a0f@github.com>
Message-ID: <tFJ3b5yCpDPXua1sHEg_xM5CrDwtxJWKswdYhI4yXlA=.313e5ee7-2951-44f2-a507-5435a9c4110c@github.com>

On Thu, 14 Apr 2022 20:16:38 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>>> Are the changes necessary for this part?
>> 
>> @seanjmullan no, they are just performance refinement.
>> 
>> If you really that wanna 100% sync ,
>> 
>> I can use the old 1.8 api to migrate that part, and make a mirror pr to that part of https://github.com/apache/santuario-xml-security-java
>> 
>> Is this solution acceptable then?
>
>> > Are the changes necessary for this part?
>> 
>> @seanjmullan no, they are just performance refinement.
>> 
>> If you really that wanna 100% sync ,
>> 
>> I can use the old 1.8 api to migrate that part, and make a mirror pr to that part of https://github.com/apache/santuario-xml-security-java
>> 
>> Is this solution acceptable then?
> 
> Yes, that would be preferred. Thanks!

I'd like to see a confirmation from @seanjmullan to make sure the issues with Santuario are resolved satisfactorily. Other than that I think it's pretty well covered. I've already run these changes through our internal test system and they look fine. I'll do a final recheck and let you know.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From mullan at openjdk.java.net  Mon Apr 18 16:44:35 2022
From: mullan at openjdk.java.net (Sean Mullan)
Date: Mon, 18 Apr 2022 16:44:35 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v21]
In-Reply-To: <aNyUSJzlvcSuVVEJD89DyIy5SBa1gL7esaf3ZpuVpmQ=.98e6b339-c853-4a88-84e3-6c245a979a0f@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <MfeVybsMaSvlclmeqgHD4I1wxhjyDBX-VcGYHgB0k9k=.f64012af-fe8e-4314-a30a-ed6badbaca13@github.com>
 <qly5zkZEVyG6oOE3o_bbZUfJDmQJ-kGRDnIJCsbINBs=.685798e4-cd91-496c-aa1c-a9b68f75cd21@github.com>
 <aNyUSJzlvcSuVVEJD89DyIy5SBa1gL7esaf3ZpuVpmQ=.98e6b339-c853-4a88-84e3-6c245a979a0f@github.com>
Message-ID: <EyXOY3fxlb41YZzKvAKXBs3bXvXU6DIkRYxaL1RCSXM=.d040f608-8306-4157-a6a0-3d65c10725e3@github.com>

On Thu, 14 Apr 2022 20:16:38 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>>> Are the changes necessary for this part?
>> 
>> @seanjmullan no, they are just performance refinement.
>> 
>> If you really that wanna 100% sync ,
>> 
>> I can use the old 1.8 api to migrate that part, and make a mirror pr to that part of https://github.com/apache/santuario-xml-security-java
>> 
>> Is this solution acceptable then?
>
>> > Are the changes necessary for this part?
>> 
>> @seanjmullan no, they are just performance refinement.
>> 
>> If you really that wanna 100% sync ,
>> 
>> I can use the old 1.8 api to migrate that part, and make a mirror pr to that part of https://github.com/apache/santuario-xml-security-java
>> 
>> Is this solution acceptable then?
> 
> Yes, that would be preferred. Thanks!

> I'd like to see a confirmation from @seanjmullan to make sure the issues with Santuario are resolved satisfactorily. Other than that I think it's pretty well covered. I've already run these changes through our internal test system and they look fine. I'll do a final recheck and let you know.

I am fine with this being integrated. @XenoAmess already [submitted a PR to the Santuario Project](https://github.com/apache/santuario-xml-security-java/pull/64) using the existing `HashMap` constructor which I have approved. So the code will be in sync the next time we upgrade the JDK to a newer version of Santuario.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From prappo at openjdk.java.net  Mon Apr 18 17:39:45 2022
From: prappo at openjdk.java.net (Pavel Rappo)
Date: Mon, 18 Apr 2022 17:39:45 GMT
Subject: <i18n dev> Integrated: 8284922: Fix some doc-comment issues on
 methods with package access in JDK API
In-Reply-To: <KYuQmkyHDRdn-vlsci2tIlvVuoaVpJuxofzrbFUnZMs=.dffa2eb1-3fbc-4c89-a596-fe7b67707d4b@github.com>
References: <KYuQmkyHDRdn-vlsci2tIlvVuoaVpJuxofzrbFUnZMs=.dffa2eb1-3fbc-4c89-a596-fe7b67707d4b@github.com>
Message-ID: <lMEDfge05evUAzdCbWlPYtE9yOdGi6Y4PNHR-Kq98oU=.2a2d28b5-f4f6-4749-93cf-11dd54cbf970@github.com>

On Fri, 15 Apr 2022 19:34:33 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> People rarely include JDK elements with package access in a javadoc run. That is why bugs in those elements' doc comments tend to remain unnoticed.
> 
> There are many more bugs in the doc comments of the JDK elements with the package access than are addressed by this PR; I only included the simplest ones.

This pull request has now been integrated.

Changeset: d3d71ea2
Author:    Pavel Rappo <prappo at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/d3d71ea289b7525d3f5c5057d995776be9a0796a
Stats:     6 lines in 3 files changed: 1 ins; 0 del; 5 mod

8284922: Fix some doc-comment issues on methods with package access in JDK API

Reviewed-by: darcy, iris, bpb

-------------

PR: https://git.openjdk.java.net/jdk/pull/8267

From smarks at openjdk.java.net  Mon Apr 18 22:37:36 2022
From: smarks at openjdk.java.net (Stuart Marks)
Date: Mon, 18 Apr 2022 22:37:36 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v22]
In-Reply-To: <8BqTTnIZwmWPePWhmjea15skxDmEexP5ugH8H2PawtI=.79a6387d-4a4d-4867-94c0-6554e7b9b8ad@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <8BqTTnIZwmWPePWhmjea15skxDmEexP5ugH8H2PawtI=.79a6387d-4a4d-4867-94c0-6554e7b9b8ad@github.com>
Message-ID: <FMJxnq_vpsnhfQ17SucDCfYvoXbmSt61zTQKt13AArY=.54c3ea4a-25be-4858-84ef-54822251c9a8@github.com>

On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   java.xml.crypto's usage downgrade grammar to 1.8

Marked as reviewed by smarks (Reviewer).

OK, go ahead and integrate!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From smarks at openjdk.java.net  Tue Apr 19 00:07:57 2022
From: smarks at openjdk.java.net (Stuart Marks)
Date: Tue, 19 Apr 2022 00:07:57 GMT
Subject: <i18n dev> RFR: 8186958: Need method to create pre-sized
 HashMap [v22]
In-Reply-To: <8BqTTnIZwmWPePWhmjea15skxDmEexP5ugH8H2PawtI=.79a6387d-4a4d-4867-94c0-6554e7b9b8ad@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
 <8BqTTnIZwmWPePWhmjea15skxDmEexP5ugH8H2PawtI=.79a6387d-4a4d-4867-94c0-6554e7b9b8ad@github.com>
Message-ID: <_Chw5faR5IlUHqflJ7FT4npMIOh0ECjpCQdDH4cE0D8=.bb789c23-043a-4515-8c39-0f940b514711@github.com>

On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
> 
>   java.xml.crypto's usage downgrade grammar to 1.8

I've also written a release note for this change. Please review.

https://bugs.openjdk.java.net/browse/JDK-8284975

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From duke at openjdk.java.net  Tue Apr 19 00:07:58 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Tue, 19 Apr 2022 00:07:58 GMT
Subject: <i18n dev> Integrated: 8186958: Need method to create pre-sized
 HashMap
In-Reply-To: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
References: <b1auRA11Xb5Xj8Eu7Px5vr0sxJcNFKQi1pI7u80locI=.1298ae4e-e1ed-4f45-9c60-d016447b1c4a@github.com>
Message-ID: <bukTGFJeLVL8jfUnsTK62koP8mbOJOkS_6HzxMWKa9g=.f8f10ead-3842-4be1-9b6f-4ec83baf98f5@github.com>

On Wed, 23 Mar 2022 18:41:59 GMT, XenoAmess <duke at openjdk.java.net> wrote:

> 8186958: Need method to create pre-sized HashMap

This pull request has now been integrated.

Changeset: 87faa85c
Author:    XenoAmess <xenoamess at gmail.com>
Committer: Stuart Marks <smarks at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/87faa85c59e94d66c3c61d997eacdd2dbe5a1772
Stats:     212 lines in 30 files changed: 139 ins; 4 del; 69 mod

8186958: Need method to create pre-sized HashMap

Reviewed-by: chegar, naoto, joehw, lancea, wetmore, smarks

-------------

PR: https://git.openjdk.java.net/jdk/pull/7928

From duke at openjdk.java.net  Tue Apr 19 00:08:29 2022
From: duke at openjdk.java.net (openjdk-notifier[bot])
Date: Tue, 19 Apr 2022 00:08:29 GMT
Subject: <i18n dev> RFR: 8284856: Add a test case for checking
 UnicodeScript entity numbers [v2]
In-Reply-To: <d3rhKjCLyykV70wCEiLKufMRwAffeb5JXan6WUFlsk4=.173afeaa-1627-44bf-8bf9-eaa4f0f5dcbb@github.com>
References: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>
 <d3rhKjCLyykV70wCEiLKufMRwAffeb5JXan6WUFlsk4=.173afeaa-1627-44bf-8bf9-eaa4f0f5dcbb@github.com>
Message-ID: <oQji-qCgskcE4Z8W99kOA9qeAC4vGS_JxraYnI0kOf4=.372f1168-b9fd-4dc9-8d88-4d7be2b4a68d@github.com>

On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Added the test case, and eliminated the immediate hashmap value, replaced with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed a typo

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:


git checkout fix_8186958
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

-------------

PR: https://git.openjdk.java.net/jdk/pull/8253

From naoto at openjdk.java.net  Tue Apr 19 03:35:06 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Tue, 19 Apr 2022 03:35:06 GMT
Subject: <i18n dev> RFR: 8284856: Add a test case for checking
 UnicodeScript entity numbers [v3]
In-Reply-To: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>
References: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>
Message-ID: <p8CaiZEpIBqplsGaGrbFpjYnOBLTI9F7WL-evWLxil8=.86ff5f30-d22c-45fa-9779-c9b2f8017d66@github.com>

> Added the test case, and eliminated the immediate hashmap value, replaced with the ordinal number of `Character.UnicodeScript.UNKNOWN`.

Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:

 - Merge branch 'master' into JDK-8284856
 - Fixed a typo
 - 8284856: Add a test case for checking UnicodeScript entity numbers
 - add `@LastModified: Apr 2022` to DocumentCache
 - revert changes on ProcessEnvironment
 - fix usage in XSAttributeChecker
 - update LastModified
 - Copyright latest year to 2022
 - revert changes in:
   src/java.desktop
   src/java.management
   src/jdk.internal.vm.ci
   src/jdk.jfr
   src/jdk.management.jfr
   src/jdk.management
   src/utils/IdealGraphVisualizer
 - Add apiNote to appropriate constructors of HM, LHM, and WHM.
 - ... and 19 more: https://git.openjdk.java.net/jdk/compare/145dfed0...2a5f3f72

-------------

Changes: https://git.openjdk.java.net/jdk/pull/8253/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8253&range=02
  Stats: 13 lines in 2 files changed: 8 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8253.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8253/head:pull/8253

PR: https://git.openjdk.java.net/jdk/pull/8253

From rriggs at openjdk.java.net  Tue Apr 19 14:38:35 2022
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Tue, 19 Apr 2022 14:38:35 GMT
Subject: <i18n dev> RFR: 8279185: Support for IsoFields in
 JapaneseDate/MinguoDate/ThaiBuddhistDate [v7]
In-Reply-To: <DAln8lPtjwxh9fev8Uos8tRfH9r9DY3-wZGs_WtRDMk=.a280b9d7-0536-44ff-9baa-c3f0a6badbb4@github.com>
References: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
 <DAln8lPtjwxh9fev8Uos8tRfH9r9DY3-wZGs_WtRDMk=.a280b9d7-0536-44ff-9baa-c3f0a6badbb4@github.com>
Message-ID: <yN9hTZ2LCFp66kZwZqOjaYwQy5w9H6WSMVFbNaDuol4=.edb2ca7e-daba-4453-b8e0-df3c782be0f2@github.com>

On Fri, 15 Apr 2022 18:47:53 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Supporting `IsoFields` temporal fields in chronologies that are similar to ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
> 
>  - Revert to use the default method
>  - Merge branch 'master' into JDK-8279185
>  - Removed unnecessary package names
>  - Modified class desc of `IsoFields`
>  - abstract class -> top level interface
>  - interface -> abstract class
>  - Merge branch 'master' into JDK-8279185
>  - Removed the method
>  - Merge branch 'master' into JDK-8279185
>  - Changed to use a type to determine ISO based or not
>  - ... and 5 more: https://git.openjdk.java.net/jdk/compare/5ee1a816...82339ec6

src/java.base/share/classes/java/time/chrono/Chronology.java line 794:

> 792:      * @since 19
> 793:      */
> 794:     default boolean isIsoBased() {

Can the description be more specific.  Each of the chronologies mentioned
say they have the same number of months, the number of days in each month, and day-of-year and leap years are the same as ISO. The week-based fields in IsoFields also depend ISO defined concepts.

Perhaps it should say that this method should return true only if all of the fields of IsoFields are supported for the chronology.

The chronology names could be links and omit the @see tags, including ISOChronology.

In the @return add ", otherwise return {@code false}."

src/java.base/share/classes/java/time/temporal/IsoFields.java line 600:

> 598:             if (!isIsoBased(temporal)) {
> 599:                 throw new DateTimeException("Resolve requires ISO based chronology: " +
> 600:                         Chronology.from(temporal));

The name change doesn't add much, I'd leave both `ensureIso` and `isIso` method names unchanged.

src/java.base/share/classes/java/time/temporal/IsoFields.java line 739:

> 737: 
> 738:     static boolean isIsoBased(TemporalAccessor temporal) {
> 739:         return Chronology.from(temporal).isIsoBased();

Can this method be private static?

Also, move the `ensureIso` method to be next to `isIso`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7683

From rriggs at openjdk.java.net  Tue Apr 19 14:38:37 2022
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Tue, 19 Apr 2022 14:38:37 GMT
Subject: <i18n dev> RFR: 8279185: Support for IsoFields in
 JapaneseDate/MinguoDate/ThaiBuddhistDate [v4]
In-Reply-To: <ucKaEUGnoyUsBcAcaFACas08nOBCiORubc440zNEmsQ=.786716c6-8173-4b91-9218-c518c4b6870e@github.com>
References: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
 <xU_V8M12iPdF1pfq8otYMUBsFo4AImj1lzlBeq5UzGk=.61281911-a2cc-422f-b0e3-bacdcdcf4ef9@github.com>
 <7sYLKTu76eFlmU46Pp6qmZENqYF1yUqvdgAsnVsrIQw=.9b5b2f51-ee65-4ec1-b515-e5d01ae1fca4@github.com>
 <ucKaEUGnoyUsBcAcaFACas08nOBCiORubc440zNEmsQ=.786716c6-8173-4b91-9218-c518c4b6870e@github.com>
Message-ID: <YwL-76hACDXfoEhsR_alWPmZQ7ME7ZcZjFcKhw573jU=.98710694-6b98-41eb-84e4-dc1a1cc12dce@github.com>

On Mon, 7 Mar 2022 18:47:17 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> src/java.base/share/classes/java/time/chrono/IsoChronology.java line 689:
>> 
>>> 687:      */
>>> 688:     @Override
>>> 689:     public boolean isIsoBased() {
>> 
>> Is this meant to be 'default'?  The CSR indicated adding default methods.
>
> The `default` method has been added to `java.time.chrono.Chronology` interface. This is its overridden method implemented in `IsoChronology` concrete class.

To make navigation easier, change the @code references to be @links and include the IsoField name.

I don't think the @implspec is needed, its redundant with @return.

Apply similar changes to the other ISO chronologies javadoc.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7683

From naoto at openjdk.java.net  Tue Apr 19 15:54:26 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Tue, 19 Apr 2022 15:54:26 GMT
Subject: <i18n dev> Integrated: 8284856: Add a test case for checking
 UnicodeScript entity numbers
In-Reply-To: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>
References: <6uXfswjoFsuQ3suJyGNGYDMpdjGtDrsqvx0-SkcWg6I=.ae99fa14-a12e-48b5-b413-28d08184004f@github.com>
Message-ID: <Gtx5LiUIMised8eSGkD1Vf1-ECj22PQe8U9d58F48rI=.dd1e1c5e-53d5-4f95-b13f-9bfdfe6f4672@github.com>

On Thu, 14 Apr 2022 20:52:44 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Added the test case, and eliminated the immediate hashmap value, replaced with the ordinal number of `Character.UnicodeScript.UNKNOWN`.

This pull request has now been integrated.

Changeset: eb9c457b
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/eb9c457b4141f2d253be14cbbad844bc4ba8c48d
Stats:     13 lines in 2 files changed: 8 ins; 0 del; 5 mod

8284856: Add a test case for checking UnicodeScript entity numbers

Reviewed-by: iris, smarks

-------------

PR: https://git.openjdk.java.net/jdk/pull/8253

From ihse at openjdk.java.net  Tue Apr 19 16:23:02 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Tue, 19 Apr 2022 16:23:02 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base [v2]
In-Reply-To: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
Message-ID: <Vcb9tZcABlUGgWXhs9LrcoItBXL8S-l3Il_sHdcRVAU=.5f044dba-5ff4-45a0-b43b-a00a601ca770@github.com>

> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

  Revert changes to 3rd party code

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8250/files
  - new: https://git.openjdk.java.net/jdk/pull/8250/files/5e3a01c6..31baf0a3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8250&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8250&range=00-01

  Stats: 15 lines in 11 files changed: 0 ins; 0 del; 15 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8250.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8250/head:pull/8250

PR: https://git.openjdk.java.net/jdk/pull/8250

From ihse at openjdk.java.net  Tue Apr 19 16:24:43 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Tue, 19 Apr 2022 16:24:43 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base [v3]
In-Reply-To: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
Message-ID: <9c-dgwrotD5LE8w0H6RyhSbq4LRitonmI12tk7XyqO8=.aa61daf8-c124-4deb-9040-fbfbc9ffa9cf@github.com>

> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

  Vertices -> vertices

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8250/files
  - new: https://git.openjdk.java.net/jdk/pull/8250/files/31baf0a3..2b029279

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8250&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8250&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8250.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8250/head:pull/8250

PR: https://git.openjdk.java.net/jdk/pull/8250

From naoto at openjdk.java.net  Tue Apr 19 16:47:26 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Tue, 19 Apr 2022 16:47:26 GMT
Subject: <i18n dev> RFR: 8279185: Support for IsoFields in
 JapaneseDate/MinguoDate/ThaiBuddhistDate [v8]
In-Reply-To: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
References: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
Message-ID: <wsuuWbphkLntR88wrJMYFKQtwkDhfyLAsnioE5ThTp0=.20db51a2-e706-4fed-815b-6d3b4fd16ad4@github.com>

> Supporting `IsoFields` temporal fields in chronologies that are similar to ISO chronology. Corresponding CSR has also been drafted.

Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:

 - Revert to use the default method
 - Removed unnecessary package names
 - Modified class desc of `IsoFields`
 - abstract class -> top level interface
 - interface -> abstract class
 - Removed the method
 - Changed to use a type to determine ISO based or not
 - Renamed the new method
 - Addresses review comments
 - copyright year fix
 - ... and 1 more: https://git.openjdk.java.net/jdk/compare/583eba4e...c3f15f6a

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7683/files
  - new: https://git.openjdk.java.net/jdk/pull/7683/files/82339ec6..c3f15f6a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=06-07

  Stats: 1815 lines in 155 files changed: 1085 ins; 236 del; 494 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7683.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7683/head:pull/7683

PR: https://git.openjdk.java.net/jdk/pull/7683

From ihse at openjdk.java.net  Tue Apr 19 16:50:14 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Tue, 19 Apr 2022 16:50:14 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base [v3]
In-Reply-To: <9c-dgwrotD5LE8w0H6RyhSbq4LRitonmI12tk7XyqO8=.aa61daf8-c124-4deb-9040-fbfbc9ffa9cf@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
 <9c-dgwrotD5LE8w0H6RyhSbq4LRitonmI12tk7XyqO8=.aa61daf8-c124-4deb-9040-fbfbc9ffa9cf@github.com>
Message-ID: <VZLeM9LxQdH1sx6qfIlAgaCcavfUnksS_UZ5QIJPxAo=.a35fbc4e-15ab-4ee2-8903-80b118511f8e@github.com>

On Tue, 19 Apr 2022 16:24:43 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
>> 
>> (Due to false positives this can unfortunately not be run automatically) 
>> 
>> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
>> 
>> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Vertices -> vertices

It's a bit annoying that 3rd party code is not more distinctly handled in the JDK source. :( I reverted the code pointed out by reviewers, but then later found the ASM code as well.

If I feel really motivated (or bored) I might try to submit PRs with these fixes upstream. Or not.

Everybody happy now?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

From ihse at openjdk.java.net  Tue Apr 19 16:50:12 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Tue, 19 Apr 2022 16:50:12 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base [v4]
In-Reply-To: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
Message-ID: <BF_leLMnF5aw5eceFt3XOLER1ntmKM0638PpSaMMrQY=.0d23d48d-4c2a-4fc7-b9f7-cf1e8f638db9@github.com>

> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:

 - Update Oracle copyrights
 - Also revert changes in ASM (3rd party code)

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8250/files
  - new: https://git.openjdk.java.net/jdk/pull/8250/files/2b029279..a3f75247

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8250&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8250&range=02-03

  Stats: 134 lines in 133 files changed: 0 ins; 0 del; 134 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8250.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8250/head:pull/8250

PR: https://git.openjdk.java.net/jdk/pull/8250

From lancea at openjdk.java.net  Tue Apr 19 17:01:23 2022
From: lancea at openjdk.java.net (Lance Andersen)
Date: Tue, 19 Apr 2022 17:01:23 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base [v4]
In-Reply-To: <BF_leLMnF5aw5eceFt3XOLER1ntmKM0638PpSaMMrQY=.0d23d48d-4c2a-4fc7-b9f7-cf1e8f638db9@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
 <BF_leLMnF5aw5eceFt3XOLER1ntmKM0638PpSaMMrQY=.0d23d48d-4c2a-4fc7-b9f7-cf1e8f638db9@github.com>
Message-ID: <1d8I8AuoQkCXZ8ITDlZS6b_i1JgDD6uS8zsSf_zZvpk=.02aead18-e100-4892-9ddb-d8d6d918625a@github.com>

On Tue, 19 Apr 2022 16:50:12 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
>> 
>> (Due to false positives this can unfortunately not be run automatically) 
>> 
>> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
>> 
>> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update Oracle copyrights
>  - Also revert changes in ASM (3rd party code)

Marked as reviewed by lancea (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

From naoto at openjdk.java.net  Tue Apr 19 17:43:21 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Tue, 19 Apr 2022 17:43:21 GMT
Subject: <i18n dev> RFR: 8279185: Support for IsoFields in
 JapaneseDate/MinguoDate/ThaiBuddhistDate [v9]
In-Reply-To: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
References: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
Message-ID: <pxwE71FCKS0jDXc_ovvsX3pyZwdU2yPDQU3mHizjcBA=.45e4dfd9-6d9a-42a5-8fbf-53cd587c49c6@github.com>

> Supporting `IsoFields` temporal fields in chronologies that are similar to ISO chronology. Corresponding CSR has also been drafted.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Addressing review comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7683/files
  - new: https://git.openjdk.java.net/jdk/pull/7683/files/c3f15f6a..45edbc3b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=08
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=07-08

  Stats: 50 lines in 6 files changed: 18 ins; 7 del; 25 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7683.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7683/head:pull/7683

PR: https://git.openjdk.java.net/jdk/pull/7683

From rriggs at openjdk.java.net  Tue Apr 19 19:07:34 2022
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Tue, 19 Apr 2022 19:07:34 GMT
Subject: <i18n dev> RFR: 8279185: Support for IsoFields in
 JapaneseDate/MinguoDate/ThaiBuddhistDate [v9]
In-Reply-To: <pxwE71FCKS0jDXc_ovvsX3pyZwdU2yPDQU3mHizjcBA=.45e4dfd9-6d9a-42a5-8fbf-53cd587c49c6@github.com>
References: <say6mMDUOOv-IQTvLHni19D2OP6BlZ24dR9DKgPeX78=.a25e6d0f-e026-4ee7-bf8b-0e5421812e2d@github.com>
 <pxwE71FCKS0jDXc_ovvsX3pyZwdU2yPDQU3mHizjcBA=.45e4dfd9-6d9a-42a5-8fbf-53cd587c49c6@github.com>
Message-ID: <oOffW4JCqcN47r1B0CmVK_XcQquOZKICU30YlLInCwY=.4e66822d-87cb-47a3-971d-fe2e29de2392@github.com>

On Tue, 19 Apr 2022 17:43:21 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Supporting `IsoFields` temporal fields in chronologies that are similar to ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressing review comments

Looks good, thanks

-------------

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7683

From mullan at openjdk.java.net  Tue Apr 19 19:15:33 2022
From: mullan at openjdk.java.net (Sean Mullan)
Date: Tue, 19 Apr 2022 19:15:33 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base [v4]
In-Reply-To: <BF_leLMnF5aw5eceFt3XOLER1ntmKM0638PpSaMMrQY=.0d23d48d-4c2a-4fc7-b9f7-cf1e8f638db9@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
 <BF_leLMnF5aw5eceFt3XOLER1ntmKM0638PpSaMMrQY=.0d23d48d-4c2a-4fc7-b9f7-cf1e8f638db9@github.com>
Message-ID: <ws6xp6IpvqsEvHsuTxlIi7HBHSp18pdWcGBSfE5G2a8=.ae0fb47b-d6a2-4f34-b4da-33f5a6925ce4@github.com>

On Tue, 19 Apr 2022 16:50:12 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
>> 
>> (Due to false positives this can unfortunately not be run automatically) 
>> 
>> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
>> 
>> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update Oracle copyrights
>  - Also revert changes in ASM (3rd party code)

Marked as reviewed by mullan (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

From naoto at openjdk.java.net  Tue Apr 19 19:43:24 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Tue, 19 Apr 2022 19:43:24 GMT
Subject: <i18n dev> RFR: 8284893: Fix typos in java.base [v4]
In-Reply-To: <BF_leLMnF5aw5eceFt3XOLER1ntmKM0638PpSaMMrQY=.0d23d48d-4c2a-4fc7-b9f7-cf1e8f638db9@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
 <BF_leLMnF5aw5eceFt3XOLER1ntmKM0638PpSaMMrQY=.0d23d48d-4c2a-4fc7-b9f7-cf1e8f638db9@github.com>
Message-ID: <YlYGbM2Yy8gpyHsdfRFYy2Iet4cmGc2UhNDxkmOmv0o=.0b32c7d7-3789-434c-80a8-fbdc8d52bbe9@github.com>

On Tue, 19 Apr 2022 16:50:12 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
>> 
>> (Due to false positives this can unfortunately not be run automatically) 
>> 
>> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
>> 
>> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update Oracle copyrights
>  - Also revert changes in ASM (3rd party code)

Marked as reviewed by naoto (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

From ihse at openjdk.java.net  Tue Apr 19 20:11:29 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Tue, 19 Apr 2022 20:11:29 GMT
Subject: <i18n dev> Integrated: 8284893: Fix typos in java.base
In-Reply-To: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
References: <en-CTn2xaGql3Qc4wttWq-LFXBE7dSnUYRxIBuNYXCg=.c78ae2c6-453a-403e-bde7-e02e50c148b2@github.com>
Message-ID: <1JP1QqXE1B7A6L1N5N8p82g_xrIWs1lr8qSVV-QPzA0=.06021c8b-0602-4bd7-a69f-fc9b1af22832@github.com>

On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

This pull request has now been integrated.

Changeset: fb469fb8
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/fb469fb894ed84686f9fec5787ac99eb535fdd18
Stats:     369 lines in 162 files changed: 0 ins; 0 del; 369 mod

8284893: Fix typos in java.base

Reviewed-by: iris, wetmore, lancea, mullan, naoto

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

From kevinw at openjdk.java.net  Wed Apr 20 14:04:32 2022
From: kevinw at openjdk.java.net (Kevin Walls)
Date: Wed, 20 Apr 2022 14:04:32 GMT
Subject: <i18n dev> RFR: 8284853: Fix various 'expected' typo [v2]
In-Reply-To: <b2zhGMW2RG0f8ZRDrnI8nSfW-JeuZx8-DNvJaGRXu4g=.dcfbe0fb-6f7c-4f46-8fbe-458a42f7ca21@github.com>
References: <32dmK9fPqvYhxpZmTgVYMYCfJNLZ3bI8ROg9UqUIRHc=.25e61d1a-6f26-4ea4-b5d3-3c6a80ce08dd@github.com>
 <bisAVGnhNiqxb9oNb7lsqrjIO84qDRUeqyfw7p7jSME=.e2b1b6c3-fc70-4b5b-8cb2-d1987de9a7dd@github.com>
 <rNQ6IxlRdqzXlRKEfw2Hnyn7pI5_h3ydBV_grUrKfe0=.82d95656-bdd3-4607-a12d-5964ac33f53a@github.com>
 <b2zhGMW2RG0f8ZRDrnI8nSfW-JeuZx8-DNvJaGRXu4g=.dcfbe0fb-6f7c-4f46-8fbe-458a42f7ca21@github.com>
Message-ID: <eqgDmfDmNbkCo4R5oiilfxQxAs12V1ZP453zph4DSms=.1595dc28-ee07-43e1-b36d-4e2bc0fb3e36@github.com>

On Thu, 14 Apr 2022 18:04:16 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> I found [yet another typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948) ...

I didn't think "JVMInvokeMethodSlack" was a typo.  I think it's the idea of "slack space" meaning leftover space.  We require a certain amount of this space.  We need some slack on the stack, in order to invoke.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8231

From naoto at openjdk.java.net  Wed Apr 20 23:57:58 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Wed, 20 Apr 2022 23:57:58 GMT
Subject: <i18n dev> RFR: 8283324: CLDRConverter run time increased by 3x
Message-ID: <w0GmHnHhWosUiATXdPu8wj5XEth-K3OJMutcQYV02DI=.2ba4b67d-f35a-4c80-a947-d479d2596616@github.com>

Fixing performance regression caused by the fix to https://bugs.openjdk.java.net/browse/JDK-8176706. The fix introduced extra looping through the resource map multiple times which was not necessary. The execution time of the tool now got back on par with close to JDK18.

-------------

Commit messages:
 - 8283324: CLDRConverter run time increased by 3x

Changes: https://git.openjdk.java.net/jdk/pull/8288/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8288&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8283324
  Stats: 16 lines in 2 files changed: 10 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8288.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8288/head:pull/8288

PR: https://git.openjdk.java.net/jdk/pull/8288

From ihse at openjdk.java.net  Thu Apr 21 08:44:15 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Thu, 21 Apr 2022 08:44:15 GMT
Subject: <i18n dev> RFR: 8285306: Fix typos in java.desktop
Message-ID: <5gAPAoRiIJr6BEko1UEaMd3QeUte-snqvfc9eNU2Jgk=.a6d39dcd-0d89-4444-a890-a6c53f41245b@github.com>

I ran `codespell` on the `src/java.desktop` directory, and accepted those changes where it indeed discovered real typos.

I ignored typos in public methods and variables. Maybe they can be fixed later on without much fanfare, if they are in internal classes. Typos in exposed APIs are likely here to stay.

I will update copyright years using a script before pushing (otherwise like every second change would be a copyright update, making reviewing much harder).

The long term goal here is to make tooling support for running `codespell`. The trouble with automating this is of course all false positives. But before even trying to solve that issue, all true positives must be fixed. Hence this PR.

-------------

Commit messages:
 - Pass #2
 - Pass #1

Changes: https://git.openjdk.java.net/jdk/pull/8328/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8328&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8285306
  Stats: 1015 lines in 493 files changed: 0 ins; 0 del; 1015 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8328.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8328/head:pull/8328

PR: https://git.openjdk.java.net/jdk/pull/8328

From ihse at openjdk.java.net  Thu Apr 21 10:36:46 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Thu, 21 Apr 2022 10:36:46 GMT
Subject: <i18n dev> RFR: 8283324: CLDRConverter run time increased by 3x
In-Reply-To: <w0GmHnHhWosUiATXdPu8wj5XEth-K3OJMutcQYV02DI=.2ba4b67d-f35a-4c80-a947-d479d2596616@github.com>
References: <w0GmHnHhWosUiATXdPu8wj5XEth-K3OJMutcQYV02DI=.2ba4b67d-f35a-4c80-a947-d479d2596616@github.com>
Message-ID: <Um7d96LmbS4Llxrjg2PkkqxrvlmOt9jSawDxjrlmCE0=.68639819-d94a-4233-b685-899a5ca8c398@github.com>

On Mon, 18 Apr 2022 23:16:18 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing performance regression caused by the fix to https://bugs.openjdk.java.net/browse/JDK-8176706. The fix introduced extra looping through the resource map multiple times which was not necessary. The execution time of the tool now got back on par with close to JDK18.

Thanks for fixing this!

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8288

From ihse at openjdk.java.net  Thu Apr 21 11:42:00 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Thu, 21 Apr 2022 11:42:00 GMT
Subject: <i18n dev> RFR: 8285370: Fix typo in jdk.charsets
Message-ID: <HJSWE1JAMroG1xguxYbiChefBXUEkXcAWYw-amNng3Y=.fb14fcbb-3edf-4cb2-9266-c2f0466f6033@github.com>

`codespell` could just find a single typo in the files covered by the i18n alias. Just fixing the typo did not make the comment more readable, so I rewrote it slightly.

-------------

Commit messages:
 - Fix typo in charsets

Changes: https://git.openjdk.java.net/jdk/pull/8335/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8335&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8285370
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8335.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8335/head:pull/8335

PR: https://git.openjdk.java.net/jdk/pull/8335

From alanb at openjdk.java.net  Thu Apr 21 11:51:25 2022
From: alanb at openjdk.java.net (Alan Bateman)
Date: Thu, 21 Apr 2022 11:51:25 GMT
Subject: <i18n dev> RFR: 8285370: Fix typo in jdk.charsets
In-Reply-To: <HJSWE1JAMroG1xguxYbiChefBXUEkXcAWYw-amNng3Y=.fb14fcbb-3edf-4cb2-9266-c2f0466f6033@github.com>
References: <HJSWE1JAMroG1xguxYbiChefBXUEkXcAWYw-amNng3Y=.fb14fcbb-3edf-4cb2-9266-c2f0466f6033@github.com>
Message-ID: <9zKEToebkKoVPw1TfgBAuNoUldTb2p9eNLTBXADwYjQ=.c09d267b-0eb4-4661-a0f3-7153f393605a@github.com>

On Thu, 21 Apr 2022 11:34:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> `codespell` could just find a single typo in the files covered by the i18n alias. Just fixing the typo did not make the comment more readable, so I rewrote it slightly.

Marked as reviewed by alanb (Reviewer).

src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM942C.java.template line 69:

> 67: 
> 68:         static {
> 69:             // the mappings that need updating are

It probably meant to say "needing" but what you have is okay.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8335

From ihse at openjdk.java.net  Thu Apr 21 12:56:30 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Thu, 21 Apr 2022 12:56:30 GMT
Subject: <i18n dev> RFR: 8285370: Fix typo in jdk.charsets
In-Reply-To: <9zKEToebkKoVPw1TfgBAuNoUldTb2p9eNLTBXADwYjQ=.c09d267b-0eb4-4661-a0f3-7153f393605a@github.com>
References: <HJSWE1JAMroG1xguxYbiChefBXUEkXcAWYw-amNng3Y=.fb14fcbb-3edf-4cb2-9266-c2f0466f6033@github.com>
 <9zKEToebkKoVPw1TfgBAuNoUldTb2p9eNLTBXADwYjQ=.c09d267b-0eb4-4661-a0f3-7153f393605a@github.com>
Message-ID: <DsAqZV7cQWnAV50aekzCqisLIfDamV1njNXzRMxeDIM=.5ebc23f1-975e-4394-8e6a-a1e8ac4e1493@github.com>

On Thu, 21 Apr 2022 11:47:30 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> `codespell` could just find a single typo in the files covered by the i18n alias. Just fixing the typo did not make the comment more readable, so I rewrote it slightly.
>
> src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM942C.java.template line 69:
> 
>> 67: 
>> 68:         static {
>> 69:             // the mappings that need updating are
> 
> It probably meant to say "needing" but what you have is okay.

That was actually my first approach, but my English intuition failed me in finding the rest of the sentence. Should it be "the mappings needing update are", "the mappings needing an update are" or "the mappings needing updates are"? Neither sounded really good. So I went by a safer route. :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/8335

From naoto at openjdk.java.net  Thu Apr 21 16:05:37 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Thu, 21 Apr 2022 16:05:37 GMT
Subject: <i18n dev> RFR: 8285370: Fix typo in jdk.charsets
In-Reply-To: <HJSWE1JAMroG1xguxYbiChefBXUEkXcAWYw-amNng3Y=.fb14fcbb-3edf-4cb2-9266-c2f0466f6033@github.com>
References: <HJSWE1JAMroG1xguxYbiChefBXUEkXcAWYw-amNng3Y=.fb14fcbb-3edf-4cb2-9266-c2f0466f6033@github.com>
Message-ID: <ZWT9Jdb7ai9xCmhlTgC7T8ldrgxkte8ZaTKzznMw3rE=.4fd3f510-94ab-4f09-a75c-4f0e8d3b3cc3@github.com>

On Thu, 21 Apr 2022 11:34:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> `codespell` could just find a single typo in the files covered by the i18n alias. Just fixing the typo did not make the comment more readable, so I rewrote it slightly.

Marked as reviewed by naoto (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8335

From naoto at openjdk.java.net  Thu Apr 21 22:27:28 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Thu, 21 Apr 2022 22:27:28 GMT
Subject: <i18n dev> Integrated: 8283324: CLDRConverter run time increased by
 3x
In-Reply-To: <w0GmHnHhWosUiATXdPu8wj5XEth-K3OJMutcQYV02DI=.2ba4b67d-f35a-4c80-a947-d479d2596616@github.com>
References: <w0GmHnHhWosUiATXdPu8wj5XEth-K3OJMutcQYV02DI=.2ba4b67d-f35a-4c80-a947-d479d2596616@github.com>
Message-ID: <TrWUQa1cyqzw83woHL7CdBKVhpwOtNVQK2fZRqe33p0=.b3767627-e361-4ed3-af83-3c31aab565f6@github.com>

On Mon, 18 Apr 2022 23:16:18 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing performance regression caused by the fix to https://bugs.openjdk.java.net/browse/JDK-8176706. The fix introduced extra looping through the resource map multiple times which was not necessary. The execution time of the tool now got back on par with close to JDK18.

This pull request has now been integrated.

Changeset: f6e9ca0c
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/f6e9ca0cbe671502b6b3b1d0f8fd86f0928f64ea
Stats:     16 lines in 2 files changed: 10 ins; 0 del; 6 mod

8283324: CLDRConverter run time increased by 3x

Reviewed-by: ihse

-------------

PR: https://git.openjdk.java.net/jdk/pull/8288

From ihse at openjdk.java.net  Fri Apr 22 14:08:36 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Fri, 22 Apr 2022 14:08:36 GMT
Subject: <i18n dev> Integrated: 8285370: Fix typo in jdk.charsets
In-Reply-To: <HJSWE1JAMroG1xguxYbiChefBXUEkXcAWYw-amNng3Y=.fb14fcbb-3edf-4cb2-9266-c2f0466f6033@github.com>
References: <HJSWE1JAMroG1xguxYbiChefBXUEkXcAWYw-amNng3Y=.fb14fcbb-3edf-4cb2-9266-c2f0466f6033@github.com>
Message-ID: <onS-SvaKIzbd8JE4DRcpfsI7TYMrCxgoj-j4KsVfOSk=.4c6a7008-c8b0-49a0-99c8-911dcd840f4f@github.com>

On Thu, 21 Apr 2022 11:34:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> `codespell` could just find a single typo in the files covered by the i18n alias. Just fixing the typo did not make the comment more readable, so I rewrote it slightly.

This pull request has now been integrated.

Changeset: 4e252cf3
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/4e252cf3c4e13e2f7c43ea4ee096473571691a01
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8285370: Fix typo in jdk.charsets

Reviewed-by: alanb, naoto

-------------

PR: https://git.openjdk.java.net/jdk/pull/8335

From naoto at openjdk.java.net  Tue Apr 26 00:40:38 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Tue, 26 Apr 2022 00:40:38 GMT
Subject: <i18n dev> RFR: 8282227: Locale information for nb is not working
 properly
Message-ID: <nc9aTrJt7qhdTHUyVtXcMdGmObgLs7-s-57ehuVWxlo=.30ec889f-ea60-4343-b756-862542ed9630@github.com>

This was caused by incorporating CLDR v39, which switched the Norwegian locale inheritance from `no` -> `nb` to `nb` ->`no` and moved the resources from `nb` to `no`, which now contradicts Java's locale fallback. Explicitly inheriting `no` from `nb` will fix the issue.

-------------

Commit messages:
 - 8282227: Locale information for nb is not working properly

Changes: https://git.openjdk.java.net/jdk/pull/8394/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8394&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8282227
  Stats: 79 lines in 2 files changed: 74 ins; 1 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8394.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8394/head:pull/8394

PR: https://git.openjdk.java.net/jdk/pull/8394

From prr at openjdk.java.net  Wed Apr 27 03:41:42 2022
From: prr at openjdk.java.net (Phil Race)
Date: Wed, 27 Apr 2022 03:41:42 GMT
Subject: <i18n dev> RFR: 8285306: Fix typos in java.desktop
In-Reply-To: <5gAPAoRiIJr6BEko1UEaMd3QeUte-snqvfc9eNU2Jgk=.a6d39dcd-0d89-4444-a890-a6c53f41245b@github.com>
References: <5gAPAoRiIJr6BEko1UEaMd3QeUte-snqvfc9eNU2Jgk=.a6d39dcd-0d89-4444-a890-a6c53f41245b@github.com>
Message-ID: <4QVTblMgjEo2KBoDGn1G67qqvHtOkdmqeU4e88o2eHU=.faf55412-6b4a-4fe4-ac84-82ee0cea2f8d@github.com>

On Thu, 21 Apr 2022 08:35:36 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `src/java.desktop` directory, and accepted those changes where it indeed discovered real typos.
> 
> I ignored typos in public methods and variables. Maybe they can be fixed later on without much fanfare, if they are in internal classes. Typos in exposed APIs are likely here to stay.
> 
> I will update copyright years using a script before pushing (otherwise like every second change would be a copyright update, making reviewing much harder).
> 
> The long term goal here is to make tooling support for running `codespell`. The trouble with automating this is of course all false positives. But before even trying to solve that issue, all true positives must be fixed. Hence this PR.

static class AquaHierarchyButtonListener implements HierarchyListener {
-        // Everytime a hierarchy is change we need to check if the button if moved on or from
+        // Every time a hierarchy is change we need to check if the button if moved on or from

change -> changed
if moved -> is moved

src/java.desktop/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java


-            // it won't be invoced if focuse is moved to a html element
+            // it won't be invoced if focus is moved to a html element

invoced -> invoked
"a html" -> "an html"

src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiOut.c
+    // $$fb 2002-04-04: It is responsibility of the application developer to

"is the"

src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_MidiOut.c

+    // $$fb 2002-04-04: It is responsibility of the application developer to

same as above

Regarding changes in gif + freetype 
diff --git a/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c b/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c

diff --git a/src/java.desktop/share/native/libfontmanager/freetypeScaler.c b/src/java.desktop/share/native/libfontmanager/freetypeScaler.c

Please exclude ALL 3rd party libraries from this PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8328

From aivanov at openjdk.java.net  Thu Apr 28 21:29:23 2022
From: aivanov at openjdk.java.net (Alexey Ivanov)
Date: Thu, 28 Apr 2022 21:29:23 GMT
Subject: <i18n dev> RFR: 8285306: Fix typos in java.desktop
In-Reply-To: <5gAPAoRiIJr6BEko1UEaMd3QeUte-snqvfc9eNU2Jgk=.a6d39dcd-0d89-4444-a890-a6c53f41245b@github.com>
References: <5gAPAoRiIJr6BEko1UEaMd3QeUte-snqvfc9eNU2Jgk=.a6d39dcd-0d89-4444-a890-a6c53f41245b@github.com>
Message-ID: <1x04_BXzoS9x2Uh3iaA-wo08JPGM6xUli_YbFbyOkFY=.248133c8-2be5-4a68-89bc-9b6f62e33fb9@github.com>

On Thu, 21 Apr 2022 08:35:36 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `src/java.desktop` directory, and accepted those changes where it indeed discovered real typos.
> 
> I ignored typos in public methods and variables. Maybe they can be fixed later on without much fanfare, if they are in internal classes. Typos in exposed APIs are likely here to stay.
> 
> I will update copyright years using a script before pushing (otherwise like every second change would be a copyright update, making reviewing much harder).
> 
> The long term goal here is to make tooling support for running `codespell`. The trouble with automating this is of course all false positives. But before even trying to solve that issue, all true positives must be fixed. Hence this PR.

Nearly 500 files are too many. Smaller chunks would be easier to review.

Some of the native code files could come from upstream libraries.

src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java line 535:

> 533: 
> 534:     static class AquaHierarchyButtonListener implements HierarchyListener {
> 535:         // Every time a hierarchy is change we need to check if the button if moved on or from

Suggestion:

        // Every time a hierarchy is changed we need to check if the button is moved on or from

Maybe even ?_the_ hierarchy?.
And probably ?_the_ toolbar? on the next line.

src/java.desktop/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java line 126:

> 124:             // see bug 8010925
> 125:             // we can't put this to handleWindowFocusEvent because
> 126:             // it won't be invoced if focus is moved to a html element

Suggestion:

            // it won't be invoked if focus is moved to an html element

src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 552:

> 550: }
> 551: 
> 552: // Orders window's children based on the current focus state

Suggestion:

// Orders window children based on the current focus state

I believe possessive is not necessary here, it's not used with inanimate objects usually.

src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 688:

> 686: }
> 687: 
> 688: // Hides/shows window's children during iconify/de-iconify operation

Suggestion:

// Hides/shows window children during iconify/de-iconify operation

src/java.desktop/macosx/native/libawt_lwawt/awt/CTextPipe.m line 320:

> 318:     acquiring transform arrays from JNI, filling buffers, or striking glyphs. All resources or memory
> 319:     acquired at a given stage, must be released in that stage. Any error that occurs (like a failed malloc)
> 320:     is to be handled in the stage it occurs in, and is to return immediately after freeing it's resources.

Suggestion:

    is to be handled in the stage it occurs in, and is to return immediately after freeing its resources.

src/java.desktop/macosx/native/libawt_lwawt/awt/QuartzSurfaceData.m line 96:

> 94:     // The colors passed have low randomness. That means we need to scramble the bits of the color
> 95:     // to produce a good hash key. After some analysis, it looks like Thomas's Wang integer hashing algorithm
> 96:     // seems a nice trade off between performance and effectiveness.

Suggestion:

    // seems a nice trade-off between performance and effectiveness.

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m line 63:

> 61:     jboolean metalSupported = JNI_FALSE;
> 62: 
> 63:     // It is guaranteed that metal supported GPU is available macOS 10.14 onwards

It sounds as if something is missing before ?macOS??
Suggestion:

    // It is guaranteed that metal supported GPU is available since macOS 10.14

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLVertexCache.m line 248:

> 246:         // we can give destination subtexturing properly but we can't
> 247:         // subtexture from system memory glyph we have. So in such
> 248:         // cases we are creating separate tile and scan the source

Suggestion:

        // cases we are creating a separate tile and scan the source

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLVertexCache.m line 250:

> 248:         // cases we are creating separate tile and scan the source
> 249:         // stride into destination using memcpy. In case of OpenGL we
> 250:         // can update source pointers, in case of D3D we ar doing memcpy.

Suggestion:

        // can update source pointers, in case of D3D we are doing memcpy.

src/java.desktop/share/classes/javax/swing/ActionPropertyChangeListener.java line 49:

> 47:  * <p>
> 48:  * WARNING WARNING WARNING WARNING WARNING WARNING:<br>
> 49:  * Do NOT create an anonymous inner class that extends this!  If you do

Suggestion:

 * Do NOT create an anonymous inner class that extends this!  If you do,

A comma will separate the condition from the result.

src/java.desktop/share/classes/javax/swing/BoxLayout.java line 503:

> 501:      * The relative axis values, PAGE_AXIS and LINE_AXIS are converted
> 502:      * to their absolute counterpart given the target's ComponentOrientation
> 503:      * value.  The absolute axes, X_AXIS and Y_AXIS are returned unmodified.

Shall we put a comma after LINE_AXIS and Y_AXIS and ?are??

src/java.desktop/share/classes/javax/swing/DefaultRowSorter.java line 1038:

> 1036:         if (!sorted || viewToModel.length == 0 ||
> 1037:                 (lastRow - firstRow) > viewToModel.length / 10) {
> 1038:             // We either weren't sorted, or to much changed, sort it all or

Suggestion:

            // We either weren't sorted, or too much changed, sort it all or

src/java.desktop/share/classes/javax/swing/GroupLayout.java line 1654:

> 1652:         /**
> 1653:          * Used to compute how the two values representing two springs
> 1654:          * will be combined.  For example, a group that laid things out

Suggestion:

         * will be combined.  For example, a group that laid out things

Not sure which one is correct. Usually the particle in a phrasal verb follows the verb is the object is a noun.

src/java.desktop/share/classes/javax/swing/JCheckBox.java line 248:

> 246: 
> 247:     /**
> 248:      * The icon for checkboxs comes from the look and feel,

Suggestion:

     * The icon for checkboxes comes from the look and feel,

src/java.desktop/share/classes/javax/swing/JLayeredPane.java line 532:

> 530:             if(curLayer == layer) {
> 531:                 layerCount++;
> 532:             /// Short circuit the counting when we have them all

Suggestion:

            /// Short-circuit the counting when we have them all

src/java.desktop/share/classes/javax/swing/JLayeredPane.java line 558:

> 556:             if(curLayer == layer) {
> 557:                 results[layerCount++] = getComponent(i);
> 558:             /// Short circuit the counting when we have them all

Suggestion:

            /// Short-circuit the counting when we have them all

src/java.desktop/share/classes/javax/swing/JMenu.java line 201:

> 199:      * Overridden to do nothing. We want JMenu to be focusable, but
> 200:      * <code>JMenuItem</code> doesn't want to be, thus we override this
> 201:      * do nothing. We don't invoke <code>setFocusable(true)</code> after

Suggestion:

     * to do nothing. We don't invoke <code>setFocusable(true)</code> after

src/java.desktop/share/classes/javax/swing/JPopupMenu.java line 335:

> 333: 
> 334:     /**
> 335:      * Returns an point which has been adjusted to take into account of the

Suggestion:

     * Returns an point which has been adjusted to take into account the

src/java.desktop/share/classes/javax/swing/JSpinner.java line 675:

> 673:             // active vs those of the JFormattedTextField. As such we
> 674:             // put disabled actions in the JFormattedTextField's actionmap.
> 675:             // A binding to a disabled action is treated as a nonexistent

Suggestion:

            // A binding to a disabled action is treated as a non-existent

The word is spelt with a hyphen in all the preceding cases (in this code review).

src/java.desktop/share/classes/javax/swing/SwingWorker.java line 262:

> 260: 
> 261:     /**
> 262:      * handler for {@code process} method.

Suggestion:

     * Handler for {@code process} method.

To be consistent in starting from a capital letter, even though it's a private field.

src/java.desktop/share/classes/javax/swing/plaf/metal/MetalRootPaneUI.java line 316:

> 314:         uninstallLayout(root);
> 315:         // We have to revalidate/repaint root if the style is JRootPane.NONE
> 316:         // only. When we needs to call revalidate/repaint with other styles

Suggestion:

        // only. When we need to call revalidate/repaint with other styles

src/java.desktop/share/classes/javax/swing/plaf/metal/MetalTheme.java line 68:

> 66: public abstract class MetalTheme {
> 67: 
> 68:     // Constants identifying the various Fonts that are Theme can support

Suggestion:

    // Constants identifying the various Fonts that a Theme can support

src/java.desktop/share/classes/javax/swing/plaf/nimbus/AbstractRegionPainter.java line 332:

> 330:             return laf.getDerivedColor(key, hOffset, sOffset, bOffset, aOffset, true);
> 331:         } else {
> 332:             // can not give a right answer as painter should not be used outside

Suggestion:

            // cannot give the right answer as painter should not be used outside

The sentence suggests there's only _one_ right answer, therefore the definite article.

src/java.desktop/share/classes/javax/swing/plaf/nimbus/SynthPainterImpl.java line 126:

> 124:         Component c = ctx.getComponent();
> 125:         boolean ltr = c.getComponentOrientation().isLeftToRight();
> 126:         // Don't RTL flip JSpliders as they handle it internally

Suggestion:

        // Don't RTL flip JSliders as they handle it internally

src/java.desktop/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html line 876:

> 874: 	used for all directions.</dd>
> 875:       <dt><a id="imagePainter.path"><samp>path</samp></a></dt>
> 876:       <dd>Path to the image. Path to the image.  If SynthLookAndFeel.load is

Suggestion:

      <dd>Path to the image.  If SynthLookAndFeel.load is

I believe the duplicate sentence can be dropped.

src/java.desktop/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html line 877:

> 875:       <dt><a id="imagePainter.path"><samp>path</samp></a></dt>
> 876:       <dd>Path to the image. Path to the image.  If SynthLookAndFeel.load is
> 877:     passed a Class this will use the Class method getResource (with with the

Suggestion:

    passed a Class this will use the Class method getResource (with the

src/java.desktop/share/classes/javax/swing/text/WrappedPlainView.java line 661:

> 659:      * This class tries to be lightweight by carrying little
> 660:      * state of it's own and sharing the state of the outer class
> 661:      * with it's sibblings.

Suggestion:

     * state of its own and sharing the state of the outer class
     * with its siblings.

src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1779:

> 1777:      * <p>
> 1778:      * The CSS parser uses the parseCssValue method to convert
> 1779:      * a string to whatever format is appropriate a given key

Suggestion:

     * a string to whatever format is appropriate for a given key

src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1781:

> 1779:      * a string to whatever format is appropriate a given key
> 1780:      * (i.e. these converters are stored in a map using the
> 1781:      * CSS.Attribute as a key and the CssValue as the value).

Suggestion:

     * CSS.Attribute as the key and the CssValue as the value).

src/java.desktop/share/classes/javax/swing/text/html/parser/TagStack.java line 39:

> 37:  * When a start tag is encountered an element is pushed onto
> 38:  * the stack, when an end tag is encountered an element is popped
> 39:  * of the stack.

Suggestion:

 * off the stack.

src/java.desktop/share/classes/javax/swing/tree/FixedHeightLayoutCache.java line 645:

> 643: 
> 644:     /**
> 645:      * Ensures that all the path components in path are expanded, accept

Suggestion:

     * Ensures that all the path components in path are expanded, except

src/java.desktop/share/classes/sun/awt/image/ImagingLib.java line 68:

> 66: 
> 67:     /**
> 68:      * Returned value indicates whether the library initialization was

Suggestion:

     * Returned value indicates whether the library initialization

src/java.desktop/share/classes/sun/awt/image/ImagingLib.java line 71:

> 69:      * succeeded.
> 70:      *
> 71:      * There could be number of reasons to failure:

Suggestion:

     * There could be a number of reasons for failure:

src/java.desktop/share/classes/sun/swing/SwingUtilities2.java line 1782:

> 1780:     /**
> 1781:      * Returns an integer from the defaults table. If {@code key} does
> 1782:      * not map to a valid {@code Integer}, or can not be converted from

Suggestion:

     * not map to a valid {@code Integer}, or cannot be converted from

src/java.desktop/share/classes/sun/swing/SwingUtilities2.java line 1795:

> 1793:      * Returns an integer from the defaults table that is appropriate
> 1794:      * for the given locale. If {@code key} does not map to a valid
> 1795:      * {@code Integer}, or can not be converted from a {@code String}

Suggestion:

     * {@code Integer}, or cannot be converted from a {@code String}

And two more below.

src/java.desktop/share/classes/sun/swing/text/TextComponentPrintable.java line 772:

> 770:                         /*
> 771:                          * we do not store the same value as previous. in our
> 772:                          * documents it is often for consequent positions to have

Looks this actually means _consecutive_ positions?

src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java line 485:

> 483:     /**
> 484:      * returns item which mapped coordinates contain
> 485:      * specified point, null of none.

Suggestion:

     * the specified point, null if none.

src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java line 944:

> 942:      * This function needs to be overridden since
> 943:      * XBaseMenuWindow has no corresponding component
> 944:      * so events can not be processed using standard means

Suggestion:

     * so events cannot be processed using standard means

src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java line 390:

> 388:     /* Implement DisposerTarget. Weak references to an Object can delay
> 389:      * its storage reclamation marginally.
> 390:      * It won't make the native resources be release any more quickly, but

Suggestion:

     * It won't make the native resources be released any more quickly, but

src/java.desktop/windows/native/libawt/windows/awt_Label.h line 62:

> 60:     /*
> 61:      * if WM_PAINT was receiving when we can not paint
> 62:      * then setup m_needPaint end when can call this function

Suggestion:

     * if WM_PAINT was received when we cannot paint
     * then setup m_needPaint and when can paint call this function

src/java.desktop/windows/native/libawt/windows/awt_PrintDialog.cpp line 57:

> 55:                 (LOWORD(wParam) == IDCANCEL))
> 56:             {
> 57:                 // If we receive on of these two notifications, the dialog

Suggestion:

                // If we receive one of these two notifications, the dialog

src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 3173:

> 3171:                 (LOWORD(wParam) == IDCANCEL))
> 3172:             {
> 3173:                 // If we receive on of these two notifications, the dialog

Suggestion:

                // If we receive one of these two notifications, the dialog

src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp line 1085:

> 1083:       // Special awt message to call Imm APIs.
> 1084:       // ImmXXXX() API must be used in the main thread.
> 1085:       // In other thread these APIs does not work correctly even if

Suggestion:

      // In other threads these APIs do not work correctly even if

src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp line 1087:

> 1085:       // In other thread these APIs does not work correctly even if
> 1086:       // it returns with no error. (This restriction is not documented)
> 1087:       // So we must use thse messages to call these APIs in main thread.

Suggestion:

      // So we must use these messages to call these APIs in main thread.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8328

From rriggs at openjdk.java.net  Fri Apr 29 17:11:43 2022
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Fri, 29 Apr 2022 17:11:43 GMT
Subject: <i18n dev> RFR: 8282227: Locale information for nb is not
 working properly
In-Reply-To: <nc9aTrJt7qhdTHUyVtXcMdGmObgLs7-s-57ehuVWxlo=.30ec889f-ea60-4343-b756-862542ed9630@github.com>
References: <nc9aTrJt7qhdTHUyVtXcMdGmObgLs7-s-57ehuVWxlo=.30ec889f-ea60-4343-b756-862542ed9630@github.com>
Message-ID: <B9scsTF_boYfhcfd-uDQ_xIGb3TRwTyGFHyTDydDAr4=.6a922d76-035b-4ece-8129-df0628cbcf38@github.com>

On Tue, 26 Apr 2022 00:32:48 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This was caused by incorporating CLDR v39, which switched the Norwegian locale inheritance from `no` -> `nb` to `nb` ->`no` and moved the resources from `nb` to `no`, which now contradicts Java's locale fallback. Explicitly inheriting `no` from `nb` will fix the issue.

LGTM

-------------

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8394

From naoto at openjdk.java.net  Fri Apr 29 17:24:41 2022
From: naoto at openjdk.java.net (Naoto Sato)
Date: Fri, 29 Apr 2022 17:24:41 GMT
Subject: <i18n dev> Integrated: 8282227: Locale information for nb is not
 working properly
In-Reply-To: <nc9aTrJt7qhdTHUyVtXcMdGmObgLs7-s-57ehuVWxlo=.30ec889f-ea60-4343-b756-862542ed9630@github.com>
References: <nc9aTrJt7qhdTHUyVtXcMdGmObgLs7-s-57ehuVWxlo=.30ec889f-ea60-4343-b756-862542ed9630@github.com>
Message-ID: <BSxhJtj_uvJuCg1I8PurJubLYA6MnGkuEM5ygW6agRw=.1c62ea68-cfbb-498d-a742-688e19a35e18@github.com>

On Tue, 26 Apr 2022 00:32:48 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This was caused by incorporating CLDR v39, which switched the Norwegian locale inheritance from `no` -> `nb` to `nb` ->`no` and moved the resources from `nb` to `no`, which now contradicts Java's locale fallback. Explicitly inheriting `no` from `nb` will fix the issue.

This pull request has now been integrated.

Changeset: 3d07b3c7
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/3d07b3c7f01b60ff4dc38f62407c212b48883dbf
Stats:     79 lines in 2 files changed: 74 ins; 1 del; 4 mod

8282227: Locale information for nb is not working properly

Reviewed-by: rriggs

-------------

PR: https://git.openjdk.java.net/jdk/pull/8394