<i18n dev> RFR: 8281317: CompactNumberFormat displays 4-digit values when rounding to a new range [v2]

Joe Wang joehw at openjdk.java.net
Tue Feb 15 23:53:08 UTC 2022


On Tue, 15 Feb 2022 22:31:28 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> src/java.base/share/classes/java/text/CompactNumberFormat.java line 595:
>> 
>>> 593:                 divisor = (Long) divisors.get(++compactDataIndex);
>>> 594:                 iPart = getIntegerPart(number, divisor);
>>> 595:             }
>> 
>> This and the few lines surrounding it were duplicated. Might be worth considering consolidation.
>
> Right. In fact, I tried to converge them but ended up not to, as there are slight differences for each number type.

Yeah, that's fine.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7412


More information about the i18n-dev mailing list