<i18n dev> RFR: 8280470: Confusing instanceof check in HijrahChronology.range

Fri Jan 21 18:05:41 UTC 2022

On Mon, 17 Jan 2022 21:02:35 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> Parameter `ChronoField field` is checked by `if (field instanceof ChronoField)`. Such check is confusing, because only one case, when this could be `false` is when `field == null`.
> But if condition is not satisfied we will get immediate NullPointerException anyway in `return field.range();`.

Marked as reviewed by dfuchs (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7118