<i18n dev> Integrated: 8289768: Clean up unused code
Daniel Jeliński
djelinski at openjdk.org
Tue Jul 12 11:34:43 UTC 2022
On Tue, 5 Jul 2022 20:19:10 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled.
>
> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>
> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
This pull request has now been integrated.
Changeset: 04c47da1
Author: Daniel Jeliński <djelinski at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/04c47da118b2870d1c7525348a2ffdf9cd1cc0a4
Stats: 98 lines in 46 files changed: 0 ins; 69 del; 29 mod
8289768: Clean up unused code
Reviewed-by: dfuchs, lancea, weijun, naoto, cjplummer, alanb, michaelm, chegar
-------------
PR: https://git.openjdk.org/jdk/pull/9383
More information about the i18n-dev
mailing list