<i18n dev> RFR: 8290300: Use standard String-joining tools where applicable [v3]

Сергей Цыпанов duke at openjdk.org
Mon Jul 18 11:17:37 UTC 2022


On Fri, 15 Jul 2022 12:25:07 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8290300: Remove unused piece of code in formatList()
>
> LGTM, however are there tests that ensure the changes are benign?

@JimLaskey changes in `WindowsPath` are covered by `PathOps`, apart from this there are 10 tests calling this method.

With `ProcessBuilder` and `Locale` it looks like the code I've changed is never executed at all for `ProcessStartEvent.isEnabled()` always return false.

For `Locale` all the call sites of `formatList()` never pass null, so the code in `if` block is never executed. I think we can delete this unused parts of the code in `Locale`, but I'm not sure about `ProcessBuilder`.

-------------

PR: https://git.openjdk.org/jdk/pull/9513


More information about the i18n-dev mailing list