<i18n dev> RFR: 8289227: Support for BCP 47 Extension T - Transformed Content [v3]

Joe Wang joehw at openjdk.org
Tue Jul 26 19:06:08 UTC 2022


On Tue, 26 Jul 2022 17:17:46 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> This PR is to propose supporting the `T` extension to the BCP 47 to which `java.util.Locale` class conforms. There are two extensions to the BCP 47, one is `Unicode Locale Extension` which has been supported since JDK7, the other is this `Transformed Content` extension. A CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
> 
>  - Modified javadoc of the transformed conent
>  - Merge branch 'master' into JDK-8289227-T-ext
>  - Removed unnecessary `contains()` check
>  - IllformedLocaleEx -> LocaleSyntaxEx
>  - SystemProperty tests
>  - Revived returning Optional
>  - Some clean-ups, including making Extension a sealed class.
>  - Bring the specialized methods back
>    Some documentation fixes
>  - Using Optional
>  - FieldSeparators()/FieldSubtag() -> Fields()
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/8de5da37...780f712e

Looks good to me.

src/java.base/share/classes/java/util/Locale.java line 265:

> 263:  * field separator (one alpha + one digit), followed by one or more subtags of the length 3 to 8,
> 264:  * each delimited by a hyphen.
> 265:  * <p>The transformed content information; namely {@code source} language tag and {@code fields}

typo ";"  (s/;/,)

-------------

Marked as reviewed by joehw (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9620


More information about the i18n-dev mailing list