<i18n dev> RFR: 8285306: Fix typos in java.desktop [v6]

Magnus Ihse Bursie ihse at openjdk.java.net
Wed Jun 15 10:45:52 UTC 2022


On Wed, 15 Jun 2022 07:27:50 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with 17 additional commits since the last revision:
>> 
>>  - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java
>>    
>>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>>  - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java
>>    
>>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>>  - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java
>>    
>>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>>  - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java
>>    
>>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>>  - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java
>>    
>>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>>  - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java
>>    
>>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>>  - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java
>>    
>>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>>  - Update src/java.desktop/share/classes/javax/swing/tree/FixedHeightLayoutCache.java
>>    
>>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>>  - Update src/java.desktop/share/classes/javax/swing/text/html/parser/TagStack.java
>>    
>>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>>  - Update src/java.desktop/share/classes/javax/swing/text/html/CSS.java
>>    
>>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>>  - ... and 7 more: https://git.openjdk.org/jdk/compare/40c585cd...98e635a5
>
> src/java.desktop/share/classes/javax/swing/JTree.java line 3320:
> 
>> 3318:                                    (parent, path.getPathComponent(counter));
>> 3319:                 parent = path.getPathComponent(counter);
>> 3320:                 if(indices[counter - 1] < 0)
> 
> let's add space after `if`

@turbanoff I'll go with @aivanov-jdk's suggestion here. Also, this is a PR created by an automation tool. I'd really prefer not to do any manual intervention, if possible, and at the very least not spelling related.

> src/java.desktop/share/classes/javax/swing/JTree.java line 3335:
> 
>> 3333:      */
>> 3334:     private TreePath getPathForIndexs(int[] indices) {
>> 3335:         if(indices == null)
> 
> please add space after `if`

Same here. Space issues are not typos.

-------------

PR: https://git.openjdk.org/jdk/pull/8328


More information about the i18n-dev mailing list