<i18n dev> RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable

Gaurav Chaudhari duke at openjdk.org
Wed Jun 29 14:38:45 UTC 2022

On Tue, 28 Jun 2022 22:15:39 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> This is a REDO of the Fix that was incompletely implemented earlier:
>> [8285838: Fix for TZ environment variable DST rules](https://github.com/openjdk/jdk/pull/8660)
>> Offset calculation now accounts all the way upto year in order to avoid cross-day miscalculations as well as to calculate always in the correct direction for offset. In situations where there may be multiple days, the excess days of offset will be shaved off by applying mod to `seconds_per_day` , which will remove the excessive days that might be included in the offset calculation for special scenarios like a leap year / February months and variances between 30 and 31 days.
>> I have tested this solution with the cases where this fix had failed last time as well, and confirmed it works:
>> _(where 7200 represents 7200 seconds -> +2 hour offset)_
>> Sample output:
>> ![image](https://user-images.githubusercontent.com/6877595/176259828-07e27901-4a3f-4949-bd8d-2f88c979685a.png)
> I just wonder we could simply call `strftime` with `%z` conversion, rather than calculating the GMT offset ourselves. Would you like to try it out?

@naotoj Thanks for letting me know, hadn't tried that function yet. At first look it seems to working exactly as needed, but I will need to parse the result into substrings to put a semi-colon between the hour and minute offset, in order to match the output required. But definitely looks much simpler in comparison ...


PR: https://git.openjdk.org/jdk/pull/9312

More information about the i18n-dev mailing list