<i18n dev> RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v4]
Naoto Sato
naoto at openjdk.java.net
Mon Mar 7 18:50:07 UTC 2022
On Mon, 7 Mar 2022 18:30:28 GMT, Joe Wang <joehw at openjdk.org> wrote:
>> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Renamed the new method
>> - Merge branch 'master' into JDK-8279185
>> - Addresses review comments
>> - copyright year fix
>> - 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate
>
> src/java.base/share/classes/java/time/chrono/IsoChronology.java line 689:
>
>> 687: */
>> 688: @Override
>> 689: public boolean isIsoBased() {
>
> Is this meant to be 'default'? The CSR indicated adding default methods.
The `default` method has been added to `java.time.chrono.Chronology` interface. This is its overridden method implemented in `IsoChronology` concrete class.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7683
More information about the i18n-dev
mailing list