<i18n dev> RFR: JDK-8282625 Formatter caches Locale/DecimalFormatSymbols poorly [v7]

[Jim Laskey]

On Tue, 8 Mar 2022 05:01:56 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Add comment about DecimalFormatSymbols being mutable objects.
>>  - Revert "Cache DecimalFormatSymbols in DecimalFormatSymbols instead of Formatter. No significant performance degradation."
>>    
>>    This reverts commit fcbf66a2fe9641d3c3349f12cc7b32d8b84c6f72.
>>  - Revert "Drop DecimalFormatSymbols.getLocale change"
>>    
>>    This reverts commit b93cdb03ec68f24f4b8851c0966bb144c30b5110.
>>  - Revert "Correct caching test"
>>    
>>    This reverts commit bf7975396aaad4ed58d053bde8f54984215eeba5.
>
> src/java.base/share/classes/java/util/Formatter.java line 2019:
> 
>> 2017:             return dfs;
>> 2018:         }
>> 2019:         // Fetch a new local instance of DecimalFormatSymbols. Note that DFS are mutatble
> 
> Thank you Jim for these comments about multi-threaded access. Looks good to me.
> One minor typo on this line - "mutatble" should have been "mutable".

Noted

-------------

PR: https://git.openjdk.java.net/jdk/pull/7703