<i18n dev> RFR: JDK-8282625 Formatter caches Locale/DecimalFormatSymbols poorly [v10]

[Jim Laskey]

On Fri, 11 Mar 2022 04:28:00 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8282625
>>  - Correct indentation
>>  - Add unit test for DecimalFormatSymbols.getLocale()
>>  - Add comment about DecimalFormatSymbols being mutable objects.
>>  - Revert "Cache DecimalFormatSymbols in DecimalFormatSymbols instead of Formatter. No significant performance degradation."
>>    
>>    This reverts commit fcbf66a2fe9641d3c3349f12cc7b32d8b84c6f72.
>>  - Revert "Drop DecimalFormatSymbols.getLocale change"
>>    
>>    This reverts commit b93cdb03ec68f24f4b8851c0966bb144c30b5110.
>>  - Revert "Correct caching test"
>>    
>>    This reverts commit bf7975396aaad4ed58d053bde8f54984215eeba5.
>>  - Correct caching test
>>  - Drop DecimalFormatSymbols.getLocale change
>>  - Cache DecimalFormatSymbols in DecimalFormatSymbols instead of Formatter. No significant performance degradation.
>>  - ... and 4 more: https://git.openjdk.java.net/jdk/compare/9cda7890...84fa1fe7
>
> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 192:
> 
>> 190: 
>> 191:     /**
>> 192:      * {@return locale used to create this instance}
> 
> Hello Jim, the opening and closing `{`, I think aren't needed for a `@return`

This is actually a feature of JavaDoc. Accessor methods that require little description (self evident) can use {@return ...} to define the description and return in one go.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7703