<i18n dev> RFR: 8283465: Character.UnicodeBlock.NUM_ENTITIES is out of date [v2]

[Stuart Marks]

On Tue, 22 Mar 2022 21:58:27 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/Character.java line 740:
>> 
>>> 738:     public static final class UnicodeBlock extends Subset {
>>> 739:         /**
>>> 740:          * 737 - the expected number of entities
>> 
>> Just a quibble about this comment... it's probably not worth repeating the actual value. But it probably is worth mentioning that the actual value should (or must) match the number of entries added to the map by constructors called from the static initializers in this class. Whenever aliases or new blocks are added, this number must be adjusted.
>
> Not a "quibble" at all.  In fact, I thought the same just after I submitted the PR that the number in the comment would be easily overlooked and got stale, which would defy this cleanup. Removed the actual number and put some explanation there.

Thanks, looks good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7909