<i18n dev> RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v21]

[Jim Laskey]

On Wed, 16 Nov 2022 15:44:55 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wrong line separator
>
> src/java.base/share/classes/java/lang/template/TemplateProcessor.java line 31:
> 
>> 29: 
>> 30: /**
>> 31:  * This interface simplifies declaration of
> 
> Suggestion:
> 
>  * This interface simplifies the declaration of

Changing.

> src/java.base/share/classes/java/lang/template/TemplateProcessor.java line 44:
> 
>> 42:  * }
>> 43:  *
>> 44:  * @param <R>  Processor's process result type.
> 
> Some code block/link missing?

`};` is in the snippet. `}` is the end of the snippet.

> src/java.base/share/classes/java/lang/template/ValidatingProcessor.java line 28:
> 
>> 26: package java.lang.template;
>> 27: 
>> 28: import java.util.Objects;
> 
> Watch out for unused imports

Went through and did the import clean up en masse.

-------------

PR: https://git.openjdk.org/jdk/pull/10889