<i18n dev> RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v21]

[Jim Laskey]

On Wed, 16 Nov 2022 16:07:51 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wrong line separator
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ArgumentAttr.java line 77:
> 
>> 75: import static com.sun.tools.javac.code.TypeTag.METHOD;
>> 76: import static com.sun.tools.javac.code.TypeTag.VOID;
>> 77: import com.sun.tools.javac.code.Types;
> 
> This change is probably unnecessary?

Changing

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java line 231:
> 
>> 229:         JCVariableDecl valuesVar;
>> 230:         List<JCVariableDecl> fields;
>> 231:         MethodInfo interpolateMethod;
> 
> Some of the field here appear to be unused? Probably `stringTemplateClass`, `fragmentsVar`, `valuesVar`, `fields`, `interpolateMethod`.

Cleaned up earlier.

> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java line 1716:
> 
>> 1714:                     t = stringTemplate(t);
>> 1715:                     typeArgs = null;
>> 1716:                     // Uncomment to not allow follow on DOT
> 
> What is the reason for this comment? Seems like it should be removed?

Not sure. Note to future self that if we allow relaxed use of processors, this is where to make change. Open to alternate methodology.

-------------

PR: https://git.openjdk.org/jdk/pull/10889