<i18n dev> RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v21]

[Jim Laskey]

On Wed, 16 Nov 2022 19:16:26 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wrong line separator
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java line 700:
> 
>> 698:             S.setPrevToken(stringToken);
>> 699:         }
>> 700:         JCExpression t = F.at(pos).StringTemplate(processor, fragments, expressions);
> 
> Should there be something like `toP(...)` around the `F.at...`, to set the end position of the tree?

Added.

> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java line 1715:
> 
>> 1713:                     }
>> 1714:                     t = stringTemplate(t);
>> 1715:                     typeArgs = null;
> 
> `typeArgs = null;` unnecessary?

Will remove the section for now and make a note elsewhere.

-------------

PR: https://git.openjdk.org/jdk/pull/10889