<i18n dev> RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v5]

Justin Lu duke at openjdk.org
Tue Oct 4 18:46:14 UTC 2022


On Tue, 4 Oct 2022 18:20:26 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove temp var
>>   
>>   Remove temp variables and replace with method chaining when possible
>
> src/java.base/share/classes/java/text/DigitList.java line 161:
> 
>> 159:     public final double getDouble() {
>> 160:         if (count == 0) {
>> 161:             return 0.0;
> 
> The doc for this method is incorrect:
> 
> * If (count == 0) this throws a NumberFormatException, which
> * mimics Long.parseLong().

I believe that relates to https://bugs.openjdk.org/browse/JDK-8170389

Which I can address in a separate PR

-------------

PR: https://git.openjdk.org/jdk/pull/10475


More information about the i18n-dev mailing list