<i18n dev> RFR: 8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher [v2]

Justin Lu duke at openjdk.org
Tue Oct 18 17:05:11 UTC 2022


On Mon, 17 Oct 2022 22:22:30 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use data provider, drop exception
>
> test/jdk/java/util/Formatter/BasicTestLauncher.java line 99:
> 
>> 97:         }catch(RuntimeException err){
>> 98:             throw new RuntimeException(String.format("$$$ %s: Test(s) failed or TestJVM did not build correctly." +
>> 99:                     " Check stderr output from diagnostics summary above%n",  err.getMessage()));
> 
> Do you need to catch the RuntimeException and then throw a new RuntimeException?  I think you might want to consider reworking this

Thank you Lance, I dropped the catch altogether as there is already enough info in the test log output

-------------

PR: https://git.openjdk.org/jdk/pull/10715


More information about the i18n-dev mailing list