<i18n dev> RFR: 8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher [v2]

Justin Lu duke at openjdk.org
Tue Oct 18 18:09:19 UTC 2022


On Tue, 18 Oct 2022 17:49:01 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> test/jdk/java/util/Formatter/Basic.java line 93:
>> 
>>> 91:                                        + fail + " failure(s), first", first);
>>> 92:         else
>>> 93:             System.out.printf("all " + pass + " tests passed");
>> 
>> This line is missing a newline; add a \n, or use println().
>
> I would suggest rewriting as System.out.printf("all %s tests passed%n", pass);
> 
> You could make a similar change to line 90 using String.format as done in the line 98 which was deleted

I dropped the new line since when the output comes out of the sub process log

Without the newline it looks like 
[ ... ] 

vs

[...
]

-------------

PR: https://git.openjdk.org/jdk/pull/10715


More information about the i18n-dev mailing list