<i18n dev> RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v2]
Jim Laskey
jlaskey at openjdk.org
Fri Oct 28 18:01:30 UTC 2022
On Fri, 28 Oct 2022 16:09:51 GMT, j3graham <duke at openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move StringConcatItem to FormatConcatItem
>
> src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 365:
>
>> 363: Objects.requireNonNull(sts, "sts must not be null");
>> 364: if (sts.length == 0) {
>> 365: StringTemplate.of("");
>
> Missing return?
Yep - updated
> src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 367:
>
>> 365: StringTemplate.of("");
>> 366: } else if (sts.length == 1) {
>> 367: return sts[0];
>
> Check for null?
Added null checks
-------------
PR: https://git.openjdk.org/jdk/pull/10889
More information about the i18n-dev
mailing list