<i18n dev> RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java [v2]

Naoto Sato naoto at openjdk.org
Mon Oct 31 18:40:10 UTC 2022

On Mon, 31 Oct 2022 17:50:47 GMT, Justin Lu <duke at openjdk.org> wrote:

>> Issue: Duplication of methods between Basic*.java test classes, due to auto generation by genBasic.sh
>> Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java. Toggled -nel flag for generation script (genBasic.sh) to remove excessive white space. Moved a previous direct change to BasicDateTime.java into the template.
>> Note: Main files to look at are Basic.java and Basic-X.java.template, as the rest are a reflection of the auto generation
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>   Remove old ids hack, has no usage

Marked as reviewed by naoto (Reviewer).


PR: https://git.openjdk.org/jdk/pull/10910

More information about the i18n-dev mailing list