<i18n dev> RFR: 8285306: Fix typos in java.desktop [v8]
Magnus Ihse Bursie
ihse at openjdk.org
Tue Sep 13 21:26:53 UTC 2022
On Tue, 13 Sep 2022 19:48:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 46 commits:
>>
>> - Merge branch 'master' into typos-in-java.desktop
>> - Revert changes in libjpeg
>> - Revert changes in libfreetype
>> - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java
>>
>> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>> - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java
>>
>> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>> - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java
>>
>> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>> - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java
>>
>> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>> - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java
>>
>> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>> - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java
>>
>> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>> - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java
>>
>> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>> - ... and 36 more: https://git.openjdk.org/jdk/compare/6a1e98cb...1ce28314
>
> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.m line 87:
>
>> 85: J2dTraceLn4(J2D_TRACE_VERBOSE,
>> 86: "MTLLayer.blitTexture: uninitialized (mtlc=%p, javaLayer=%p, buffer=%p, device=%p)", self.ctx,
>> 87: self.javaLayer, self.buffer, ctx.device);
>
> Is this an intended change? Or does it come from a merge?
>
> May I suggest wrapping the line after the format string before `self.ctx`? It would make it easier to read.
This is from the merge. The only difference wrt to current code is "devide" => "device". I can change wrapping if you request it, but I'd prefer to only fix typos.
-------------
PR: https://git.openjdk.org/jdk/pull/8328
More information about the i18n-dev
mailing list