<i18n dev> RFR: 8272687: Replace StringBuffer with StringBuilder in RuleBasedCollator
Brent Christian
bchristi at openjdk.org
Mon Sep 26 22:17:41 UTC 2022
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu <duke at openjdk.org> wrote:
> Problem: Unnecessary instances of StringBuffer + .toString()
>
> Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when possible
>
> Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion, but removing that instance requires changing the RuleBasedCollationKey constructor's second parameter type from String to StringBuilder
>
> automated testing run passed cleanly
Looks good!
-------------
Marked as reviewed by bchristi (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10432
More information about the i18n-dev
mailing list