<i18n dev> Integrated: 8272687: Replace StringBuffer with StringBuilder in RuleBasedCollator
Justin Lu
duke at openjdk.org
Mon Sep 26 22:34:40 UTC 2022
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu <duke at openjdk.org> wrote:
> Problem: Unnecessary instances of StringBuffer + .toString()
>
> Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when possible
>
> Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion, but removing that instance requires changing the RuleBasedCollationKey constructor's second parameter type from String to StringBuilder
>
> automated testing run passed cleanly
This pull request has now been integrated.
Changeset: 43eff2b3
Author: Justin Lu <justin.lu at oracle.com>
Committer: Brent Christian <bchristi at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/43eff2b309e2ef275bdd5adf196da81d4e23f535
Stats: 10 lines in 2 files changed: 0 ins; 0 del; 10 mod
8272687: Replace StringBuffer with StringBuilder in RuleBasedCollator
Reviewed-by: lancea, naoto, bchristi, bpb
-------------
PR: https://git.openjdk.org/jdk/pull/10432
More information about the i18n-dev
mailing list