<i18n dev> RFR: 8304911: Use OperatingSystem enum in some modules

[Alan Bateman]

On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> With the addition of `jdk.internal.util.OperatingSystem` references to the system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
>  - java.prefs,
>  - java.security.jgss,
>  - java.smartcardio,
>  - jdk.charsets,
>  - jdk.net,
>  - jdk.zipfs

src/jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java line 406:

> 404:                 case MACOS -> newInstance("jdk.net.MacOSXSocketOptions");
> 405:                 case WINDOWS -> newInstance("jdk.net.WindowsSocketOptions");
> 406:                 default -> new PlatformSocketOptions();

For another issue, but I assume this could be refactored to not need PlatformSocketOptions, in which case the mapping of OS name to implementation class would go away.

src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 2882:

> 2880:                     elenNTFS = 36;           // total 36 bytes
> 2881:                 } else {                     // Extended Timestamp otherwise
> 2882:                     elenEXTT = 9;            // only mtime in cen

It might be better to drop ZipFileSystem from this patch and instead create a bug to re-examine this code. I would have expected it use NFTS when the timestamp is beyond the range of an extended timestamp.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13335#discussion_r1158209156
PR Review Comment: https://git.openjdk.org/jdk/pull/13335#discussion_r1158206710