<i18n dev> RFR: 8304911: Use OperatingSystem enum in some modules [v2]

ExE Boss duke at openjdk.org
Wed Apr 5 14:45:15 UTC 2023


On Wed, 5 Apr 2023 14:32:03 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> With the addition of `jdk.internal.util.OperatingSystem` references to the system property `os.name` can be replaced.
>> This PR exports jdk.internal.util to:
>>  - java.prefs,
>>  - java.security.jgss,
>>  - java.smartcardio,
>>  - jdk.charsets,
>>  - jdk.net,
>>  - jdk.zipfs
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert chanes to ZipFileSystem to defer refactoring.
>   Reformatted expression to match switch expression formatting.

src/java.security.jgss/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java line 103:

> 101:                                         "/usr/lib/sasl2/libgssapiv2.2.so",
> 102:                                 };
> 103:                                 case WINDOWS -> new String[]{ // Full path needed, DLL is in jre/bin

Suggestion:

                                case WINDOWS -> new String[]{
                                        // Full path needed, DLL is in jre/bin

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13335#discussion_r1158620967


More information about the i18n-dev mailing list