<i18n dev> RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v54]

[Jim Laskey]

On Fri, 7 Apr 2023 09:32:59 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Recommended changes
>
> src/java.base/share/classes/java/lang/StringConcatHelper.java line 364:
> 
>> 362:         try {
>> 363:             return value.prepend(indexCoder, buf);
>> 364:         } catch (Throwable ex) {
> 
> This should rethrow errors (such as `OutOfMemoryError`):
> Suggestion:
> 
>         } catch (Error err) {
>             throw err;
>         } catch (Throwable ex) {

Changing

> src/java.base/share/classes/java/lang/runtime/StringTemplateImpl.java line 100:
> 
>> 98:         try {
>> 99:             return (List<Object>)valuesMH.invokeExact(this);
>> 100:         } catch (RuntimeException | OutOfMemoryError ex) {
> 
> Suggestion:
> 
>         } catch (RuntimeException | Error ex) {

Changing

> src/java.base/share/classes/java/lang/runtime/StringTemplateImpl.java line 111:
> 
>> 109:         try {
>> 110:             return (String) interpolateMH.invokeExact(this);
>> 111:         } catch (RuntimeException | OutOfMemoryError ex) {
> 
> Suggestion:
> 
>         } catch (RuntimeException | Error ex) {

Changing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1161119626
PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1161119647
PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1161119669