<i18n dev> RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v56]

[Jim Laskey]

On Wed, 12 Apr 2023 15:09:50 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change MAX_INDY_CONCAT_ARG_SLOTS to be updatable.
>
> src/java.base/share/classes/java/lang/runtime/TemplateRuntime.java line 109:
> 
>> 107:      * @param lookup          method lookup
>> 108:      * @param name            method name
>> 109:      * @param type            method type
> 
> Maybe mention that the name is ignored, and the type must be convertible from `(String[], Object[])StringTemplate`? The specification says "fragments list" and "values list", which are more accurately described as arrays.
> 
> Also, does "large" string template mean there are more than 250~ fragments that the bootstrap method arguments can't fit, or does it mean dynamic number of fragments? Might be worth mentioning that as well.

Updating comments

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165418717