<i18n dev> RFR: 4737887: (cal) API: Calendar methods taking field should document exceptions [v2]

Justin Lu jlu at openjdk.org
Fri Apr 14 21:30:25 UTC 2023


> Many Calendar methods that take in a field parameter should document that they throw an ArrayIndexOutOfBoundsException if field is not between 0 and `Calendar.FIELD_COUNT`.
> 
> This PR adds a clause to the class description to make the above apparent.
> 
> `Calendar.Roll(int, int)`, `Calendar.roll(int, boolean)`, and `Calendar.add(int, int)` should all be documented that they throw an `IllegalArgumentException` if any calendar fields have out-of-range values in non-lenient mode or if field is
> `Calendar.ZONE_OFFSET`, `Calendar.DST_OFFSET`, or unknown.

Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

  Copyright year

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13234/files
  - new: https://git.openjdk.org/jdk/pull/13234/files/bd6b6e60..9932c204

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13234&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13234&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/13234.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13234/head:pull/13234

PR: https://git.openjdk.org/jdk/pull/13234


More information about the i18n-dev mailing list