<i18n dev> RFR: 8306711: Improve diagnosis of `IntlTest` framework [v3]

Justin Lu jlu at openjdk.org
Wed Apr 26 00:09:54 UTC 2023


On Tue, 25 Apr 2023 23:58:59 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review changes to the IntlTest (test framework) class. 
>> 
>> These changes include
>> - Logging the actual exception + stack trace. Previously, the test framework would throw `InvocationTargetException` but hide the actual underlying exception of the failing test unless the test class was ran with -nothrow.
>> - Sorting the tests, ensuring for any given run, the tests are ran in the same order. (In [JDK-8305853](https://bugs.openjdk.org/browse/JDK-8305853) it was discovered that on Windows, the test framework would execute tests in a random order each time).
>> - Improving output.
>
> Justin Lu has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Move getErrorCount() back to original spot
>  - Regardles of nothrow, final result should be logged, cache, move method back

test/jdk/java/text/testlib/IntlTest.java line 108:

> 106:             }
> 107:         }
> 108:         if (exitCode) {

@naotoj Since I got rid of `writeTestResult(errorCount);`

I will just have this block execute regardless of `nothrow`. All tests should now write the final result.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13655#discussion_r1177171469


More information about the i18n-dev mailing list