<i18n dev> RFR: JDK-8314611: Provide more explicative error message parsing Currencies [v2]

[Naoto Sato]

On Mon, 28 Aug 2023 21:36:34 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which updates some exceptions in j.util.Currency to have an explicit error message (as opposed to nothing).
>> 
>> The exceptions are thrown when the ISO 4217/3166 currency/country codes are in an invalid form, or do not exist.
>
> Justin Lu has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - 4217->3166
>  - Include the private table methods

Looks good. Minor suggestion to the exception message.

src/java.base/share/classes/java/util/Currency.java line 347:

> 345:                 if (ocEntry == null) {
> 346:                     throw new IllegalArgumentException("The input currency code" +
> 347:                             " is not a supported ISO 4217 code");

I think "valid" is more appropriate than "supported." Applies to other locations as well.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15458#pullrequestreview-1599192074
PR Review Comment: https://git.openjdk.org/jdk/pull/15458#discussion_r1308004193