<i18n dev> RFR: 8315097: Rename createJavaProcessBuilder [v2]
Roger Riggs
rriggs at openjdk.org
Tue Aug 29 16:48:15 UTC 2023
On Tue, 29 Aug 2023 14:06:01 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>>
>> copyright
>
> I don't think this is the best change across so many files.
> It gives a very ugly name to a common test function and affects a very large number of tests.
> @RogerRiggs If it is only the name you want changed, maybe you can offer a better name?
@lkorinth
Sorry for the too short comment; I wanted to make sure it wasn't integrated before I could look at it more closely.
Neither the bug report or the PR describe the problem and its ramifications, only the solution.
Can you elaborate on the conditions that lead to this. (and include them in the bug report).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15452#issuecomment-1697803842
More information about the i18n-dev
mailing list