<i18n dev> RFR: 8315097: Rename createJavaProcessBuilder [v3]
Mark Sheppard
msheppar at openjdk.org
Thu Aug 31 10:11:02 UTC 2023
On Thu, 31 Aug 2023 05:45:27 GMT, David Holmes <dholmes at openjdk.org> wrote:
> > So you could create a single createJavaProcessBuilder with add an additional parameter boolean addTestOpts e.g.
> > createJavaProcessBuilder(List command, boolean addTestOpts) { ... }
>
> @msheppar that is actually where we started, and it was then split into two differently named methods to "make it clear" which one included the test opts without having to remember the name of the parameter that the true/false argument was bound to.
cheers David thanks for the clarification on background
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15452#issuecomment-1700749844
More information about the i18n-dev
mailing list