<i18n dev> RFR: 6230751: [Fmt-Ch] Recursive MessageFormats in ChoiceFormats ignore indicated subformats [v2]

Justin Lu jlu at openjdk.org
Fri Dec 1 22:42:18 UTC 2023


On Fri, 1 Dec 2023 22:16:33 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> src/java.base/share/classes/java/text/MessageFormat.java line 299:
>> 
>>> 297:  * the string produced by a {@code ChoiceFormat} in {@code MessageFormat} is
>>> 298:  * treated as special; occurrences of '{' are used to indicate subformats, and
>>> 299:  * cause recursion. A limitation to this behavior is that, if a {@code MessageFormat}
>> 
>> @naotoj Please let me know if the added limitations wording reads clearly to you. I would rather not have a whole dedicated code example to explain a _limitation_, but if needed for better understanding, I can add one.
>
> Do you mean `{@code MessageFormat}{@code FormatElement}`?
> Also, I would rather remove "A limitation to this behavior is that," as readers would know the following explanation explains a limitation.

Right, no need for `{@code MessageFormat}` as it's already implied. Also removed "_A limitation to this behavior is that_" as suggested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16891#discussion_r1412631550


More information about the i18n-dev mailing list