<i18n dev> RFR: 8320919: Clarify Locale related system properties [v3]

[Naoto Sato]

On Mon, 11 Dec 2023 22:42:56 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> src/java.base/share/classes/java/util/Locale.java line 270:
> 
>> 268:  * <ol>
>> 269:  * <li>The locale-related system properties listed below are established from the
>> 270:  * host environment. Some system properties (except for {@code user.language}) may
> 
> IIUC, should it be _all_ system properties, not _some_ if we are defining the single exception?

The host-dependent part of the code always generates at least the language, thus it was excluded.

> src/java.base/share/classes/java/util/Locale.java line 301:
> 
>> 299:  * is unparsable, it is ignored. The overriding values of other properties are not
>> 300:  * checked for syntax or validity and are used directly in the default Locale.
>> 301:  * (Typically, system property values can be provided using the {@code -D} command-line
> 
> Do these last two sentences need to be enclosed in a parentheses? It seems pretty important as it is the main way to override the properties via command-line.

The `-D` command-line option is not a part of the Java SE specification but an allowed behavior, so it may not be a normative description here.

> src/java.base/share/classes/java/util/Locale.java line 307:
> 
>> 305:  * "foobarbaz".)
>> 306:  * </li>
>> 307:  * <li>The default {@code Locale} instance is constructed from these system
> 
> Might read better as "... is constructed from the values of these system properties."

Thanks. modified

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17065#discussion_r1423228012
PR Review Comment: https://git.openjdk.org/jdk/pull/17065#discussion_r1423228059
PR Review Comment: https://git.openjdk.org/jdk/pull/17065#discussion_r1423228078