<i18n dev> RFR: 8320919: Clarify Locale related system properties [v3]
Stuart Marks
smarks at openjdk.org
Wed Dec 13 05:36:43 UTC 2023
On Mon, 11 Dec 2023 23:20:25 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> This is a doc change to clarify what the `Default Locale` is, and how it is established during the system startup using the system properties. Those locale-related system properties have existed since the early days of Java, but have never been publicly documented before. It is also the intention of this PR to clarify those system properties and how they are overridden. A corresponding CSR has been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments
Looks good, with a couple small wording changes.
src/java.base/share/classes/java/util/Locale.java line 318:
> 316: * If the default Locale is changed with {@link #setDefault(Locale)}, the corresponding
> 317: * system properties are not altered. It is not recommended that applications read
> 318: * these system properties and parse/interpret them as their values may be out of sync.
Small wordsmithing: I would say "out of date" instead.
src/java.base/share/classes/java/util/Locale.java line 324:
> 322: * and set by {@link #setDefault(Category, Locale)}. Construction of these category
> 323: * specific default Locales are determined by the corresponding system properties,
> 324: * which consist of the base system properties as listed above, appended by either
"appended" => "suffixed"
-------------
Marked as reviewed by smarks (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17065#pullrequestreview-1778870505
PR Review Comment: https://git.openjdk.org/jdk/pull/17065#discussion_r1424865972
PR Review Comment: https://git.openjdk.org/jdk/pull/17065#discussion_r1424866579
More information about the i18n-dev
mailing list