<i18n dev> RFR: 8321958: javadoc error: @returns of ZoneRules#isDaylightSavings() is incorrect [v2]

[Naoto Sato]

On Thu, 14 Dec 2023 09:32:23 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Corrected @param description
>
> src/java.base/share/classes/java/time/zone/ZoneRules.java line 831:
> 
>> 829:      * and {@link #getStandardOffset(java.time.Instant) standard} offsets.
>> 830:      *
>> 831:      * @param instant  the instant to find the offset information for, not null, but null
> 
> Hello Naoto, do you think this `@param` description too will have to be reworded? It seems to be a copy/paste of the `getDaylightSavings()` method.

Hi Jai, looks like it was copied/pasted from `getStandardOffset()`, but you are right, the description needs to be corrected.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17098#discussion_r1426999528