<i18n dev> RFR: 8301119: Support for GB18030-2022 [v3]

Ichiroh Takiguchi itakiguchi at openjdk.org
Fri Feb 24 08:38:07 UTC 2023

On Thu, 23 Feb 2023 19:34:44 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since this is not a compatible upgrade to the existing mapping, a new system property `jdk.charset.GB18030` is introduced. If it is set to "2000", the mapping falls back to the existing mapping based on the 2000 standard, otherwise, it defaults to 2022 mapping. Refer to the corresponding CSR for more detail.
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>   Moved the 2000 flag into GB18030

Hello @naotoj .
Sorry for bothering you.

I have following question:
- Why GB18030.java.template is in src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory even if the generated code is always stored into sun/nio/cs ?
I think the file should be moved to src/java.base/share/classes/sun/nio/cs and the file name should be GB18030.java instead of GB18030.java.template.
Is there specific reason ?


PR: https://git.openjdk.org/jdk/pull/12518

More information about the i18n-dev mailing list