 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
 ... 
{@code
> 342:  * // Print out a number using the localized number, integer, currency,
> 343:  * // and percent format for each locale}{@code

This comment is originally in strong font within the code example. Replacing both instances of `@ code` with `@ snippet` will just create two separate snippet blocks, one for the comment and one for the code which does not seem ideal.

To maintain the strong font, the comment has to be outside of the code snippet.

If that's not desirable, I think some alternatives are

- Leave the comment in the code snippet and get rid of the strong font 
- Keep the strong font but convert the comment into a normal text description

-------------

PR: https://git.openjdk.org/jdk/pull/12121

From lancea at openjdk.org  Fri Jan 20 18:38:29 2023
From: lancea at openjdk.org (Lance Andersen)
Date: Fri, 20 Jan 2023 18:38:29 GMT
Subject:  RFR: 8300706: Use @snippet in java.text
In-Reply-To: 
References: 

Message-ID: 

On Fri, 20 Jan 2023 17:57:47 GMT, Justin Lu  wrote:

>> Some classes / interfaces in java.text have already implemented JEP 413.
>> 
>> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for the rest of [java.text](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/package-summary.html) including:
>> - BreakIterator
>> - CharacterIterator
>> - DateFormatSymbols
>> - DecimalFormat
>> - NumberFormat 
>> 
>> Code examples using  ...  blocks are replaced with the @ snippet syntax where applicable.
>
> src/java.base/share/classes/java/text/DecimalFormat.java line 343:
> 
>> 341:  * {@code
>> 342:  * // Print out a number using the localized number, integer, currency,
>> 343:  * // and percent format for each locale}{@code
> 
> This comment is originally in strong font within the code example. Replacing both instances of `@ code` with `@ snippet` will just create two separate snippet blocks, one for the comment and one for the code which does not seem ideal.
> 
> To maintain the strong font, the comment has to be outside of the code snippet.
> 
> If that's not desirable, I think some alternatives are
> 
> - Leave the comment in the code snippet and get rid of the strong font 
> - Keep the strong font but convert the comment into a normal text description

I would leave the comment in the code snippet.  I don't see a compelling reason for it to be  as it was originally

-------------

PR: https://git.openjdk.org/jdk/pull/12121

From jlu at openjdk.org  Fri Jan 20 18:47:54 2023
From: jlu at openjdk.org (Justin Lu)
Date: Fri, 20 Jan 2023 18:47:54 GMT
Subject:  RFR: 8300706: Use @snippet in java.text [v2]
In-Reply-To: 
References: 
Message-ID: <7W5SmQg-OFxRra67XIaijKQG0KEkx142g2h3EPuzvDE=.4e97a568-22d3-4e6d-a241-ccf541779cbc@github.com>

> Some classes / interfaces in java.text have already implemented JEP 413.
> 
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for the rest of [java.text](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/package-summary.html) including:
> - BreakIterator
> - CharacterIterator
> - DateFormatSymbols
> - DecimalFormat
> - NumberFormat 
> 
> Code examples using  ...  blocks are replaced with the @ snippet syntax where applicable.

Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

  Drop strong font, put comment back in snippet

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12121/files
  - new: https://git.openjdk.org/jdk/pull/12121/files/bf8309ef..5b0bfe85

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12121&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12121&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/12121.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12121/head:pull/12121

PR: https://git.openjdk.org/jdk/pull/12121

From iris at openjdk.org  Fri Jan 20 18:49:32 2023
From: iris at openjdk.org (Iris Clark)
Date: Fri, 20 Jan 2023 18:49:32 GMT
Subject:  RFR: 8300589: Use @snippet and @linkplain in
 java.text.CollationKey and java.text.CompactNumberFormat [v2]
In-Reply-To: 
References: 

Message-ID: 

On Fri, 20 Jan 2023 17:31:26 GMT, Justin Lu  wrote:

>> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for [java.text.CollationKey](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CollationKey.html) and [java.text.CompactNumberFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CompactNumberFormat.html).
>> 
>> Code examples using  ...  blocks are replaced with the @ snippet syntax where applicable.
>> 
>> Additionally, for [java.text.CompactNumberFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CompactNumberFormat.html) internal plain text links using  ...  are replaced with @ linkplain. (External links are kept the same)
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Class can be removed for CNPatterns link

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/12108

From naoto at openjdk.org  Fri Jan 20 19:00:26 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 20 Jan 2023 19:00:26 GMT
Subject:  RFR: 8300706: Use @snippet in java.text [v2]
In-Reply-To: <7W5SmQg-OFxRra67XIaijKQG0KEkx142g2h3EPuzvDE=.4e97a568-22d3-4e6d-a241-ccf541779cbc@github.com>
References: 
 <7W5SmQg-OFxRra67XIaijKQG0KEkx142g2h3EPuzvDE=.4e97a568-22d3-4e6d-a241-ccf541779cbc@github.com>
Message-ID: 

On Fri, 20 Jan 2023 18:47:54 GMT, Justin Lu  wrote:

>> Some classes / interfaces in java.text have already implemented JEP 413.
>> 
>> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for the rest of [java.text](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/package-summary.html) including:
>> - BreakIterator
>> - CharacterIterator
>> - DateFormatSymbols
>> - DecimalFormat
>> - NumberFormat 
>> 
>> Code examples using  ...  blocks are replaced with the @ snippet syntax where applicable.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Drop strong font, put comment back in snippet

Your changes look good. I'd clean up the examples themselves taking this opportunity.

src/java.base/share/classes/java/text/DecimalFormat.java line 75:

> 73:  * {@snippet lang=java :
> 74:  * NumberFormat f = NumberFormat.getInstance(loc);
> 75:  * if (f instanceof DecimalFormat) {

Pattern matching `instanceof` should be used.

src/java.base/share/classes/java/text/DecimalFormat.java line 373:

> 371:  *     }
> 372:  * }
> 373:  * }

The example here can utilize enhanced `switch` and pattern matching `instanceof`.

-------------

PR: https://git.openjdk.org/jdk/pull/12121

From naoto at openjdk.org  Fri Jan 20 19:00:31 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 20 Jan 2023 19:00:31 GMT
Subject:  RFR: 8300706: Use @snippet in java.text [v2]
In-Reply-To: 
References: 

Message-ID: 

On Fri, 20 Jan 2023 18:34:37 GMT, Lance Andersen  wrote:

>> src/java.base/share/classes/java/text/DecimalFormat.java line 343:
>> 
>>> 341:  * {@code
>>> 342:  * // Print out a number using the localized number, integer, currency,
>>> 343:  * // and percent format for each locale}{@code
>> 
>> This comment is originally in strong font within the code example. Replacing both instances of `@ code` with `@ snippet` will just create two separate snippet blocks, one for the comment and one for the code which does not seem ideal.
>> 
>> To maintain the strong font, the comment has to be outside of the code snippet.
>> 
>> If that's not desirable, I think some alternatives are
>> 
>> - Leave the comment in the code snippet and get rid of the strong font 
>> - Keep the strong font but convert the comment into a normal text description
>
> I would leave the comment in the code snippet.  I don't see a compelling reason for it to be  as it was originally

+1

-------------

PR: https://git.openjdk.org/jdk/pull/12121

From jlu at openjdk.org  Fri Jan 20 19:54:44 2023
From: jlu at openjdk.org (Justin Lu)
Date: Fri, 20 Jan 2023 19:54:44 GMT
Subject:  RFR: 8300706: Use @snippet in java.text [v3]
In-Reply-To: 
References: 
Message-ID: 

> Some classes / interfaces in java.text have already implemented JEP 413.
> 
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for the rest of [java.text](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/package-summary.html) including:
> - BreakIterator
> - CharacterIterator
> - DateFormatSymbols
> - DecimalFormat
> - NumberFormat 
> 
> Code examples using  ...  blocks are replaced with the @ snippet syntax where applicable.

Justin Lu has updated the pull request incrementally with three additional commits since the last revision:

 - Close catch on same line
 - Use pattern matching instanceOf, expression switch statement, and improve for loop readability
 - Use pattern IOf (1st snippet)

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12121/files
  - new: https://git.openjdk.org/jdk/pull/12121/files/5b0bfe85..f5f9632c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12121&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12121&range=01-02

  Stats: 19 lines in 1 file changed: 0 ins; 4 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/12121.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12121/head:pull/12121

PR: https://git.openjdk.org/jdk/pull/12121

From naoto at openjdk.org  Fri Jan 20 22:08:11 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 20 Jan 2023 22:08:11 GMT
Subject:  RFR: 8300706: Use @snippet in java.text [v3]
In-Reply-To: 
References: 

Message-ID: 

On Fri, 20 Jan 2023 19:54:44 GMT, Justin Lu  wrote:

>> Some classes / interfaces in java.text have already implemented JEP 413.
>> 
>> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for the rest of [java.text](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/package-summary.html) including:
>> - BreakIterator
>> - CharacterIterator
>> - DateFormatSymbols
>> - DecimalFormat
>> - NumberFormat 
>> 
>> Code examples using  ...  blocks are replaced with the @ snippet syntax where applicable.
>
> Justin Lu has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Close catch on same line
>  - Use pattern matching instanceOf, expression switch statement, and improve for loop readability
>  - Use pattern IOf (1st snippet)

Marked as reviewed by naoto (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/12121

From stsypanov at openjdk.org  Sat Jan 21 21:20:49 2023
From: stsypanov at openjdk.org (Sergey Tsypanov)
Date: Sat, 21 Jan 2023 21:20:49 GMT
Subject:  RFR: 8300818: Reduce complexity of padding with
 DateTimeFormatter
Message-ID: 

Currently it's O(n) - we do `n` shifts of bytes within `StringBuilder`. This can be reduced to O(1) improving the code like:

DateTimeFormatter dtf = new DateTimeFormatterBuilder()
  .appendLiteral("Date:")
  .padNext(20, ' ')
  .append(DateTimeFormatter.ISO_DATE)
  .toFormatter();
String text = dtf.format(LocalDateTime.now());

-------------

Commit messages:
 - Improve padding of DateTimeFormatter

Changes: https://git.openjdk.org/jdk/pull/12131/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12131&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8300818
  Stats: 5 lines in 1 file changed: 0 ins; 2 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/12131.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12131/head:pull/12131

PR: https://git.openjdk.org/jdk/pull/12131

From stsypanov at openjdk.org  Sun Jan 22 09:50:21 2023
From: stsypanov at openjdk.org (Sergey Tsypanov)
Date: Sun, 22 Jan 2023 09:50:21 GMT
Subject:  RFR: 8300818: Reduce complexity of padding with
 DateTimeFormatter [v2]
In-Reply-To: 
References: 
Message-ID: 

> Currently it's O(n) - we do `n` shifts of bytes within `StringBuilder`. This can be reduced to O(1) improving the code like:
> 
> DateTimeFormatter dtf = new DateTimeFormatterBuilder()
>   .appendLiteral("Date:")
>   .padNext(20, ' ')
>   .append(DateTimeFormatter.ISO_DATE)
>   .toFormatter();
> String text = dtf.format(LocalDateTime.now());

Sergey Tsypanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into dtfb
 - Improve padding of DateTimeFormatter

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12131/files
  - new: https://git.openjdk.org/jdk/pull/12131/files/b2160f8c..322ae9b4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12131&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12131&range=00-01

  Stats: 95 lines in 17 files changed: 34 ins; 0 del; 61 mod
  Patch: https://git.openjdk.org/jdk/pull/12131.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12131/head:pull/12131

PR: https://git.openjdk.org/jdk/pull/12131

From redestad at openjdk.org  Sun Jan 22 11:40:04 2023
From: redestad at openjdk.org (Claes Redestad)
Date: Sun, 22 Jan 2023 11:40:04 GMT
Subject:  RFR: 8300818: Reduce complexity of padding with
 DateTimeFormatter [v2]
In-Reply-To: 
References: 

Message-ID: 

On Sun, 22 Jan 2023 09:50:21 GMT, Sergey Tsypanov  wrote:

>> Currently it's O(n) - we do `n` shifts of bytes within `StringBuilder`. This can be reduced to O(1) improving the code like:
>> 
>> DateTimeFormatter dtf = new DateTimeFormatterBuilder()
>>   .appendLiteral("Date:")
>>   .padNext(20, ' ')
>>   .append(DateTimeFormatter.ISO_DATE)
>>   .toFormatter();
>> String text = dtf.format(LocalDateTime.now());
>
> Sergey Tsypanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into dtfb
>  - Improve padding of DateTimeFormatter

Changes requested by redestad (Reviewer).

src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 2603:

> 2601:         public boolean format(DateTimePrintContext context, StringBuilder buf) {
> 2602:             int preLen = buf.length();
> 2603:             if (!printerParser.format(context, buf)) {

Non-standard as it may be, this style of using `expr == false` instead of `!expr` is a style choice by the original author. I would advice against changing these piecemeal without discussion and agreement that we should consistently enforce the `!expr` style.

src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 2611:

> 2609:                     "Cannot print as output of " + len + " characters exceeds pad width of " + padWidth);
> 2610:             }
> 2611:             buf.insert(preLen, String.valueOf(padChar).repeat(padWidth - len));

Have you checked with a microbenchmark that this added allocation can be elided by JITs and that there's a significant speed-up with your changes? I don't have the necessary domain expertise to assert anything here but I suspect padding widths are typically short. Such as 2 or 4 (for day/month and year fields) so a micro should examine there's no regression for little to no padding. Unlike the original code you call `insert` even if `padWidth - len == 0`. This might be optimized away by JITs, but it'd be good to verify which is best.

-------------

PR: https://git.openjdk.org/jdk/pull/12131

From stsypanov at openjdk.org  Sun Jan 22 13:10:06 2023
From: stsypanov at openjdk.org (Sergey Tsypanov)
Date: Sun, 22 Jan 2023 13:10:06 GMT
Subject:  RFR: 8300818: Reduce complexity of padding with
 DateTimeFormatter [v2]
In-Reply-To: 
References: 

Message-ID: 

On Sun, 22 Jan 2023 10:56:11 GMT, Claes Redestad  wrote:

>> Sergey Tsypanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into dtfb
>>  - Improve padding of DateTimeFormatter
>
> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 2603:
> 
>> 2601:         public boolean format(DateTimePrintContext context, StringBuilder buf) {
>> 2602:             int preLen = buf.length();
>> 2603:             if (!printerParser.format(context, buf)) {
> 
> Non-standard as it may be, this style of using `expr == false` instead of `!expr` is a style choice by the original author. I would advice against changing these piecemeal without discussion and agreement that we should consistently enforce the `!expr` style.

Sure, I'll revert it

-------------

PR: https://git.openjdk.org/jdk/pull/12131

From stsypanov at openjdk.org  Sun Jan 22 13:31:05 2023
From: stsypanov at openjdk.org (Sergey Tsypanov)
Date: Sun, 22 Jan 2023 13:31:05 GMT
Subject:  RFR: 8300818: Reduce complexity of padding with
 DateTimeFormatter [v2]
In-Reply-To: 
References: 

Message-ID: <3Im4RP5-AmauuIjCVgA3V4h0HellqriqIlbTSjXjrWU=.a3b7c98f-276a-423a-8d48-c3415633b2cc@github.com>

On Sun, 22 Jan 2023 11:36:34 GMT, Claes Redestad  wrote:

>> Sergey Tsypanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into dtfb
>>  - Improve padding of DateTimeFormatter
>
> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 2611:
> 
>> 2609:                     "Cannot print as output of " + len + " characters exceeds pad width of " + padWidth);
>> 2610:             }
>> 2611:             buf.insert(preLen, String.valueOf(padChar).repeat(padWidth - len));
> 
> Have you checked with a microbenchmark that this added allocation can be elided by JITs and that there's a significant speed-up with your changes? I don't have the necessary domain expertise to assert anything here but I suspect padding widths are typically short. Such as 2 or 4 (for day/month and year fields) so a micro should examine there's no regression for little to no padding. Unlike the original code you call `insert` even if `padWidth - len == 0`. This might be optimized away by JITs, but it'd be good to verify which is best.

The modified code is called only when a user explicitly calls `padNext(int, char)`, i.e. if I modified the example snippet as

DateTimeFormatter dtf = new DateTimeFormatterBuilder()
  .appendLiteral("Date:")
//.padNext(20, ' ')
  .append(DateTimeFormatter.ISO_DATE)
  .toFormatter();
String text = dtf.format(LocalDateTime.now());

there's no regression.

Right now I cannot build ad-hoc JDK with my changes and check it with JMH, so I'd convert this to draft until I can verify it

-------------

PR: https://git.openjdk.org/jdk/pull/12131

From redestad at openjdk.org  Mon Jan 23 11:37:05 2023
From: redestad at openjdk.org (Claes Redestad)
Date: Mon, 23 Jan 2023 11:37:05 GMT
Subject:  RFR: 8300818: Reduce complexity of padding with
 DateTimeFormatter [v2]
In-Reply-To: <3Im4RP5-AmauuIjCVgA3V4h0HellqriqIlbTSjXjrWU=.a3b7c98f-276a-423a-8d48-c3415633b2cc@github.com>
References: 

 <3Im4RP5-AmauuIjCVgA3V4h0HellqriqIlbTSjXjrWU=.a3b7c98f-276a-423a-8d48-c3415633b2cc@github.com>
Message-ID: <_gJmYty5eyRbpGo3AIlFE4HDkmGWAWPsAOqwJri3mqo=.70b5927c-2be5-484c-98f4-f21933166c55@github.com>

On Sun, 22 Jan 2023 13:28:06 GMT, Sergey Tsypanov  wrote:

>> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 2611:
>> 
>>> 2609:                     "Cannot print as output of " + len + " characters exceeds pad width of " + padWidth);
>>> 2610:             }
>>> 2611:             buf.insert(preLen, String.valueOf(padChar).repeat(padWidth - len));
>> 
>> Have you checked with a microbenchmark that this added allocation can be elided by JITs and that there's a significant speed-up with your changes? I don't have the necessary domain expertise to assert anything here but I suspect padding widths are typically short. Such as 2 or 4 (for day/month and year fields) so a micro should examine there's no regression for little to no padding. Unlike the original code you call `insert` even if `padWidth - len == 0`. This might be optimized away by JITs, but it'd be good to verify which is best.
>
> The modified code is called only when a user explicitly calls `padNext(int, char)`, i.e. if I modified the example snippet as
> 
> DateTimeFormatter dtf = new DateTimeFormatterBuilder()
>   .appendLiteral("Date:")
> //.padNext(20, ' ')
>   .append(DateTimeFormatter.ISO_DATE)
>   .toFormatter();
> String text = dtf.format(LocalDateTime.now());
> 
> there's no regression.
> 
> Right now I cannot build ad-hoc JDK with my changes and check it with JMH, so I'd convert this to draft until I can verify it

Meant that you should verify that something like this, which just add a little padding, doesn't regress with your changes: 

DateTimeFormatter dtf = new DateTimeFormatterBuilder()
    .appendLiteral("Year:")
    .padNext(5)
    .appendValue(ChronoField.YEAR)
    .toFormatter();
... 
dtf.format(LocalDateTime.now());

And similar for effectively no padding (`.padNext(4)` in the above example). As this API might often be used to ensure short 2-4 char fields are correctly padded I think it's important that we're not adding overhead to such use cases.

-------------

PR: https://git.openjdk.org/jdk/pull/12131

From jlu at openjdk.org  Mon Jan 23 19:40:22 2023
From: jlu at openjdk.org (Justin Lu)
Date: Mon, 23 Jan 2023 19:40:22 GMT
Subject:  Integrated: 8300077: Refactor code examples to use
 @snippet in java.text.ChoiceFormat
In-Reply-To: 
References: 
Message-ID: 

On Thu, 12 Jan 2023 22:31:24 GMT, Justin Lu  wrote:

> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for [java.text.ChoiceFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/ChoiceFormat.html).
> 
> Code examples using  ...  blocks are replaced with the @ snippet syntax where applicable.

This pull request has now been integrated.

Changeset: dcf1523b
Author:    Justin Lu 
Committer: Naoto Sato 
URL:       https://git.openjdk.org/jdk/commit/dcf1523bf2dba234371190a70a41cfcb77907196
Stats:     6 lines in 1 file changed: 0 ins; 0 del; 6 mod

8300077: Refactor code examples to use @snippet in java.text.ChoiceFormat

Reviewed-by: lancea, iris, naoto

-------------

PR: https://git.openjdk.org/jdk/pull/11981

From jlu at openjdk.org  Tue Jan 24 02:08:14 2023
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 24 Jan 2023 02:08:14 GMT
Subject:  Integrated: 8300706: Use @snippet in java.text
In-Reply-To: 
References: 
Message-ID: <-Fk9_rPXrXEPlAdQzTryAjZvBXppkailmIXxE_LiiXE=.0f0f9eb5-4546-49c8-9524-3b446dc637b4@github.com>

On Fri, 20 Jan 2023 17:41:35 GMT, Justin Lu  wrote:

> Some classes / interfaces in java.text have already implemented JEP 413.
> 
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for the rest of [java.text](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/package-summary.html) including:
> - BreakIterator
> - CharacterIterator
> - DateFormatSymbols
> - DecimalFormat
> - NumberFormat 
> 
> Code examples using  ...  blocks are replaced with the @ snippet syntax where applicable.

This pull request has now been integrated.

Changeset: 0323609f
Author:    Justin Lu 
Committer: Naoto Sato 
URL:       https://git.openjdk.org/jdk/commit/0323609f44e68ba8d992419a23be7066838a0e01
Stats:     69 lines in 5 files changed: 7 ins; 11 del; 51 mod

8300706: Use @snippet in java.text

Reviewed-by: naoto

-------------

PR: https://git.openjdk.org/jdk/pull/12121

From jlu at openjdk.org  Tue Jan 24 04:39:09 2023
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 24 Jan 2023 04:39:09 GMT
Subject:  Integrated: 8300589: Use @snippet and @linkplain in
 java.text.CollationKey and java.text.CompactNumberFormat
In-Reply-To: 
References: 
Message-ID: 

On Thu, 19 Jan 2023 22:25:51 GMT, Justin Lu  wrote:

> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for [java.text.CollationKey](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CollationKey.html) and [java.text.CompactNumberFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CompactNumberFormat.html).
> 
> Code examples using  ...  blocks are replaced with the @ snippet syntax where applicable.
> 
> Additionally, for [java.text.CompactNumberFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CompactNumberFormat.html) internal plain text links using  ...  are replaced with @ linkplain. (External links are kept the same)

This pull request has now been integrated.

Changeset: b3822f50
Author:    Justin Lu 
Committer: Naoto Sato 
URL:       https://git.openjdk.org/jdk/commit/b3822f50c85524a00a045aa3a3d902f190e35906
Stats:     15 lines in 2 files changed: 0 ins; 2 del; 13 mod

8300589: Use @snippet and @linkplain in java.text.CollationKey and java.text.CompactNumberFormat

Reviewed-by: lancea, naoto, iris

-------------

PR: https://git.openjdk.org/jdk/pull/12108

From dnguyen at openjdk.org  Tue Jan 24 20:57:43 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 20:57:43 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files
 update
Message-ID: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
All tests passed

-------------

Commit messages:
 - Remove currency symbol entries
 - Remove whitespace using tool
 - Remove double quotes generated by translation tool
 - Revert translation's removal of  text
 - Update files for localization

Changes: https://git.openjdk.org/jdk20/pull/116/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8300719
  Stats: 1030 lines in 81 files changed: 218 ins; 115 del; 697 mod
  Patch: https://git.openjdk.org/jdk20/pull/116.diff
  Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 21:08:11 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 21:08:11 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: <4tI9y6FpAFrOiS4N4joygZHAHvPm-Ka2D9_3F8pyD6o=.fbb62ba6-4658-46b5-96f8-307ab3b41f81@github.com>

On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen  wrote:

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

@prrace @wangweij @naotoj @JoeWang-Java @plummercj @alexeysemenyukoracle
Could you review the changes from this localization drop?

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 21:48:11 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 21:48:11 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: 

On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen  wrote:

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

@magicus @LanceAndersen @jonathan-gibbons @pavelrappo @dougxc @lahodaj
Could you review the changes from this localization drop for the areas you're familiar with?

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From cjplummer at openjdk.org  Tue Jan 24 22:05:10 2023
From: cjplummer at openjdk.org (Chris Plummer)
Date: Tue, 24 Jan 2023 22:05:10 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: 

On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen  wrote:

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

jdk.console and jdk.management.agent changes look good.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 22:12:26 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 22:12:26 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v2]
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: 

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Change German help of jar command

-------------

Changes:
  - all: https://git.openjdk.org/jdk20/pull/116/files
  - new: https://git.openjdk.org/jdk20/pull/116/files/4ced04fb..a2528015

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk20/pull/116.diff
  Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116

PR: https://git.openjdk.org/jdk20/pull/116

From naoto at openjdk.org  Tue Jan 24 22:24:15 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 24 Jan 2023 22:24:15 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v2]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:12:26 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change German help of jar command

Changes requested by naoto (Reviewer).

src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties line 174:

> 172: MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON=\u53D6\u6D88\u8BA2\u9605(&U)
> 173: MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON_TOOLTIP=\u505C\u6B62\u76D1\u542C\u901A\u77E5
> 174: MANAGE_HOTSPOT_MBEANS_IN_COLON_=\u7BA1\u7406\u4EE5\u4E0B\u4F4D\u7F6E\u7684 HotSpot MBean:

This looks like a prefix, so instead of removing the space, it should be replaced with `\u0020` like other locations.
Also, it seems that other l10n files (de, ja) do not seem to have spaces in the first place.

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.properties line 38:

> 36: resource.post-msi-script=Auszuf\u00FChrendes Skript nach dem Erstellen der MSI-Datei f\u00FCr das EXE-Installationsprogramm
> 37: resource.wxl-file=WiX-Lokalisierungsdatei
> 38: resource.wxl-file-name=MsiInstallerStrings_en.wxl

Shouldn't this be `de`?

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties line 38:

> 36: resource.post-msi-script=exe\u30A4\u30F3\u30B9\u30C8\u30FC\u30E9\u306Emsi\u30D5\u30A1\u30A4\u30EB\u304C\u4F5C\u6210\u3055\u308C\u305F\u5F8C\u306B\u5B9F\u884C\u3059\u308B\u30B9\u30AF\u30EA\u30D7\u30C8
> 37: resource.wxl-file=WiX\u30ED\u30FC\u30AB\u30EA\u30BC\u30FC\u30B7\u30E7\u30F3\u30FB\u30D5\u30A1\u30A4\u30EB
> 38: resource.wxl-file-name=MsiInstallerStrings_en.wxl

Shouldn't this be `ja`?

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties line 38:

> 36: resource.post-msi-script=\u5728\u4E3A exe \u5B89\u88C5\u7A0B\u5E8F\u521B\u5EFA msi \u6587\u4EF6\u4E4B\u540E\u8981\u8FD0\u884C\u7684\u811A\u672C
> 37: resource.wxl-file=WiX \u672C\u5730\u5316\u6587\u4EF6
> 38: resource.wxl-file-name=MsiInstallerStrings_en.wxl

Shouldn't this be `zh_CN`?

src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_zh_CN.properties line 63:

> 61: # written authorization of the copyright holder.
> 62: 
> 63: CNY=\uffe5

Do not remove this.

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 22:24:16 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 22:24:16 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v2]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:05:55 GMT, Naoto Sato  wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change German help of jar command
>
> src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties line 174:
> 
>> 172: MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON=\u53D6\u6D88\u8BA2\u9605(&U)
>> 173: MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON_TOOLTIP=\u505C\u6B62\u76D1\u542C\u901A\u77E5
>> 174: MANAGE_HOTSPOT_MBEANS_IN_COLON_=\u7BA1\u7406\u4EE5\u4E0B\u4F4D\u7F6E\u7684 HotSpot MBean:
> 
> This looks like a prefix, so instead of removing the space, it should be replaced with `\u0020` like other locations.
> Also, it seems that other l10n files (de, ja) do not seem to have spaces in the first place.

OK, I can make the manual edit for this

> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties line 38:
> 
>> 36: resource.post-msi-script=\u5728\u4E3A exe \u5B89\u88C5\u7A0B\u5E8F\u521B\u5EFA msi \u6587\u4EF6\u4E4B\u540E\u8981\u8FD0\u884C\u7684\u811A\u672C
>> 37: resource.wxl-file=WiX \u672C\u5730\u5316\u6587\u4EF6
>> 38: resource.wxl-file-name=MsiInstallerStrings_en.wxl
> 
> Shouldn't this be `zh_CN`?

The translation tool seems to use the English source file's file name here, so it's replaced. I will handle these 3 occurrences now. I thought I handled all occurrences of this, but these 3 slipped in

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 22:33:24 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 22:33:24 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v3]
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: 

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Change localization codes. Add CNY back

-------------

Changes:
  - all: https://git.openjdk.org/jdk20/pull/116/files
  - new: https://git.openjdk.org/jdk20/pull/116/files/a2528015..40291c61

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=01-02

  Stats: 4 lines in 4 files changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk20/pull/116.diff
  Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 22:33:28 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 22:33:28 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v2]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:12:02 GMT, Naoto Sato  wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change German help of jar command
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.properties line 38:
> 
>> 36: resource.post-msi-script=Auszuf\u00FChrendes Skript nach dem Erstellen der MSI-Datei f\u00FCr das EXE-Installationsprogramm
>> 37: resource.wxl-file=WiX-Lokalisierungsdatei
>> 38: resource.wxl-file-name=MsiInstallerStrings_en.wxl
> 
> Shouldn't this be `de`?

Changed back similar to with zh_CN

> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties line 38:
> 
>> 36: resource.post-msi-script=exe\u30A4\u30F3\u30B9\u30C8\u30FC\u30E9\u306Emsi\u30D5\u30A1\u30A4\u30EB\u304C\u4F5C\u6210\u3055\u308C\u305F\u5F8C\u306B\u5B9F\u884C\u3059\u308B\u30B9\u30AF\u30EA\u30D7\u30C8
>> 37: resource.wxl-file=WiX\u30ED\u30FC\u30AB\u30EA\u30BC\u30FC\u30B7\u30E7\u30F3\u30FB\u30D5\u30A1\u30A4\u30EB
>> 38: resource.wxl-file-name=MsiInstallerStrings_en.wxl
> 
> Shouldn't this be `ja`?

Changed back similar to with zh_CN

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 22:33:29 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 22:33:29 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v3]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:14:36 GMT, Naoto Sato  wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change localization codes. Add CNY back
>
> src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_zh_CN.properties line 63:
> 
>> 61: # written authorization of the copyright holder.
>> 62: 
>> 63: CNY=\uffe5
> 
> Do not remove this.

Added back. Thanks for catching this!

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From prr at openjdk.org  Tue Jan 24 22:44:13 2023
From: prr at openjdk.org (Phil Race)
Date: Tue, 24 Jan 2023 22:44:13 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v2]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:12:26 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change German help of jar command

Removing the trailing white space seems OK in the desktop resources.
I checked the base (English) version of the files and none of them have trailing white space so it seems unlikely it is significant.

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.org/jdk20/pull/116

From jlu at openjdk.org  Tue Jan 24 22:44:14 2023
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 24 Jan 2023 22:44:14 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v3]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:20:22 GMT, Damon Nguyen  wrote:

>> src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties line 174:
>> 
>>> 172: MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON=\u53D6\u6D88\u8BA2\u9605(&U)
>>> 173: MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON_TOOLTIP=\u505C\u6B62\u76D1\u542C\u901A\u77E5
>>> 174: MANAGE_HOTSPOT_MBEANS_IN_COLON_=\u7BA1\u7406\u4EE5\u4E0B\u4F4D\u7F6E\u7684 HotSpot MBean:
>> 
>> This looks like a prefix, so instead of removing the space, it should be replaced with `\u0020` like other locations.
>> Also, it seems that other l10n files (de, ja) do not seem to have spaces in the first place.
>
> OK, I can make the manual edit for this

This change was made because it was compared to the original messages.properties. In that file, the respective line is given as `MANAGE_HOTSPOT_MBEANS_IN_COLON_=Manage Hotspot MBeans in:` with no trailing space. That's why in this file, to ensure consistency, the trailing space was stripped.

I think either this space should be removed, or all 4 (en, ja, de, zh) should have the `\u0020` appended. I agree that since it is a prefix it would make sense for a space to be there, but there is no guarantee that what comes after, or even the code that loads the .properties file does not already handles that necessary space.

Should the space remain removed like in the English source file and the other l10n files, or do you think all 4 should be changed to add `\u0020`?

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From joehw at openjdk.org  Tue Jan 24 22:59:07 2023
From: joehw at openjdk.org (Joe Wang)
Date: Tue, 24 Jan 2023 22:59:07 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v3]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: <8IAAljdZ35sxC22s2SeFdCTX5xmx83YUFr8dwOYtXzA=.028e67c7-0969-4204-b843-0c0f2d79574f@github.com>

On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change localization codes. Add CNY back

Marked as reviewed by joehw (Reviewer).

java.xml changes look good to me. Thanks.

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From naoto at openjdk.org  Tue Jan 24 22:59:08 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 24 Jan 2023 22:59:08 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v3]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:40:55 GMT, Justin Lu  wrote:

>> OK, I can make the manual edit for this
>
> This change was made because it was compared to the original messages.properties. In that file, the respective line is given as `MANAGE_HOTSPOT_MBEANS_IN_COLON_=Manage Hotspot MBeans in:` with no trailing space. That's why in this file, to ensure consistency, the trailing space was stripped.
> 
> I think either this space should be removed, or all 4 (en, ja, de, zh) should have the `\u0020` appended. I agree that since it is a prefix it would make sense for a space to be there, but there is no guarantee that what comes after, or even the code that loads the .properties file does not already handles that necessary space.
> 
> Should the space remain removed like in the English source file and the other l10n files, or do you think all 4 should be changed to add `\u0020`?

Confirmed that the message is for a label (`sun.tools.jconsole.LabeledComponent`), followed by a Component, so no space seems needed in each file. Sorry for the false alarm.

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 22:59:08 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 22:59:08 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v3]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:49:20 GMT, Naoto Sato  wrote:

>> This change was made because it was compared to the original messages.properties. In that file, the respective line is given as `MANAGE_HOTSPOT_MBEANS_IN_COLON_=Manage Hotspot MBeans in:` with no trailing space. That's why in this file, to ensure consistency, the trailing space was stripped.
>> 
>> I think either this space should be removed, or all 4 (en, ja, de, zh) should have the `\u0020` appended. I agree that since it is a prefix it would make sense for a space to be there, but there is no guarantee that what comes after, or even the code that loads the .properties file does not already handles that necessary space.
>> 
>> Should the space remain removed like in the English source file and the other l10n files, or do you think all 4 should be changed to add `\u0020`?
>
> Confirmed that the message is for a label (`sun.tools.jconsole.LabeledComponent`), followed by a Component, so no space seems needed in each file. Sorry for the false alarm.

Ok I left this change out of my most recent update just in case. I addressed all the other comments I believe. Thanks!

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From asemenyuk at openjdk.org  Tue Jan 24 22:59:12 2023
From: asemenyuk at openjdk.org (Alexey Semenyuk)
Date: Tue, 24 Jan 2023 22:59:12 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v3]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change localization codes. Add CNY back

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl line 2:

> 1: 
> 2: 

Please revert the value of the `Culture` attribute.

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_ja.wxl line 2:

> 1: 
> 2: 

Please revert the value of the `Culture` attribute.

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_zh_CN.wxl line 2:

> 1: 
> 2: 

Please revert the value of the `Culture` attribute.

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From jlu at openjdk.org  Tue Jan 24 23:06:14 2023
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 24 Jan 2023 23:06:14 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v3]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change localization codes. Add CNY back

src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_ja.properties line 62:

> 60: dedup-legal-notices.usage=\  --dedup-legal-notices [error-if-not-same-content]\n                            \u3059\u3079\u3066\u306E\u6CD5\u5F8B\u4E0A\u306E\u6CE8\u610F\u70B9\u306E\u91CD\u8907\u3092\u9664\u5916\u3057\u307E\u3059\u3002\n                            error-if-not-same-content\u304C\u6307\u5B9A\u3055\u308C\u3066\u3044\u308B\u5834\u5408\u3001\n                            \u540C\u3058\u30D5\u30A1\u30A4\u30EB\u540D\u306E2\u3064\u306E\u30D5\u30A1\u30A4\u30EB\u304C\u7570\u306A\u3063\u3066\u3044\u308B\u3068\n                            \u30A8\u30E9\u30FC\u306B\u306A\u308A\u307E\u3059\u3002
> 61: 
> 62: exclude-files.argument=\u9664\u5916\u3059\u308B\u30D5\u30A1\u30A4\u30EB\u306E 

It seems like the translation process added a space here, but it does not appear in the original. This should be removed.

src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties line 194:

> 192: main.plugin.module=\u63D2\u4EF6\u6A21\u5757
> 193: 
> 194: main.plugin.category=\u7C7B\u522B 

Same as above.

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From asemenyuk at openjdk.org  Tue Jan 24 23:19:12 2023
From: asemenyuk at openjdk.org (Alexey Semenyuk)
Date: Tue, 24 Jan 2023 23:19:12 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v3]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: <53tinlttCmtNrOBaz7F54bKSeftrurnsr9OVoQzzjC8=.191b9195-e775-4b4b-8811-d34789cec36e@github.com>

On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change localization codes. Add CNY back

Changes requested by asemenyuk (Reviewer).

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_zh_CN.wxl line 2:

> 1: 
> 2: 

Please revert the value of the Culture attribute.

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 23:38:23 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 23:38:23 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v4]
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: 

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Remove trailing whitespace

-------------

Changes:
  - all: https://git.openjdk.org/jdk20/pull/116/files
  - new: https://git.openjdk.org/jdk20/pull/116/files/40291c61..fc32c37f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=02-03

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk20/pull/116.diff
  Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 23:56:23 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 23:56:23 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: 

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Revert culture attribute

-------------

Changes:
  - all: https://git.openjdk.org/jdk20/pull/116/files
  - new: https://git.openjdk.org/jdk20/pull/116/files/fc32c37f..616b2502

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=03-04

  Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk20/pull/116.diff
  Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 23:59:13 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 23:59:13 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v3]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 23:02:58 GMT, Justin Lu  wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change localization codes. Add CNY back
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_ja.properties line 62:
> 
>> 60: dedup-legal-notices.usage=\  --dedup-legal-notices [error-if-not-same-content]\n                            \u3059\u3079\u3066\u306E\u6CD5\u5F8B\u4E0A\u306E\u6CE8\u610F\u70B9\u306E\u91CD\u8907\u3092\u9664\u5916\u3057\u307E\u3059\u3002\n                            error-if-not-same-content\u304C\u6307\u5B9A\u3055\u308C\u3066\u3044\u308B\u5834\u5408\u3001\n                            \u540C\u3058\u30D5\u30A1\u30A4\u30EB\u540D\u306E2\u3064\u306E\u30D5\u30A1\u30A4\u30EB\u304C\u7570\u306A\u3063\u3066\u3044\u308B\u3068\n                            \u30A8\u30E9\u30FC\u306B\u306A\u308A\u307E\u3059\u3002
>> 61: 
>> 62: exclude-files.argument=\u9664\u5916\u3059\u308B\u30D5\u30A1\u30A4\u30EB\u306E 
> 
> It seems like the translation process added a space here, but it does not appear in the original. This should be removed.

Removed both instances of the extra trailing whitespace.

> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties line 194:
> 
>> 192: main.plugin.module=\u63D2\u4EF6\u6A21\u5757
>> 193: 
>> 194: main.plugin.category=\u7C7B\u522B 
> 
> Same as above.

Addressed as above

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 23:59:17 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 23:59:17 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v2]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:55:43 GMT, Alexey Semenyuk  wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change German help of jar command
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl line 2:
> 
>> 1: 
>> 2: 
> 
> Please revert the value of the `Culture` attribute.

I resolved this for the German, Japanese, and Chinese files in the latest commit.

> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_ja.wxl line 2:
> 
>> 1: 
>> 2: 
> 
> Please revert the value of the `Culture` attribute.

Resolved in recent commit

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Tue Jan 24 23:59:19 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 24 Jan 2023 23:59:19 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v3]
In-Reply-To: <53tinlttCmtNrOBaz7F54bKSeftrurnsr9OVoQzzjC8=.191b9195-e775-4b4b-8811-d34789cec36e@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

 <53tinlttCmtNrOBaz7F54bKSeftrurnsr9OVoQzzjC8=.191b9195-e775-4b4b-8811-d34789cec36e@github.com>
Message-ID: 

On Tue, 24 Jan 2023 23:16:02 GMT, Alexey Semenyuk  wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change localization codes. Add CNY back
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_zh_CN.wxl line 2:
> 
>> 1: 
>> 2: 
> 
> Please revert the value of the Culture attribute.

Resolved in recent commit

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From asemenyuk at openjdk.org  Wed Jan 25 00:12:09 2023
From: asemenyuk at openjdk.org (Alexey Semenyuk)
Date: Wed, 25 Jan 2023 00:12:09 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert culture attribute

jpackage changes look good

-------------

Marked as reviewed by asemenyuk (Reviewer).

PR: https://git.openjdk.org/jdk20/pull/116

From jlu at openjdk.org  Wed Jan 25 01:11:15 2023
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 25 Jan 2023 01:11:15 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert culture attribute

Marked as reviewed by jlu (Author).

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From duke at openjdk.org  Wed Jan 25 08:20:13 2023
From: duke at openjdk.org (danielpeintner)
Date: Wed, 25 Jan 2023 08:20:13 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v2]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 22:12:26 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change German help of jar command

src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_de.properties line 111:

> 109: main.help.opt.main.update=\  -u, --update               Ein vorhandenes JAR-Archiv aktualisieren
> 110: main.help.opt.main.extract=\  -x, --extract              Benannte (oder alle) Dateien aus dem Archiv extrahieren
> 111: main.help.opt.main.describe-module=\  -d, --describe-module      Gibt den Moduldeskriptor oder automatischen Modulnamen aus

Just because I stumbled over this commit. I think the line should be translated as follows:

`Gibt die Modulbeschreibung oder den automatischen Modulnamen aus`

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From lancea at openjdk.org  Wed Jan 25 13:45:21 2023
From: lancea at openjdk.org (Lance Andersen)
Date: Wed, 25 Jan 2023 13:45:21 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert culture attribute

Marked as reviewed by lancea (Reviewer).

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From ihse at openjdk.org  Wed Jan 25 13:56:21 2023
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Wed, 25 Jan 2023 13:56:21 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: <-Mjbn1ko2InJOzXLccieEzU8h4bypdm9vTzHdmtA-JQ=.2e1f4d59-e30e-434a-8e62-25777adb3a07@github.com>

On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert culture attribute

I skimmed through this, basically looking for trailing white space changes only, and it generally looks okay.

Note that some of these trailing whitespace fixes has been independently address in mainline. Forward-porting this might involve some (virtual) conflicts.

It is also impossible to see in the Github interface if you are introducing *new* trailing white spaces in the added texts. I hope you are not, and that you have verified this.

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.org/jdk20/pull/116

From naoto at openjdk.org  Wed Jan 25 16:55:04 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 25 Jan 2023 16:55:04 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert culture attribute

LGTM

-------------

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.org/jdk20/pull/116

From weijun at openjdk.org  Wed Jan 25 17:36:38 2023
From: weijun at openjdk.org (Weijun Wang)
Date: Wed, 25 Jan 2023 17:36:38 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: <_THK1t7SrTRqoW0o0gfgmCo1Ea1WfgdfeB7jNJDKUKk=.05512373-8cb2-41d3-a71f-589075240bb7@github.com>

On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert culture attribute

src/jdk.jdeps/share/classes/com/sun/tools/javap/resources/javap_zh_CN.properties line 32:

> 30: err.bad.constant.pool=\u8BFB\u53D6{0}\u7684\u5E38\u91CF\u6C60\u65F6\u51FA\u9519: {1}
> 31: err.class.not.found=\u627E\u4E0D\u5230\u7C7B: {0}
> 32: err.crash=\u51FA\u73B0\u4E25\u91CD\u7684\u5185\u90E8\u9519\u8BEF\uFF1A{0}\n\u8BF7\u586B\u5199 Bug \u62A5\u544A\uFF0C\u5E76\u5305\u62EC\u4EE5\u4E0B\u4FE1\u606F\uFF1A\n{1}

While personally I like to see Chinese-style punctuation marks (Ex: `?`) used in Chinese contexts instead of their English-style ones (Ex: `:`), it's only updated on this single line and all the others are still using the English-style.

There should be a general rule on which style we should use throughout all display messages.

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Wed Jan 25 17:47:19 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 25 Jan 2023 17:47:19 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v6]
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: 

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Revert translated punctuation

-------------

Changes:
  - all: https://git.openjdk.org/jdk20/pull/116/files
  - new: https://git.openjdk.org/jdk20/pull/116/files/616b2502..4222df9a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk20/pull/116.diff
  Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Wed Jan 25 17:51:20 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 25 Jan 2023 17:51:20 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v7]
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: <5QDH5Zhiji1PTh-833JdIopABeDoDCLA5e-u1Q3pkUE=.98a38bd3-3e52-4b51-9287-dc70454c4b89@github.com>

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Revert one more punctuation

-------------

Changes:
  - all: https://git.openjdk.org/jdk20/pull/116/files
  - new: https://git.openjdk.org/jdk20/pull/116/files/4222df9a..9a5b45a2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=05-06

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk20/pull/116.diff
  Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116

PR: https://git.openjdk.org/jdk20/pull/116

From weijun at openjdk.org  Wed Jan 25 17:52:21 2023
From: weijun at openjdk.org (Weijun Wang)
Date: Wed, 25 Jan 2023 17:52:21 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert culture attribute

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_zh_CN.properties line 113:

> 111: doclet.inheritDocWithinInappropriateTag=\u4E0D\u80FD\u5728\u6B64\u6807\u8BB0\u4E2D\u4F7F\u7528 @inheritDoc
> 112: doclet.inheritDocNoDoc=\u88AB\u8986\u76D6\u7684\u65B9\u6CD5\u4E0D\u8BB0\u5F55\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B {0}
> 113: doclet.throwsInheritDocUnsupported=\u4E0D\u662F\u7531\u65B9\u6CD5\u58F0\u660E\u7684 exception-type \u7C7B\u578B\u53C2\u6570\u4E0D\u652F\u6301 @inheritDoc\uFF1B\u76F4\u63A5\u8BB0\u5F55\u6B64\u7C7B\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B

Should `exception-type` be translated?

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Wed Jan 25 18:03:54 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 25 Jan 2023 18:03:54 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Wed, 25 Jan 2023 17:49:59 GMT, Weijun Wang  wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert culture attribute
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_zh_CN.properties line 113:
> 
>> 111: doclet.inheritDocWithinInappropriateTag=\u4E0D\u80FD\u5728\u6B64\u6807\u8BB0\u4E2D\u4F7F\u7528 @inheritDoc
>> 112: doclet.inheritDocNoDoc=\u88AB\u8986\u76D6\u7684\u65B9\u6CD5\u4E0D\u8BB0\u5F55\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B {0}
>> 113: doclet.throwsInheritDocUnsupported=\u4E0D\u662F\u7531\u65B9\u6CD5\u58F0\u660E\u7684 exception-type \u7C7B\u578B\u53C2\u6570\u4E0D\u652F\u6301 @inheritDoc\uFF1B\u76F4\u63A5\u8BB0\u5F55\u6B64\u7C7B\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
> 
> Should `exception-type` be translated?

The translation tool didn't seem to translate this. Either because it couldn't or because it somehow missed it. I'm not sure which, but I'm open to replacing this with a translation suggestion you have. Or I can leave it as is.

> src/jdk.jdeps/share/classes/com/sun/tools/javap/resources/javap_zh_CN.properties line 32:
> 
>> 30: err.bad.constant.pool=\u8BFB\u53D6{0}\u7684\u5E38\u91CF\u6C60\u65F6\u51FA\u9519: {1}
>> 31: err.class.not.found=\u627E\u4E0D\u5230\u7C7B: {0}
>> 32: err.crash=\u51FA\u73B0\u4E25\u91CD\u7684\u5185\u90E8\u9519\u8BEF\uFF1A{0}\n\u8BF7\u586B\u5199 Bug \u62A5\u544A\uFF0C\u5E76\u5305\u62EC\u4EE5\u4E0B\u4FE1\u606F\uFF1A\n{1}
> 
> While personally I like to see Chinese-style punctuation marks (Ex: `?`) used in Chinese contexts instead of their English-style ones (Ex: `:`), it's only updated on this single line and all the others are still using the English-style.
> 
> There should be a general rule on which style we should use throughout all display messages.

Updated the punctuation (colons and comma) to be more consistent throughout the file.

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From weijun at openjdk.org  Wed Jan 25 18:03:55 2023
From: weijun at openjdk.org (Weijun Wang)
Date: Wed, 25 Jan 2023 18:03:55 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Wed, 25 Jan 2023 17:56:15 GMT, Damon Nguyen  wrote:

>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_zh_CN.properties line 113:
>> 
>>> 111: doclet.inheritDocWithinInappropriateTag=\u4E0D\u80FD\u5728\u6B64\u6807\u8BB0\u4E2D\u4F7F\u7528 @inheritDoc
>>> 112: doclet.inheritDocNoDoc=\u88AB\u8986\u76D6\u7684\u65B9\u6CD5\u4E0D\u8BB0\u5F55\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B {0}
>>> 113: doclet.throwsInheritDocUnsupported=\u4E0D\u662F\u7531\u65B9\u6CD5\u58F0\u660E\u7684 exception-type \u7C7B\u578B\u53C2\u6570\u4E0D\u652F\u6301 @inheritDoc\uFF1B\u76F4\u63A5\u8BB0\u5F55\u6B64\u7C7B\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
>> 
>> Should `exception-type` be translated?
>
> The translation tool didn't seem to translate this. Either because it couldn't or because it somehow missed it. I'm not sure which, but I'm open to replacing this with a translation suggestion you have. Or I can leave it as is.

I'm not sure either. You can ask a javadoc expert whether this is a proper noun or just plain English. I noticed it's also not translated in the Japanese version but the German version has translated it.

>> src/jdk.jdeps/share/classes/com/sun/tools/javap/resources/javap_zh_CN.properties line 32:
>> 
>>> 30: err.bad.constant.pool=\u8BFB\u53D6{0}\u7684\u5E38\u91CF\u6C60\u65F6\u51FA\u9519: {1}
>>> 31: err.class.not.found=\u627E\u4E0D\u5230\u7C7B: {0}
>>> 32: err.crash=\u51FA\u73B0\u4E25\u91CD\u7684\u5185\u90E8\u9519\u8BEF\uFF1A{0}\n\u8BF7\u586B\u5199 Bug \u62A5\u544A\uFF0C\u5E76\u5305\u62EC\u4EE5\u4E0B\u4FE1\u606F\uFF1A\n{1}
>> 
>> While personally I like to see Chinese-style punctuation marks (Ex: `?`) used in Chinese contexts instead of their English-style ones (Ex: `:`), it's only updated on this single line and all the others are still using the English-style.
>> 
>> There should be a general rule on which style we should use throughout all display messages.
>
> Updated the punctuation (colons and comma) to be more consistent throughout the file.

Looks good now.

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From jjg at openjdk.org  Wed Jan 25 18:24:55 2023
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Jan 2023 18:24:55 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v7]
In-Reply-To: <5QDH5Zhiji1PTh-833JdIopABeDoDCLA5e-u1Q3pkUE=.98a38bd3-3e52-4b51-9287-dc70454c4b89@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
 <5QDH5Zhiji1PTh-833JdIopABeDoDCLA5e-u1Q3pkUE=.98a38bd3-3e52-4b51-9287-dc70454c4b89@github.com>
Message-ID: 

On Wed, 25 Jan 2023 17:51:20 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert one more punctuation

I don't see anything absurdly wrong in the jdk.compiler files.

-------------

Marked as reviewed by jjg (Reviewer).

PR: https://git.openjdk.org/jdk20/pull/116

From weijun at openjdk.org  Wed Jan 25 18:58:57 2023
From: weijun at openjdk.org (Weijun Wang)
Date: Wed, 25 Jan 2023 18:58:57 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v7]
In-Reply-To: <5QDH5Zhiji1PTh-833JdIopABeDoDCLA5e-u1Q3pkUE=.98a38bd3-3e52-4b51-9287-dc70454c4b89@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
 <5QDH5Zhiji1PTh-833JdIopABeDoDCLA5e-u1Q3pkUE=.98a38bd3-3e52-4b51-9287-dc70454c4b89@github.com>
Message-ID: 

On Wed, 25 Jan 2023 17:51:20 GMT, Damon Nguyen  wrote:

>> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert one more punctuation

zh_cn translations look fine. Thanks.

-------------

Marked as reviewed by weijun (Reviewer).

PR: https://git.openjdk.org/jdk20/pull/116

From prappo at openjdk.org  Wed Jan 25 20:06:53 2023
From: prappo at openjdk.org (Pavel Rappo)
Date: Wed, 25 Jan 2023 20:06:53 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Wed, 25 Jan 2023 18:00:33 GMT, Weijun Wang  wrote:

>> The translation tool didn't seem to translate this. Either because it couldn't or because it somehow missed it. I'm not sure which, but I'm open to replacing this with a translation suggestion you have. Or I can leave it as is.
>
> I'm not sure either. You can ask a javadoc expert whether this is a proper noun or just plain English. I noticed it's also not translated in the Japanese version but the German version has translated it.

It's not a noun. It's an adjective that I had to synthesize for extra clarity and closeness to Java Language Specification (JLS). The English version of that entry is as follows:

    doclet.throwsInheritDocUnsupported=@inheritDoc is not supported for exception-type type parameters \
    that are not declared by a method; document such exception types directly

JLS _8.4.6. Method Throws_ defines BNF which conveniently labels elements, a list of which may appear in the `throws` clause, as `ExceptionType`. To make it more English-like and separate two otherwise consecutive occurrences of "type" in that sentence, I split the words with a hyphen and lower-cased them: exception-type.

@jonathan-gibbons thoughts?

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Wed Jan 25 22:02:45 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 25 Jan 2023 22:02:45 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v8]
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: 

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Update German translation

-------------

Changes:
  - all: https://git.openjdk.org/jdk20/pull/116/files
  - new: https://git.openjdk.org/jdk20/pull/116/files/9a5b45a2..35829a25

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=06-07

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk20/pull/116.diff
  Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Wed Jan 25 22:19:34 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 25 Jan 2023 22:19:34 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v2]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Wed, 25 Jan 2023 08:17:26 GMT, danielpeintner  wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change German help of jar command
>
> src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_de.properties line 111:
> 
>> 109: main.help.opt.main.update=\  -u, --update               Ein vorhandenes JAR-Archiv aktualisieren
>> 110: main.help.opt.main.extract=\  -x, --extract              Benannte (oder alle) Dateien aus dem Archiv extrahieren
>> 111: main.help.opt.main.describe-module=\  -d, --describe-module      Gibt den Moduldeskriptor oder automatischen Modulnamen aus
> 
> Just because I stumbled over this commit. I think the line should be translated as follows:
> 
> `Gibt die Modulbeschreibung oder den automatischen Modulnamen aus`

Resolved

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From jjg at openjdk.org  Wed Jan 25 22:41:34 2023
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Jan 2023 22:41:34 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Wed, 25 Jan 2023 20:03:48 GMT, Pavel Rappo  wrote:

>> I'm not sure either. You can ask a javadoc expert whether this is a proper noun or just plain English. I noticed it's also not translated in the Japanese version but the German version has translated it.
>
> It's not a noun. It's an adjective that I had to synthesize for extra clarity and closeness to Java Language Specification (JLS). The English version of that entry is as follows:
> 
>     doclet.throwsInheritDocUnsupported=@inheritDoc is not supported for exception-type type parameters \
>     that are not declared by a method; document such exception types directly
> 
> JLS _8.4.6. Method Throws_ defines BNF which conveniently labels elements, a list of which may appear in the `throws` clause, as `ExceptionType`. To make it more English-like and separate two otherwise consecutive occurrences of "type" in that sentence, I split the words with a hyphen and lower-cased them: exception-type.
> 
> @jonathan-gibbons thoughts?

While the text is technically correct, it may not be as clear as it could be to all folk that will read this message for whom English is not their primary language.

I would suggest translating the phrase as if it were something like

@inheritDoc is not supported for type parameters that are exception types and not declared by a method

and secondarily, changing the English resource to something like that as well.

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Wed Jan 25 22:56:59 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 25 Jan 2023 22:56:59 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v9]
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: 

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Replace exception-type

-------------

Changes:
  - all: https://git.openjdk.org/jdk20/pull/116/files
  - new: https://git.openjdk.org/jdk20/pull/116/files/35829a25..53a86ef2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=07-08

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk20/pull/116.diff
  Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Wed Jan 25 22:56:59 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 25 Jan 2023 22:56:59 GMT
Subject:  [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource
 files update [v5]
In-Reply-To: 
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>

Message-ID: 

On Wed, 25 Jan 2023 22:38:38 GMT, Jonathan Gibbons  wrote:

>> It's not a noun. It's an adjective that I had to synthesize for extra clarity and closeness to Java Language Specification (JLS). The English version of that entry is as follows:
>> 
>>     doclet.throwsInheritDocUnsupported=@inheritDoc is not supported for exception-type type parameters \
>>     that are not declared by a method; document such exception types directly
>> 
>> JLS _8.4.6. Method Throws_ defines BNF which conveniently labels elements, a list of which may appear in the `throws` clause, as `ExceptionType`. To make it more English-like and separate two otherwise consecutive occurrences of "type" in that sentence, I split the words with a hyphen and lower-cased them: exception-type.
>> 
>> @jonathan-gibbons thoughts?
>
> While the text is technically correct, it may not be as clear as it could be to all folk that will read this message for whom English is not their primary language.
> 
> I would suggest translating the phrase as if it were something like
> 
> @inheritDoc is not supported for type parameters that are exception types and not declared by a method
> 
> 
> and secondarily, changing the English resource to something like that as well.

Updated this line with `exception-type` translated. Hopefully this will be addressed in future drops with changes to the translation tool after some bug fixes.

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Thu Jan 26 22:36:39 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 26 Jan 2023 22:36:39 GMT
Subject:  [jdk20] Integrated: 8300719: JDK 20 RDP2 L10n resource
 files update
In-Reply-To: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
References: <0fuTtDy_5ZjAaxfJV75WRG8xQ76Tj-oM5hdYpG-yfkk=.a4ce241d-52a8-422a-9e1e-40de0afa78cb@github.com>
Message-ID: 

On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen  wrote:

> Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files.
> All tests passed

This pull request has now been integrated.

Changeset: a67b1e77
Author:    Damon Nguyen 
Committer: Naoto Sato 
URL:       https://git.openjdk.org/jdk20/commit/a67b1e77d33339f5db36c6d15bac0423a31eb5ee
Stats:     1023 lines in 82 files changed: 218 ins; 114 del; 691 mod

8300719: JDK 20 RDP2 L10n resource files update

Reviewed-by: cjplummer, naoto, prr, joehw, asemenyuk, jlu, lancea, ihse, jjg, weijun

-------------

PR: https://git.openjdk.org/jdk20/pull/116

From dnguyen at openjdk.org  Fri Jan 27 01:50:08 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 27 Jan 2023 01:50:08 GMT
Subject:  [jdk20] RFR: 8301206: Fix issue with LocaleData after
 JDK-8300719
Message-ID: 

Localization update didn't include an update to LocaleData file. This PR addresses this by updating the file with the newly translated values. The LocaleDataTest now passes. This should address the recent related failures to LocaleData.

-------------

Commit messages:
 - Update LocaleData

Changes: https://git.openjdk.org/jdk20/pull/118/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=118&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8301206
  Stats: 52 lines in 1 file changed: 0 ins; 0 del; 52 mod
  Patch: https://git.openjdk.org/jdk20/pull/118.diff
  Fetch: git fetch https://git.openjdk.org/jdk20 pull/118/head:pull/118

PR: https://git.openjdk.org/jdk20/pull/118

From naoto at openjdk.org  Fri Jan 27 02:05:24 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 27 Jan 2023 02:05:24 GMT
Subject:  [jdk20] RFR: 8301206: Fix issue with LocaleData
 after JDK-8300719
In-Reply-To: 
References: 
Message-ID: 

On Fri, 27 Jan 2023 01:43:11 GMT, Damon Nguyen  wrote:

> Localization update didn't include an update to LocaleData file. This PR addresses this by updating the file with the newly translated values. The LocaleDataTest now passes. This should address the recent related failures to LocaleData.

The fix itself looks good. Add the bug id to `LocaleDataTest.java`

-------------

PR: https://git.openjdk.org/jdk20/pull/118

From dnguyen at openjdk.org  Fri Jan 27 02:34:37 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 27 Jan 2023 02:34:37 GMT
Subject:  [jdk20] RFR: 8301206: Fix issue with LocaleData
 after JDK-8300719 [v2]
In-Reply-To: 
References: 
Message-ID: 

> Localization update didn't include an update to LocaleData file. This PR addresses this by updating the file with the newly translated values. The LocaleDataTest now passes. This should address the recent related failures to LocaleData.

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Add bugid. Update year

-------------

Changes:
  - all: https://git.openjdk.org/jdk20/pull/118/files
  - new: https://git.openjdk.org/jdk20/pull/118/files/a1d7fc21..87a37655

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk20&pr=118&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=118&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk20/pull/118.diff
  Fetch: git fetch https://git.openjdk.org/jdk20 pull/118/head:pull/118

PR: https://git.openjdk.org/jdk20/pull/118

From dnguyen at openjdk.org  Fri Jan 27 02:54:16 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 27 Jan 2023 02:54:16 GMT
Subject:  [jdk20] RFR: 8301206: Fix issue with LocaleData
 after JDK-8300719 [v2]
In-Reply-To: 
References: 

Message-ID: <9AKbqVXq9FN90NcKKnCEKl0U8CV26o8p_2ogpQPXTbU=.ed3fe886-ce24-4380-a3b0-dbe0b9ce5203@github.com>

On Fri, 27 Jan 2023 02:02:34 GMT, Naoto Sato  wrote:

> The fix itself looks good. Add the bug id to `LocaleDataTest.java`

Added BugID to the list of BugID's in `LocaleDataTest.java`

-------------

PR: https://git.openjdk.org/jdk20/pull/118

From naoto at openjdk.org  Fri Jan 27 13:32:21 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 27 Jan 2023 13:32:21 GMT
Subject:  [jdk20] RFR: 8301206: Fix issue with LocaleData
 after JDK-8300719 [v2]
In-Reply-To: 
References: 

Message-ID: 

On Fri, 27 Jan 2023 02:34:37 GMT, Damon Nguyen  wrote:

>> Localization update didn't include an update to LocaleData file. This PR addresses this by updating the file with the newly translated values. The LocaleDataTest now passes. This should address the recent related failures to LocaleData.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add bugid. Update year

Marked as reviewed by naoto (Reviewer).

-------------

PR: https://git.openjdk.org/jdk20/pull/118

From rgiulietti at openjdk.org  Fri Jan 27 16:10:23 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Fri, 27 Jan 2023 16:10:23 GMT
Subject:  RFR: 8300869: Make use of the Double.toString(double)
 algorithm in java.util.Formatter
Message-ID: 

Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.

-------------

Commit messages:
 - 8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter

Changes: https://git.openjdk.org/jdk/pull/12259/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8300869
  Stats: 720 lines in 4 files changed: 319 ins; 372 del; 29 mod
  Patch: https://git.openjdk.org/jdk/pull/12259.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12259/head:pull/12259

PR: https://git.openjdk.org/jdk/pull/12259

From rgiulietti at openjdk.org  Fri Jan 27 16:18:17 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Fri, 27 Jan 2023 16:18:17 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter
In-Reply-To: 
References: 
Message-ID: 

On Fri, 27 Jan 2023 16:02:38 GMT, Raffaello Giulietti  wrote:

> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.

The specification in `Formatter` explicitly refers to the outcome of `Double.toString(double)`. However, it currently uses another implementation for the floating-point to decimal conversion, which might end up in rare, slightly different outcomes than the ones described in the specification.

This fixes the discrepancy between specification and implementation in `Formatter`.

Class `jdk.internal.math.FormattedFPDecimal` replaces `jdk.internal.math.FormattedFloatingDecimal`, which is no longer needed.

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From dnguyen at openjdk.org  Fri Jan 27 17:25:25 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 27 Jan 2023 17:25:25 GMT
Subject:  [jdk20] Integrated: 8301206: Fix issue with LocaleData
 after JDK-8300719
In-Reply-To: 
References: 
Message-ID: <06LTdXFKqGB_hvVkZ4zUC0DsiY_WPwLuTt9d6Yqu6-k=.26533a47-ed2a-4e61-b749-0efbaab0010b@github.com>

On Fri, 27 Jan 2023 01:43:11 GMT, Damon Nguyen  wrote:

> Localization update didn't include an update to LocaleData file. This PR addresses this by updating the file with the newly translated values. The LocaleDataTest now passes. This should address the recent related failures to LocaleData.

This pull request has now been integrated.

Changeset: e5860ef6
Author:    Damon Nguyen 
Committer: Naoto Sato 
URL:       https://git.openjdk.org/jdk20/commit/e5860ef60a9353508afb09716158baf8bfb35559
Stats:     54 lines in 2 files changed: 1 ins; 0 del; 53 mod

8301206: Fix issue with LocaleData after JDK-8300719

Reviewed-by: naoto

-------------

PR: https://git.openjdk.org/jdk20/pull/118

From rgiulietti at openjdk.org  Fri Jan 27 18:19:58 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Fri, 27 Jan 2023 18:19:58 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v2]
In-Reply-To: 
References: 
Message-ID: 

> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.

Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:

  8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter

  Added tests for known differences between current and new behavior.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12259/files
  - new: https://git.openjdk.org/jdk/pull/12259/files/bcbbe1e9..d42fbd03

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=00-01

  Stats: 188 lines in 20 files changed: 168 ins; 0 del; 20 mod
  Patch: https://git.openjdk.org/jdk/pull/12259.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12259/head:pull/12259

PR: https://git.openjdk.org/jdk/pull/12259

From rgiulietti at openjdk.org  Fri Jan 27 18:25:17 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Fri, 27 Jan 2023 18:25:17 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v2]
In-Reply-To: 
References: 

Message-ID: 

On Fri, 27 Jan 2023 18:19:58 GMT, Raffaello Giulietti  wrote:

>> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter
>   
>   Added tests for known differences between current and new behavior.

Added tests for known differences.

Most of the modified files are generated automatically by a script that, somewhat questionably, renews the copyright year in some of the files for no apparent reason.

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From duke at openjdk.org  Fri Jan 27 18:43:34 2023
From: duke at openjdk.org (duke)
Date: Fri, 27 Jan 2023 18:43:34 GMT
Subject:  Withdrawn: 8296546: Add @spec tags to API
In-Reply-To: <5uS_XWg0xRt6Rp20wY65rAmNRcDrp5XN_74k1aQ_4jk=.9f458354-9bca-473e-b60e-e520fa90724b@github.com>
References: <5uS_XWg0xRt6Rp20wY65rAmNRcDrp5XN_74k1aQ_4jk=.9f458354-9bca-473e-b60e-e520fa90724b@github.com>
Message-ID: 

On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons  wrote:

> Please review a "somewhat automated" change to insert `@spec` tags into doc comments, as appropriate, to leverage the recent new javadoc feature to generate a new page listing the references to all external specifications listed in the `@spec` tags.
> 
> "Somewhat automated" means that I wrote and used a temporary utility to scan doc comments looking for HTML links to selected sites, such as `ietf.org`, `unicode.org`, `w3.org`. These links may be in the main description of a doc comment, or in `@see` tags. For each link, the URL is examined, and "normalized", and inserted into the doc comment with a new `@spec` tag, giving the link and tile for the spec.
> 
> "Normalized" means...
> * Use `https:` where possible (includes pretty much all cases)
> * Use a single consistent host name for all URLs coming from the same spec site (i.e. don't use different aliases for the same site)
> * Point to the root page of a multi-page spec
> * Use a consistent form of the spec, preferring HTML over plain text where both are available (this mostly applies to IETF specs)
> 
> In addition, a "standard" title is determined for all specs,  determined either from the content of the (main) spec page or from site index pages.
> 
> The net effect is (or should be) that **all** the changes are to just **add** new `@spec` tags, based on the links found in each doc comment. There should be no other changes to the doc comments, or to the implementation of any classes and interfaces.
> 
> That being said, the utility I wrote does have additional abilities, to update the links that it finds (e.g. changing to use `https:` etc,) but those features are _not_ being used here, but could be used in followup PRs if component teams so desired. I did notice while working on this overall feature that many of our links do point to "outdated" pages, some with eye-catching notices declaring that the spec has been superseded. Determining how, when and where to update such links is beyond the scope of this PR.
> 
> Going forward, it is to be hoped that component teams will maintain the underlying links, and the URLs in `@spec` tags, such that if references to external specifications are updated, this will include updating the `@spec` tags.
> 
> To see the effect of all these new `@spec` tags, see http://cr.openjdk.java.net/~jjg/8296546/api.00/
> 
> In particular, see the new [External Specifications](http://cr.openjdk.java.net/~jjg/8296546/api.00/external-specs.html) page, which you can also find via the new link near the top of the [Index](http://cr.openjdk.java.net/~jjg/8296546/api.00/index-files/index-1.html) pages.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/11073

From rriggs at openjdk.org  Fri Jan 27 19:59:19 2023
From: rriggs at openjdk.org (Roger Riggs)
Date: Fri, 27 Jan 2023 19:59:19 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v2]
In-Reply-To: 
References: 

Message-ID: 

On Fri, 27 Jan 2023 18:19:58 GMT, Raffaello Giulietti  wrote:

>> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter
>   
>   Added tests for known differences between current and new behavior.

test/jdk/java/util/Formatter/BasicInt.java line 1:

> 1: /*

It looks line the non-float/double test classes are unchanged, they could be dropped from the PR.

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From jwilhelm at openjdk.org  Fri Jan 27 21:08:40 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 27 Jan 2023 21:08:40 GMT
Subject:  RFR: Merge jdk20
Message-ID: <7o8i6xuRhpJrSJJg2EUyu-JPcawJAytTWS3yHX3PZd0=.0157940a-bbb2-4dc0-a645-5cde446d5052@github.com>

Forwardport JDK 20 -> JDK 21

-------------

Commit messages:
 - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20
 - 8301206: Fix issue with LocaleData after JDK-8300719
 - 8300953: ClassDesc::ofInternalName missing @since tag
 - 8300719: JDK 20 RDP2 L10n resource files update

The webrevs contain the adjustments done while merging with regards to each parent branch:
 - master: https://webrevs.openjdk.org/?repo=jdk&pr=12267&range=00.0
 - jdk20: https://webrevs.openjdk.org/?repo=jdk&pr=12267&range=00.1

Changes: https://git.openjdk.org/jdk/pull/12267/files
  Stats: 1078 lines in 85 files changed: 220 ins; 114 del; 744 mod
  Patch: https://git.openjdk.org/jdk/pull/12267.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12267/head:pull/12267

PR: https://git.openjdk.org/jdk/pull/12267

From rgiulietti at openjdk.org  Fri Jan 27 21:30:18 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Fri, 27 Jan 2023 21:30:18 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v2]
In-Reply-To: 
References: 

Message-ID: <_KVrr_BXbGV8pPxdRL3L4CHHR-0A8Y6KuSSDGEZSG_w=.b6a9b4b0-ebe8-4f74-80c0-dc9a42f73a22@github.com>

On Fri, 27 Jan 2023 19:56:28 GMT, Roger Riggs  wrote:

>> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter
>>   
>>   Added tests for known differences between current and new behavior.
>
> test/jdk/java/util/Formatter/BasicInt.java line 1:
> 
>> 1: /*
> 
> It looks line the non-float/double test classes are unchanged, they could be dropped from the PR.

The only changes I made myself in the test files are in Basic-X.java.template (including the copyright year). The other files were generated by a script, which happens to also change the copyright year for otherwise unmodified files.

If you agree, I'll happily remove the trivial copyright year changes and only retain those files containing more substantial modifications.

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From rriggs at openjdk.org  Fri Jan 27 22:13:19 2023
From: rriggs at openjdk.org (Roger Riggs)
Date: Fri, 27 Jan 2023 22:13:19 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v2]
In-Reply-To: <_KVrr_BXbGV8pPxdRL3L4CHHR-0A8Y6KuSSDGEZSG_w=.b6a9b4b0-ebe8-4f74-80c0-dc9a42f73a22@github.com>
References: 

 <_KVrr_BXbGV8pPxdRL3L4CHHR-0A8Y6KuSSDGEZSG_w=.b6a9b4b0-ebe8-4f74-80c0-dc9a42f73a22@github.com>
Message-ID: <9Bv6duFlBn492Tk9zzMa3P3c6Lzm7rViBUJwaAzkUlc=.0db9a6d8-f2e7-47c1-8647-c3a7d5be3069@github.com>

On Fri, 27 Jan 2023 21:27:57 GMT, Raffaello Giulietti  wrote:

>> test/jdk/java/util/Formatter/BasicInt.java line 1:
>> 
>>> 1: /*
>> 
>> It looks line the non-float/double test classes are unchanged, they could be dropped from the PR.
>
> The only changes I made myself in the test files are in Basic-X.java.template (including the copyright year). The other files were generated by a script, which happens to also change the copyright year for otherwise unmodified files.
> 
> If you agree, I'll happily remove the trivial copyright year changes and only retain those files containing more substantial modifications.

Fine with me, I figured it was the script that changed the copyright and otherwise generated the same as before.  tnx

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From rgiulietti at openjdk.org  Fri Jan 27 22:26:58 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Fri, 27 Jan 2023 22:26:58 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v3]
In-Reply-To: 
References: 
Message-ID: 

> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.

Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:

  8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter

  Reverted back copyright year of otherwise untouched files.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12259/files
  - new: https://git.openjdk.org/jdk/pull/12259/files/d42fbd03..6f026d45

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=01-02

  Stats: 14 lines in 14 files changed: 0 ins; 0 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/12259.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12259/head:pull/12259

PR: https://git.openjdk.org/jdk/pull/12259

From rgiulietti at openjdk.org  Fri Jan 27 22:26:58 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Fri, 27 Jan 2023 22:26:58 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v2]
In-Reply-To: <9Bv6duFlBn492Tk9zzMa3P3c6Lzm7rViBUJwaAzkUlc=.0db9a6d8-f2e7-47c1-8647-c3a7d5be3069@github.com>
References: 

 <_KVrr_BXbGV8pPxdRL3L4CHHR-0A8Y6KuSSDGEZSG_w=.b6a9b4b0-ebe8-4f74-80c0-dc9a42f73a22@github.com>
 <9Bv6duFlBn492Tk9zzMa3P3c6Lzm7rViBUJwaAzkUlc=.0db9a6d8-f2e7-47c1-8647-c3a7d5be3069@github.com>
Message-ID: 

On Fri, 27 Jan 2023 22:10:38 GMT, Roger Riggs  wrote:

>> The only changes I made myself in the test files are in Basic-X.java.template (including the copyright year). The other files were generated by a script, which happens to also change the copyright year for otherwise unmodified files.
>> 
>> If you agree, I'll happily remove the trivial copyright year changes and only retain those files containing more substantial modifications.
>
> Fine with me, I figured it was the script that changed the copyright and otherwise generated the same as before.  tnx

Otherwise untouched files are now reverted back with previous copyright year

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From jwilhelm at openjdk.org  Fri Jan 27 22:49:26 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 27 Jan 2023 22:49:26 GMT
Subject:  Integrated: Merge jdk20
In-Reply-To: <7o8i6xuRhpJrSJJg2EUyu-JPcawJAytTWS3yHX3PZd0=.0157940a-bbb2-4dc0-a645-5cde446d5052@github.com>
References: <7o8i6xuRhpJrSJJg2EUyu-JPcawJAytTWS3yHX3PZd0=.0157940a-bbb2-4dc0-a645-5cde446d5052@github.com>
Message-ID: 

On Fri, 27 Jan 2023 21:00:03 GMT, Jesper Wilhelmsson  wrote:

> Forwardport JDK 20 -> JDK 21

This pull request has now been integrated.

Changeset: 5c59de52
Author:    Jesper Wilhelmsson 
URL:       https://git.openjdk.org/jdk/commit/5c59de52a31da937663ad2cef055213489b0516e
Stats:     1078 lines in 85 files changed: 220 ins; 114 del; 744 mod

Merge

-------------

PR: https://git.openjdk.org/jdk/pull/12267

From aivanov at openjdk.org  Sat Jan 28 18:55:16 2023
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Sat, 28 Jan 2023 18:55:16 GMT
Subject:  RFR: 4934362: see also refers to self [v4]
In-Reply-To: 
References: 

Message-ID: 

On Mon, 9 Jan 2023 03:57:17 GMT, Prasanta Sadhukhan  wrote:

>> Some methods and constants has a hyperreference to self in javadoc which is rectified to reference proper methods
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Point to isEditable method

Marked as reviewed by aivanov (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/11820

From ihse at openjdk.org  Sat Jan 28 21:11:19 2023
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Sat, 28 Jan 2023 21:11:19 GMT
Subject:  RFR: 8298045: Fix hidden but significant trailing
 whitespace in properties files for core-libs code
In-Reply-To: 
References: 
Message-ID: 

On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie  wrote:

> According to [the specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) trailing whitespaces in the values of properties files are (somewhat surprisingly) actually significant.
> 
> We have multiple files in the JDK with trailing whitespaces in the values. For most of this files, this is likely incorrect and due to oversight, but in a few cases it might actually be intended (like "The value is: ").
> 
> After a discussion in the PR for [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729), the consensus was to replace valid trailing spaces with the corresponding unicode sequence, `\u0020`. (And of course remove non-wanted trailing spaces.)
> 
> Doing so has a dual benefit:
> 
> 1) It makes it clear to everyone reading the code that there is a trailing space and it is intended
> 
> 2) It will allow us to remove all actual trailing space characters, and turn on the corresponding check in jcheck to keep the properties files, just like all other source code files, free of trailing spaces.
> 
> Ultimately, the call of whether a trailing space is supposed to be there, or is a bug, lies with the respective component teams owning these files. Thus I have split up the set of properties files with trailing spaces in several groups, to match the JDK teams, and open a JBS issue for each of them. This issue is for code I believe belong with the core-libs team.

Bot-Keep-Alive-Ping

-------------

PR: https://git.openjdk.org/jdk/pull/11489

From rgiulietti at openjdk.org  Mon Jan 30 14:33:06 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Mon, 30 Jan 2023 14:33:06 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v4]
In-Reply-To: 
References: 
Message-ID: 

> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.

Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:

  8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12259/files
  - new: https://git.openjdk.org/jdk/pull/12259/files/6f026d45..d5592324

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=02-03

  Stats: 15 lines in 1 file changed: 15 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/12259.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12259/head:pull/12259

PR: https://git.openjdk.org/jdk/pull/12259

From darcy at openjdk.org  Mon Jan 30 18:44:43 2023
From: darcy at openjdk.org (Joe Darcy)
Date: Mon, 30 Jan 2023 18:44:43 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v2]
In-Reply-To: 
References: 

Message-ID: 

On Fri, 27 Jan 2023 18:22:11 GMT, Raffaello Giulietti  wrote:

>> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter
>>   
>>   Added tests for known differences between current and new behavior.
>
> Added tests for known differences.
> 
> Most of the modified files are generated automatically by a script that, somewhat questionably, renews the copyright year in some of the files for no apparent reason.

I've spoken to @rgiulietti about this PR; since there behavioral changes of possible interest, I'm requesting a CSR to cover those changes.

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From darcy at openjdk.org  Mon Jan 30 18:50:14 2023
From: darcy at openjdk.org (Joe Darcy)
Date: Mon, 30 Jan 2023 18:50:14 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v4]
In-Reply-To: 
References: 

Message-ID: 

On Mon, 30 Jan 2023 14:33:06 GMT, Raffaello Giulietti  wrote:

>> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter

test/jdk/java/util/Formatter/Basic-X.java.template line 935:

> 933: 
> 934:         //---------------------------------------------------------------------
> 935:         // %e - adoption of Double.toString(double) algorithm (8300869)

Nit: we generally don't use the bug ids in comments like this, usually at most relying on a bug listed in the test "@bug" line.

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From rgiulietti at openjdk.org  Mon Jan 30 18:54:32 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Mon, 30 Jan 2023 18:54:32 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v4]
In-Reply-To: 
References: 

Message-ID: 

On Mon, 30 Jan 2023 18:47:31 GMT, Joe Darcy  wrote:

>> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter
>
> test/jdk/java/util/Formatter/Basic-X.java.template line 935:
> 
>> 933: 
>> 934:         //---------------------------------------------------------------------
>> 935:         // %e - adoption of Double.toString(double) algorithm (8300869)
> 
> Nit: we generally don't use the bug ids in comments like this, usually at most relying on a bug listed in the test "@bug" line.

The bug id was added there because I'm not sure there's a way to add the @bug line to Basic-X.java.template`.

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From rgiulietti at openjdk.org  Mon Jan 30 19:49:31 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Mon, 30 Jan 2023 19:49:31 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v5]
In-Reply-To: 
References: 
Message-ID: 

> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.

Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:

  8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12259/files
  - new: https://git.openjdk.org/jdk/pull/12259/files/d5592324..0c72b743

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=03-04

  Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/12259.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12259/head:pull/12259

PR: https://git.openjdk.org/jdk/pull/12259

From rgiulietti at openjdk.org  Mon Jan 30 19:49:32 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Mon, 30 Jan 2023 19:49:32 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v4]
In-Reply-To: 
References: 

Message-ID: 

On Mon, 30 Jan 2023 14:33:06 GMT, Raffaello Giulietti  wrote:

>> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter

The CSR has been added.

It covers both a behavioral change due to the implementation change in this PR, _and_ a specification change to align it with the implementation (current and proposed), resolving a long standing mismatch in the `e`, `f`, and `g` conversions on `float` values.

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From darcy at openjdk.org  Mon Jan 30 19:51:56 2023
From: darcy at openjdk.org (Joe Darcy)
Date: Mon, 30 Jan 2023 19:51:56 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v4]
In-Reply-To: 
References: 

Message-ID: 

On Mon, 30 Jan 2023 18:52:11 GMT, Raffaello Giulietti  wrote:

>> test/jdk/java/util/Formatter/Basic-X.java.template line 935:
>> 
>>> 933: 
>>> 934:         //---------------------------------------------------------------------
>>> 935:         // %e - adoption of Double.toString(double) algorithm (8300869)
>> 
>> Nit: we generally don't use the bug ids in comments like this, usually at most relying on a bug listed in the test "@bug" line.
>
> The bug id was added there because I'm not sure there's a way to add the @bug line to Basic-X.java.template`.

I see; it might suffice in this case to rely on the bug information in the SCM history, but I don't have a strong opinion.

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From rgiulietti at openjdk.org  Mon Jan 30 20:12:59 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Mon, 30 Jan 2023 20:12:59 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v4]
In-Reply-To: 
References: 

Message-ID: 

On Mon, 30 Jan 2023 19:48:50 GMT, Joe Darcy  wrote:

>> The bug id was added there because I'm not sure there's a way to add the @bug line to Basic-X.java.template`.
>
> I see; it might suffice in this case to rely on the bug information in the SCM history, but I don't have a strong opinion.

In this specific `*.java.template` case, I think that the bug id in the comment somehow replaces the lack of the @bug line.
But I have no problems in removing it if there are stronger opinions.

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From stsypanov at openjdk.org  Tue Jan 31 11:54:47 2023
From: stsypanov at openjdk.org (Sergey Tsypanov)
Date: Tue, 31 Jan 2023 11:54:47 GMT
Subject:  RFR: 8301492: Modernize equals() method of
 ResourceBundle.CacheKey and Bundles.CacheKey
Message-ID: <5xdnQZ8wLrkyB6U2miAOizqpvHGTFzy7OF_a24CUabc=.db6a65d7-9a29-44dc-94aa-692fbbfc82c7@github.com>

`ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire outdated. This simple clean-up modernizes them.

-------------

Commit messages:
 - Copyright year update
 - Modernize Bubldes.equals()

Changes: https://git.openjdk.org/jdk/pull/12328/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12328&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8301492
  Stats: 13 lines in 2 files changed: 0 ins; 4 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/12328.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12328/head:pull/12328

PR: https://git.openjdk.org/jdk/pull/12328

From stsypanov at openjdk.org  Tue Jan 31 11:54:49 2023
From: stsypanov at openjdk.org (Sergey Tsypanov)
Date: Tue, 31 Jan 2023 11:54:49 GMT
Subject:  RFR: 8301492: Modernize equals() method of
 ResourceBundle.CacheKey and Bundles.CacheKey
In-Reply-To: <5xdnQZ8wLrkyB6U2miAOizqpvHGTFzy7OF_a24CUabc=.db6a65d7-9a29-44dc-94aa-692fbbfc82c7@github.com>
References: <5xdnQZ8wLrkyB6U2miAOizqpvHGTFzy7OF_a24CUabc=.db6a65d7-9a29-44dc-94aa-692fbbfc82c7@github.com>
Message-ID: 

On Tue, 31 Jan 2023 11:40:43 GMT, Sergey Tsypanov  wrote:

> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire outdated. This simple clean-up modernizes them.

Btw, in `ResourceBundle.CacheKey.equals()` can we replace

Module module = getModule();
Module caller = getCallerModule();
return Objects.equals(module, otherEntry.getModule()) &&
       Objects.equals(caller, otherEntry.getCallerModule());

with

return moduleRef.refersTo(otherEntry.getModule()) &&
        callerRef.refersTo(otherEntry.getCallerModule());

?

-------------

PR: https://git.openjdk.org/jdk/pull/12328

From rgiulietti at openjdk.org  Tue Jan 31 13:39:15 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Tue, 31 Jan 2023 13:39:15 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v6]
In-Reply-To: 
References: 
Message-ID: 

> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.

Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:

  8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12259/files
  - new: https://git.openjdk.org/jdk/pull/12259/files/0c72b743..bfe3d155

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=04-05

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/12259.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12259/head:pull/12259

PR: https://git.openjdk.org/jdk/pull/12259

From pminborg at openjdk.org  Tue Jan 31 16:09:34 2023
From: pminborg at openjdk.org (Per Minborg)
Date: Tue, 31 Jan 2023 16:09:34 GMT
Subject:  RFR: 8301552: Use AtomicReferenceArray for caching
 instead of CHM in ZoneOffset
Message-ID: 

`ZoneOffset` instances are cached by the `ZoneOffset` class itself for values in the range [-18h, 18h] for each second that is on an even quarter of an hour (i.e. at most 2*18*4+1 = 145 values). 

Instead of using a `ConcurrentHashMap` for caching instanced, we could instead use an `AtomicReferenceArray` with direct slot value access for said even seconds. This will improve performance and reduce the number of object even though the backing array will go from an initial 32 in the CHM to an initial/final 145 in the ARA. The CHM will contain much more objects and array slots for typical numbers of entries in the cache and will compute hash/bucket/collision on the hot code path for each cache access.

-------------

Commit messages:
 - Update copyright years
 - Use AtomicReferenceArray for caching instead of CHM

Changes: https://git.openjdk.org/jdk/pull/12346/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12346&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8301552
  Stats: 39 lines in 2 files changed: 22 ins; 6 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/12346.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12346/head:pull/12346

PR: https://git.openjdk.org/jdk/pull/12346

From pminborg at openjdk.org  Tue Jan 31 16:09:36 2023
From: pminborg at openjdk.org (Per Minborg)
Date: Tue, 31 Jan 2023 16:09:36 GMT
Subject:  RFR: 8301552: Use AtomicReferenceArray for caching
 instead of CHM in ZoneOffset
In-Reply-To: 
References: 
Message-ID: <1su0_EK4Sx_blL9MQLS7147NWLaYH80QCSvM2iyV7h4=.6c053033-45ce-4234-912c-3de05ee0ef46@github.com>

On Tue, 31 Jan 2023 15:57:43 GMT, Per Minborg  wrote:

> `ZoneOffset` instances are cached by the `ZoneOffset` class itself for values in the range [-18h, 18h] for each second that is on an even quarter of an hour (i.e. at most 2*18*4+1 = 145 values). 
> 
> Instead of using a `ConcurrentHashMap` for caching instanced, we could instead use an `AtomicReferenceArray` with direct slot value access for said even seconds. This will improve performance and reduce the number of object even though the backing array will go from an initial 32 in the CHM to an initial/final 145 in the ARA. The CHM will contain much more objects and array slots for typical numbers of entries in the cache and will compute hash/bucket/collision on the hot code path for each cache access.

src/java.base/share/classes/java/time/ZoneOffset.java line 432:

> 430:         if (totalSeconds % (15 * SECONDS_PER_MINUTE) == 0) {
> 431:             int slot = cacheSlot(totalSeconds);
> 432:             ZoneOffset cached = SECONDS_CACHE.get(slot);

I miss `AtomicReferenceArray::computeIfNull` that atomically will compute an element if the value at a certain index is `null`.

-------------

PR: https://git.openjdk.org/jdk/pull/12346

From mchung at openjdk.org  Tue Jan 31 17:35:22 2023
From: mchung at openjdk.org (Mandy Chung)
Date: Tue, 31 Jan 2023 17:35:22 GMT
Subject:  RFR: 8301492: Modernize equals() method of
 ResourceBundle.CacheKey and Bundles.CacheKey
In-Reply-To: <5xdnQZ8wLrkyB6U2miAOizqpvHGTFzy7OF_a24CUabc=.db6a65d7-9a29-44dc-94aa-692fbbfc82c7@github.com>
References: <5xdnQZ8wLrkyB6U2miAOizqpvHGTFzy7OF_a24CUabc=.db6a65d7-9a29-44dc-94aa-692fbbfc82c7@github.com>
Message-ID: <8ViNuPWf2wFEzWB7ZWJTbHHxOqI16j0eBzRLZGzOYB4=.bf101b4d-df41-4979-a07d-0caa992dad94@github.com>

On Tue, 31 Jan 2023 11:40:43 GMT, Sergey Tsypanov  wrote:

> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire outdated. This simple clean-up modernizes them.

return moduleRef.refersTo(otherEntry.getModule()) &&
        callerRef.refersTo(otherEntry.getCallerModule());

You need to check if module and caller module are non-null. 

`equals` returns true only if the module and callerModule of this `CacheKey` and other `CacheKey` are the same and non-null.

-------------

PR: https://git.openjdk.org/jdk/pull/12328

From bpb at openjdk.org  Tue Jan 31 18:15:24 2023
From: bpb at openjdk.org (Brian Burkhalter)
Date: Tue, 31 Jan 2023 18:15:24 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v4]
In-Reply-To: 
References: 

Message-ID: 

On Mon, 30 Jan 2023 20:10:17 GMT, Raffaello Giulietti  wrote:

>> I see; it might suffice in this case to rely on the bug information in the SCM history, but I don't have a strong opinion.
>
> In this specific `*.java.template` case, I think that the bug id in the comment somehow replaces the lack of the @bug line.
> But I have no problems in removing it if there are stronger opinions.

The `@bug` tag is in `BasicTestLauncher` which is where 8300869 should likely go.

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From rgiulietti at openjdk.org  Tue Jan 31 18:30:14 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Tue, 31 Jan 2023 18:30:14 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v7]
In-Reply-To: 
References: 
Message-ID: 

> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.

Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:

  8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12259/files
  - new: https://git.openjdk.org/jdk/pull/12259/files/bfe3d155..5e488a70

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12259&range=05-06

  Stats: 19 lines in 7 files changed: 0 ins; 0 del; 19 mod
  Patch: https://git.openjdk.org/jdk/pull/12259.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12259/head:pull/12259

PR: https://git.openjdk.org/jdk/pull/12259

From rgiulietti at openjdk.org  Tue Jan 31 18:30:15 2023
From: rgiulietti at openjdk.org (Raffaello Giulietti)
Date: Tue, 31 Jan 2023 18:30:15 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v4]
In-Reply-To: 
References: 

Message-ID: 

On Tue, 31 Jan 2023 18:12:45 GMT, Brian Burkhalter  wrote:

>> In this specific `*.java.template` case, I think that the bug id in the comment somehow replaces the lack of the @bug line.
>> But I have no problems in removing it if there are stronger opinions.
>
> The `@bug` tag is in `BasicTestLauncher` which is where 8300869 should likely go.

Thanks @bplb for pointing to the right place.
Done

-------------

PR: https://git.openjdk.org/jdk/pull/12259

From darcy at openjdk.org  Tue Jan 31 22:21:51 2023
From: darcy at openjdk.org (Joe Darcy)
Date: Tue, 31 Jan 2023 22:21:51 GMT
Subject:  RFR: 8300869: Make use of the
 Double.toString(double) algorithm in java.util.Formatter [v7]
In-Reply-To: 
References: 

Message-ID: 

On Tue, 31 Jan 2023 18:30:14 GMT, Raffaello Giulietti  wrote:

>> Align `double` and `float` decimal conversions in `java.util.Formatter` with the algorithm used in `Double.toString(double)`.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter

Marked as reviewed by darcy (Reviewer).

src/java.base/share/classes/jdk/internal/math/FormattedFPDecimal.java line 28:

> 26: package jdk.internal.math;
> 27: 
> 28: public final class FormattedFPDecimal {

I suggest adding a short explanation of what this class is used for.

-------------

PR: https://git.openjdk.org/jdk/pull/12259