<i18n dev> RFR: 8299677: Formatter.format might take a long time to format an integer or floating-point [v4]

Sergey Tsypanov stsypanov at openjdk.org
Thu Jan 12 11:43:15 UTC 2023


On Wed, 11 Jan 2023 19:34:39 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> This change transforms a O(n^2) path to O(n) when prepending zero padding to decimal outputs, where n is the length of the padding.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8299677: Formatter.format might take a long time to format an integer or floating-point

src/java.base/share/classes/java/util/Formatter.java line 4600:

> 4598:             // apply zero padding
> 4599:             if (width > sb.length() && Flags.contains(f, Flags.ZERO_PAD)) {
> 4600:                 String zeros = Character.toString(zero).repeat(width - sb.length());

`Character.toString(zero)` could be replaced with `String.valueOf(zero)` saving one more method call

-------------

PR: https://git.openjdk.org/jdk/pull/11939


More information about the i18n-dev mailing list