<i18n dev> RFR: 8299677: Formatter.format might take a long time to format an integer or floating-point [v4]

Lance Andersen lancea at openjdk.org
Thu Jan 12 12:25:15 UTC 2023


On Wed, 11 Jan 2023 19:34:39 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> This change transforms a O(n^2) path to O(n) when prepending zero padding to decimal outputs, where n is the length of the padding.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8299677: Formatter.format might take a long time to format an integer or floating-point

Overall this looks OK.  

Please add either a general comment describing what we are trying to test or a comment for each test method.  As we add new tests,  adding comments for additional clarity will benefit future maintainers

-------------

PR: https://git.openjdk.org/jdk/pull/11939


More information about the i18n-dev mailing list