<i18n dev> RFR: 8300356: Refactor code examples to use @snippet in java.text.CollationElementIterator [v3]

Justin Lu jlu at openjdk.org
Wed Jan 18 19:02:38 UTC 2023


On Tue, 17 Jan 2023 23:58:39 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add unicode vertical ellipsis
>
> src/java.base/share/classes/java/text/CollationElementIterator.java line 82:
> 
>> 80:  * String testString = "This is a test";
>> 81:  * Collator col = Collator.getInstance();
>> 82:  * if (col instanceof RuleBasedCollator) {
> 
> I'd use the pattern matching `instanceof` here

Replaced the casting conversion with the pattern matching as you suggested, thank you

-------------

PR: https://git.openjdk.org/jdk/pull/12055


More information about the i18n-dev mailing list