<i18n dev> RFR: 8300818: Reduce complexity of padding with DateTimeFormatter [v2]

Sergey Tsypanov stsypanov at openjdk.org
Sun Jan 22 13:10:06 UTC 2023


On Sun, 22 Jan 2023 10:56:11 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Sergey Tsypanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into dtfb
>>  - Improve padding of DateTimeFormatter
>
> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 2603:
> 
>> 2601:         public boolean format(DateTimePrintContext context, StringBuilder buf) {
>> 2602:             int preLen = buf.length();
>> 2603:             if (!printerParser.format(context, buf)) {
> 
> Non-standard as it may be, this style of using `expr == false` instead of `!expr` is a style choice by the original author. I would advice against changing these piecemeal without discussion and agreement that we should consistently enforce the `!expr` style.

Sure, I'll revert it

-------------

PR: https://git.openjdk.org/jdk/pull/12131


More information about the i18n-dev mailing list