<i18n dev> RFR: 8311188: Simplify and modernize equals and hashCode in java.text [v3]

Pavel Rappo prappo at openjdk.org
Wed Jul 5 16:50:19 UTC 2023


> Please review this PR to use modern APIs and language features to simplify `equals` and `hashCode` in the java.text area.
> 
> * Some changes to `equals` and `hashCode` are refactoring rather than modernization. Such changes can be as trivial as rearranging, adding, or commenting checks.
> 
> * java.text area contains more classes whose `equals` and `hashCode` could be simplified; for example: sun.text.CompactByteArray or java.text.DigitList. However, I found no evidence of `equals` and `hashCode` in those classes being used in source or tests. Since writing new tests in this case seems unreasonable, I **excluded** those classes from this PR.

Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into 8311188
 - Adhere to surrounding code style
 - Initial commit

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14752/files
  - new: https://git.openjdk.org/jdk/pull/14752/files/b338480e..641fb1e5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14752&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14752&range=01-02

  Stats: 1750 lines in 166 files changed: 747 ins; 349 del; 654 mod
  Patch: https://git.openjdk.org/jdk/pull/14752.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14752/head:pull/14752

PR: https://git.openjdk.org/jdk/pull/14752


More information about the i18n-dev mailing list