<i18n dev> Integrated: 8310923: Refactor Currency tests to use JUnit

Justin Lu jlu at openjdk.org
Fri Jul 7 01:36:10 UTC 2023


On Tue, 27 Jun 2023 19:04:35 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which refactors Currency tests to use JUnit.
> 
> The most significant change occurs in `ValidateISO4217.java`. Other changes to this file excluding the JUnit refactoring include
> 
> - Tests are no longer dependent on each other (order of execution does not matter)
> - Testing does not occur at the same time as data generation (The data is fully generated before any tests are executed)
> - Various cleanup (dead-code, clarifying comments, more descriptive method and var names)
> 
> `Bug4512215.java` now renamed to `MinorUndefinedCodes` was updated to remove redundant testing, and the file changed to focus on testing minor undefined currency codes instead.

This pull request has now been integrated.

Changeset: e848d947
Author:    Justin Lu <jlu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e848d9471f5de86e5ac157b710cd7371f12f0024
Stats:     1089 lines in 9 files changed: 436 ins; 372 del; 281 mod

8310923: Refactor Currency tests to use JUnit

Reviewed-by: naoto, lancea

-------------

PR: https://git.openjdk.org/jdk/pull/14682


More information about the i18n-dev mailing list